PMD Results

The following document contains the results of PMD 5.0.2.

Files

org/andromda/timetracker/security/PasswordEncoder.java

Violation Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 15 - 31
Parameter 'plaintext' is not assigned and could be declared final 22
Avoid variables with short names like md 25
Local variable 'md' could be declared final 25
Local variable 'raw' could be declared final 27
Local variable 'hash' could be declared final 28
Consider simply returning the value vs storing it in local variable 'hash' 29

org/andromda/timetracker/vo/UserVOComparator.java

Violation Line
Avoid variables with short names like o2 20
Avoid variables with short names like o1 20
Parameter 'o2' is not assigned and could be declared final 20
Parameter 'o1' is not assigned and could be declared final 20
Avoid if (x != y) ..; else ..; 29 - 36
Useless parentheses. 29
Useless parentheses. 29
Useless parentheses. 33
Useless parentheses. 33