The following document contains the results of FindBugs Report
FindBugs Version is 1.2.0
Threshold is Low
Effort is Default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 391 | 91 | 0 | 1 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.andromda.core.common.BasePlugin.getPropertyReferences() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 158 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store of null to stream in org.andromda.core.common.BuildInformation.initialize() | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 86 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.andromda.core.common.ClassUtils.getInterfacesReversed(String) uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 267 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Redundant nullcheck of contents, which is known to be non-null in org.andromda.core.common.ComponentContainer.getDefaultImplementation(Class) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 280 |
| Write to static field org.andromda.core.common.ComponentContainer.instance from instance method org.andromda.core.common.ComponentContainer.shutdown() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 556 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.andromda.core.common.ExceptionRecorder.getUniqueName(String) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 224 |
| Exception is caught when Exception is not thrown in org.andromda.core.common.ExceptionRecorder.getUniqueName(String) | STYLE | REC_CATCH_EXCEPTION | 224 |
| Exception is caught when Exception is not thrown in org.andromda.core.common.ExceptionRecorder.record(String, Throwable, String) | STYLE | REC_CATCH_EXCEPTION | 158 |
| org.andromda.core.common.ExceptionRecorder.getUniqueName(String) calls Thread.sleep() with a lock held | MT_CORRECTNESS | SWL_SLEEP_WITH_LOCK_HELD | 206 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Null pointer dereference of name in org.andromda.core.common.Introspector.internalGetProperty(Object, String) | CORRECTNESS | NP_ALWAYS_NULL | 483 |
| Null pointer dereference of name in org.andromda.core.common.Introspector.internalSetProperty(Object, String, Object) | CORRECTNESS | NP_ALWAYS_NULL | 523 |
| Load of known null value in org.andromda.core.common.Introspector.internalGetProperty(Object, String) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 483 |
| Load of known null value in org.andromda.core.common.Introspector.internalSetProperty(Object, String, Object) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 523 |
| Method call in org.andromda.core.common.Introspector.internalGetProperty(Object, String) passes null for unconditionally dereferenced parameter of getReadMethod(Object, String) | CORRECTNESS | NP_NULL_PARAM_DEREF | 485 |
| Method call in org.andromda.core.common.Introspector.internalSetProperty(Object, String, Object) passes null for unconditionally dereferenced parameter of getWriteMethod(Object, String) | CORRECTNESS | NP_NULL_PARAM_DEREF | 541 |
| Write to static field org.andromda.core.common.Introspector.instance from instance method org.andromda.core.common.Introspector.shutdown() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 572 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store of null to inputReader in org.andromda.core.common.Merger.getMergedString(InputStream, String) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 130 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.andromda.core.common.ResourceFinder.findResources(String) uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 35 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store to delimiter in org.andromda.core.common.ResourceUtils.getDirectoryContents(URL, boolean, String[]) | STYLE | DLS_DEAD_LOCAL_STORE | 758 |
| Dead store of null to resourceInput in org.andromda.core.common.ResourceUtils.getContents(Reader) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 112 |
| Dead store of null to uriConnection in org.andromda.core.common.ResourceUtils.getLastModifiedTime(URL) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 443 |
| Dead store of null to stream in org.andromda.core.common.ResourceUtils.writeUrlToFile(URL, String, String) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 663 |
| org.andromda.core.common.ResourceUtils.getLastModifiedTime(URL) forces garbage collection; extremely dubious except in benchmarking code | PERFORMANCE | DM_GC | 444 |
| org.andromda.core.common.ResourceUtils.writeUrlToFile(URL, String, String) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 653 |
| org.andromda.core.common.ResourceUtils.writeUrlToFile(URL, String, String) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 638 |
| org.andromda.core.common.ResourceUtils.writeUrlToFile(URL, String, String) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 641 |
| Exception is caught when Exception is not thrown in org.andromda.core.common.ResourceUtils.getLastModifiedTime(URL) | STYLE | REC_CATCH_EXCEPTION | 447 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.andromda.core.common.ResourceWriter.writeStringToFile(String, String, String, boolean) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 177 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Dead store of null to stream in org.andromda.core.common.XmlObjectFactory.setValidating(boolean) | STYLE | DLS_DEAD_LOCAL_STORE_OF_NULL | 184 |
| Load of known null value in org.andromda.core.common.XmlObjectFactory.getObject(String, URL) | STYLE | NP_LOAD_OF_KNOWN_NULL_VALUE | 294 |
| Exception is caught when Exception is not thrown in org.andromda.core.common.XmlObjectFactory.setValidating(boolean) | STYLE | REC_CATCH_EXCEPTION | 213 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.andromda.core.configuration.Configuration.getMappingsSearchLocations() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 226 |
| Method org.andromda.core.configuration.Configuration.getNamespaces() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 126 |
| Method org.andromda.core.configuration.Configuration.getProperties() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 152 |
| Method org.andromda.core.configuration.Configuration.getRepositories() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 101 |
| org.andromda.core.configuration.Configuration is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.andromda.core.configuration.Filter is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.andromda.core.configuration.Filters.getFilters() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 75 |
| org.andromda.core.configuration.Filters is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.andromda.core.configuration.Location.getResources() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 107 |
| org.andromda.core.configuration.Location is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.andromda.core.configuration.Model.isChanged() is or uses a map or set of URLs, which can be a performance hog | PERFORMANCE | DMI_COLLECTION_OF_URLS | 475 |
| org.andromda.core.configuration.Model.getModuleSearchLocationPaths() may expose internal representation by returning Model.moduleSearchLocationPaths | MALICIOUS_CODE | EI_EXPOSE_REP | 316 |
| org.andromda.core.configuration.Model.getModuleSearchLocationResources() may expose internal representation by returning Model.moduleSearchLocationResources | MALICIOUS_CODE | EI_EXPOSE_REP | 348 |
| org.andromda.core.configuration.Model.getUris() may expose internal representation by returning Model.urisAsStrings | MALICIOUS_CODE | EI_EXPOSE_REP | 155 |
| Method org.andromda.core.configuration.Model.getModuleSearchLocationPaths() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 314 |
| Method org.andromda.core.configuration.Model.getModuleSearchLocationResources() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 346 |
| Method org.andromda.core.configuration.Model.getModuleSearchLocations() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 284 |
| Method org.andromda.core.configuration.Model.getTransformations() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 212 |
| org.andromda.core.configuration.Model is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.andromda.core.configuration.Namespace is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.andromda.core.configuration.Namespaces is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.andromda.core.configuration.Property is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.andromda.core.configuration.Repository.getModels() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 66 |
| org.andromda.core.configuration.Repository is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.andromda.core.configuration.Server is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.andromda.core.configuration.Transformation is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.andromda.core.engine.Engine.loadModelsIfNecessary(Configuration) uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 62 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.andromda.core.engine.ModelProcessor.filterInvalidModels(Model[]) uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 712 |
| Method org.andromda.core.engine.ModelProcessor.process(Configuration) uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 83 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.andromda.core.engine.ModelProcessor$ValidationMessageNameComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.andromda.core.engine.ModelProcessor$ValidationMessageTypeComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Mapping.mappings not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.andromda.core.metafacade.MetafacadeCache is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Class org.andromda.core.metafacade.MetafacadeFactory defines non-transient non-serializable instance field model | BAD_PRACTICE | SE_BAD_FIELD | Not available |
| org.andromda.core.metafacade.MetafacadeFactory is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Not available |
| Write to static field org.andromda.core.metafacade.MetafacadeFactory.instance from instance method org.andromda.core.metafacade.MetafacadeFactory.shutdown() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 788 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.andromda.core.metafacade.MetafacadeImpls.registerMetafacadeClasses(MetafacadeImpls$MetafacadeClasses, Namespaces, NamespaceRegistry) might ignore java.lang.Exception | BAD_PRACTICE | DE_MIGHT_IGNORE | 181 |
| org.andromda.core.metafacade.MetafacadeImpls is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.andromda.core.metafacade.MetafacadeMappings.initialize() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 840 |
| org.andromda.core.metafacade.MetafacadeMappings is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class org.andromda.core.metafacade.MetafacadeMappings$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class org.andromda.core.metafacade.MetafacadeMappings$2 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class org.andromda.core.metafacade.MetafacadeMappings$6 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| The class org.andromda.core.metafacade.MetafacadeMappings$8 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Class org.andromda.core.metafacade.ModelValidationMessage defines non-transient non-serializable instance field metafacade | BAD_PRACTICE | SE_BAD_FIELD | Not available |
| org.andromda.core.metafacade.ModelValidationMessage is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.andromda.core.namespace.Component.getPaths() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 55 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Write to static field org.andromda.core.namespace.NamespaceComponents.instance from instance method org.andromda.core.namespace.NamespaceComponents.shutdown() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 357 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.andromda.core.namespace.NamespaceComponents$NamespaceRegistryComparator implements Comparator but not Serializable | BAD_PRACTICE | SE_COMPARATOR_SHOULD_BE_SERIALIZABLE | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Method org.andromda.core.namespace.NamespaceRegistry.getPropertyDefinitions() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 169 |
| Method org.andromda.core.namespace.NamespaceRegistry.getRegisteredComponents() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 99 |
| Method org.andromda.core.namespace.NamespaceRegistry.getResourceRoots() uses Collection.toArray() with zero-length array argument | PERFORMANCE | ITA_INEFFICIENT_TO_ARRAY | 199 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.andromda.core.profile.Profile is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | Not available |
| Write to static field org.andromda.core.profile.Profile.instance from instance method org.andromda.core.profile.Profile.shutdown() | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 213 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.andromda.core.transformation.XslTransformer.transform(String, Transformation[]) may fail to close stream on exception | BAD_PRACTICE | OS_OPEN_STREAM_EXCEPTION_PATH | 88 |
| Exception is caught when Exception is not thrown in org.andromda.core.transformation.XslTransformer.transform(String, Transformation[]) | STYLE | REC_CATCH_EXCEPTION | 109 |
| Bug | Category | Details | Line |
|---|---|---|---|
| LibraryTranslation.library not initialized in constructor | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | Not available |
| Bug | Category | Details | Line |
|---|---|---|---|
| Read of unwritten field validatePatterns in org.andromda.core.translation.library.Translation.addValidatePattern(String) | CORRECTNESS | NP_UNWRITTEN_FIELD | 148 |
| Useless control flow in org.andromda.core.translation.library.Translation.getFragment(String) | STYLE | UCF_USELESS_CONTROL_FLOW | 83 |
| Unwritten field: org.andromda.core.translation.library.Translation.validatePatterns | CORRECTNESS | UWF_UNWRITTEN_FIELD | 148 |
