AndroMDApp Maven Plugin - FindBugs Bug Detector Report

FindBugs Bug Detector Report

The following document contains the results of FindBugs Report

FindBugs Version is 1.2.0

Threshold is Low

Effort is Default

Summary

Classes	Bugs	Errors	Missing Classes
219	94	0	0

Files

Class	Bugs
org.andromda.maven.plugin.andromdapp.AbstractAndroMDAppMojo	3
org.andromda.maven.plugin.andromdapp.BeanProperties	1
org.andromda.maven.plugin.andromdapp.BuildMojo	17
org.andromda.maven.plugin.andromdapp.DeployMojo	1
org.andromda.maven.plugin.andromdapp.EclipseMojo	11
org.andromda.maven.plugin.andromdapp.Location	1
org.andromda.maven.plugin.andromdapp.MavenExecuteMojo	14
org.andromda.maven.plugin.andromdapp.SchemaMojo	27
org.andromda.maven.plugin.andromdapp.ScriptClassGeneratorMojo	8
org.andromda.maven.plugin.andromdapp.SymbolicLinkExplodedEarMojo	4
org.andromda.maven.plugin.andromdapp.hibernate.HibernateSchemaManagement	3
org.andromda.maven.plugin.andromdapp.hibernate.HibernateUpdateSchema	2
org.andromda.maven.plugin.andromdapp.hibernate.HibernateValidateSchema	1
org.andromda.maven.plugin.andromdapp.utils.Projects	1

org.andromda.maven.plugin.andromdapp.AbstractAndroMDAppMojo

Bug	Category	Details	Line
Read of unwritten field project in org.andromda.maven.plugin.andromdapp.AbstractAndroMDAppMojo.getProperties()	CORRECTNESS	NP_UNWRITTEN_FIELD	76
Unwritten field: org.andromda.maven.plugin.andromdapp.AbstractAndroMDAppMojo.configurationUri	CORRECTNESS	UWF_UNWRITTEN_FIELD	126
Unwritten field: org.andromda.maven.plugin.andromdapp.AbstractAndroMDAppMojo.project	CORRECTNESS	UWF_UNWRITTEN_FIELD	76

org.andromda.maven.plugin.andromdapp.BeanProperties

Bug	Category	Details	Line
org.andromda.maven.plugin.andromdapp.BeanProperties is Serializable; consider declaring a serialVersionUID	BAD_PRACTICE	SE_NO_SERIALVERSIONID	Not available

org.andromda.maven.plugin.andromdapp.BuildMojo

Bug	Category	Details	Line
org.andromda.maven.plugin.andromdapp.BuildMojo.execute() forces garbage collection; extremely dubious except in benchmarking code	PERFORMANCE	DM_GC	210
Read of unwritten field session in org.andromda.maven.plugin.andromdapp.BuildMojo.execute()	CORRECTNESS	NP_UNWRITTEN_FIELD	245
Read of unwritten field baseDirectory in org.andromda.maven.plugin.andromdapp.BuildMojo.executeProjects(Collection, List)	CORRECTNESS	NP_UNWRITTEN_FIELD	470
Read of unwritten field lifecycleExecutor in org.andromda.maven.plugin.andromdapp.BuildMojo.executeProjects(Collection, List)	CORRECTNESS	NP_UNWRITTEN_FIELD	483
Read of unwritten field session in org.andromda.maven.plugin.andromdapp.BuildMojo.executeProjects(Collection, List)	CORRECTNESS	NP_UNWRITTEN_FIELD	470
Nullcheck of input at line 219 of value previously dereferenced in org.andromda.maven.plugin.andromdapp.BuildMojo.execute()	CORRECTNESS	RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE	160
Exception is caught when Exception is not thrown in org.andromda.maven.plugin.andromdapp.BuildMojo.getEnvironment()	STYLE	REC_CATCH_EXCEPTION	278
Unwritten field: org.andromda.maven.plugin.andromdapp.BuildMojo.baseDirectory	CORRECTNESS	UWF_UNWRITTEN_FIELD	470
Unwritten field: org.andromda.maven.plugin.andromdapp.BuildMojo.environmentVariablePrefix	CORRECTNESS	UWF_UNWRITTEN_FIELD	180
Unwritten field: org.andromda.maven.plugin.andromdapp.BuildMojo.lifecycleExecutor	CORRECTNESS	UWF_UNWRITTEN_FIELD	483
Unwritten field: org.andromda.maven.plugin.andromdapp.BuildMojo.modules	CORRECTNESS	UWF_UNWRITTEN_FIELD	246
Unwritten field: org.andromda.maven.plugin.andromdapp.BuildMojo.project	CORRECTNESS	UWF_UNWRITTEN_FIELD	219
Unwritten field: org.andromda.maven.plugin.andromdapp.BuildMojo.projectBuilder	CORRECTNESS	UWF_UNWRITTEN_FIELD	515
Unwritten field: org.andromda.maven.plugin.andromdapp.BuildMojo.session	CORRECTNESS	UWF_UNWRITTEN_FIELD	245
Unwritten field: org.andromda.maven.plugin.andromdapp.BuildMojo.startConsole	CORRECTNESS	UWF_UNWRITTEN_FIELD	148
Method org.andromda.maven.plugin.andromdapp.BuildMojo.collectProjects(String) makes inefficient use of keySet iterator instead of entrySet iterator	PERFORMANCE	WMI_WRONG_MAP_ITERATOR	526
Method org.andromda.maven.plugin.andromdapp.BuildMojo.executeModules(String, List, boolean) makes inefficient use of keySet iterator instead of entrySet iterator	PERFORMANCE	WMI_WRONG_MAP_ITERATOR	413

org.andromda.maven.plugin.andromdapp.DeployMojo

Bug	Category	Details	Line
Unwritten field: org.andromda.maven.plugin.andromdapp.DeployMojo.deploy	CORRECTNESS	UWF_UNWRITTEN_FIELD	64

org.andromda.maven.plugin.andromdapp.EclipseMojo

Bug	Category	Details	Line
Read of unwritten field project in org.andromda.maven.plugin.andromdapp.EclipseMojo.execute()	CORRECTNESS	NP_UNWRITTEN_FIELD	161
Read of unwritten field project in org.andromda.maven.plugin.andromdapp.EclipseMojo.getRootProject()	CORRECTNESS	NP_UNWRITTEN_FIELD	388
Read of unwritten field project in org.andromda.maven.plugin.andromdapp.EclipseMojo.getRootProject()	CORRECTNESS	NP_UNWRITTEN_FIELD	389
Unwritten field: org.andromda.maven.plugin.andromdapp.EclipseMojo.artifactFactory	CORRECTNESS	UWF_UNWRITTEN_FIELD	161
Unwritten field: org.andromda.maven.plugin.andromdapp.EclipseMojo.artifactMetadataSource	CORRECTNESS	UWF_UNWRITTEN_FIELD	161
Unwritten field: org.andromda.maven.plugin.andromdapp.EclipseMojo.artifactResolver	CORRECTNESS	UWF_UNWRITTEN_FIELD	161
Unwritten field: org.andromda.maven.plugin.andromdapp.EclipseMojo.classpathMerge	CORRECTNESS	UWF_UNWRITTEN_FIELD	161
Unwritten field: org.andromda.maven.plugin.andromdapp.EclipseMojo.excludePoms	CORRECTNESS	UWF_UNWRITTEN_FIELD	424
Unwritten field: org.andromda.maven.plugin.andromdapp.EclipseMojo.project	CORRECTNESS	UWF_UNWRITTEN_FIELD	161
Unwritten field: org.andromda.maven.plugin.andromdapp.EclipseMojo.projectBuilder	CORRECTNESS	UWF_UNWRITTEN_FIELD	224
Unwritten field: org.andromda.maven.plugin.andromdapp.EclipseMojo.session	CORRECTNESS	UWF_UNWRITTEN_FIELD	224

org.andromda.maven.plugin.andromdapp.Location

Bug	Category	Details	Line
Unwritten field: org.andromda.maven.plugin.andromdapp.Location.rootPath	CORRECTNESS	UWF_UNWRITTEN_FIELD	28

org.andromda.maven.plugin.andromdapp.MavenExecuteMojo

Bug	Category	Details	Line
Read of unwritten field baseDirectory in org.andromda.maven.plugin.andromdapp.MavenExecuteMojo.execute()	CORRECTNESS	NP_UNWRITTEN_FIELD	131
Read of unwritten field baseDirectory in org.andromda.maven.plugin.andromdapp.MavenExecuteMojo.execute()	CORRECTNESS	NP_UNWRITTEN_FIELD	166
Read of unwritten field lifecycleExecutor in org.andromda.maven.plugin.andromdapp.MavenExecuteMojo.execute()	CORRECTNESS	NP_UNWRITTEN_FIELD	144
Read of unwritten field lifecycleExecutor in org.andromda.maven.plugin.andromdapp.MavenExecuteMojo.execute()	CORRECTNESS	NP_UNWRITTEN_FIELD	180
Read of unwritten field project in org.andromda.maven.plugin.andromdapp.MavenExecuteMojo.execute()	CORRECTNESS	NP_UNWRITTEN_FIELD	97
Read of unwritten field session in org.andromda.maven.plugin.andromdapp.MavenExecuteMojo.execute()	CORRECTNESS	NP_UNWRITTEN_FIELD	106
Read of unwritten field session in org.andromda.maven.plugin.andromdapp.MavenExecuteMojo.execute()	CORRECTNESS	NP_UNWRITTEN_FIELD	131
Read of unwritten field session in org.andromda.maven.plugin.andromdapp.MavenExecuteMojo.execute()	CORRECTNESS	NP_UNWRITTEN_FIELD	151
Read of unwritten field session in org.andromda.maven.plugin.andromdapp.MavenExecuteMojo.execute()	CORRECTNESS	NP_UNWRITTEN_FIELD	166
Unwritten field: org.andromda.maven.plugin.andromdapp.MavenExecuteMojo.baseDirectory	CORRECTNESS	UWF_UNWRITTEN_FIELD	131
Unwritten field: org.andromda.maven.plugin.andromdapp.MavenExecuteMojo.lifecycleExecutor	CORRECTNESS	UWF_UNWRITTEN_FIELD	144
Unwritten field: org.andromda.maven.plugin.andromdapp.MavenExecuteMojo.project	CORRECTNESS	UWF_UNWRITTEN_FIELD	97
Unwritten field: org.andromda.maven.plugin.andromdapp.MavenExecuteMojo.projectBuilder	CORRECTNESS	UWF_UNWRITTEN_FIELD	217
Unwritten field: org.andromda.maven.plugin.andromdapp.MavenExecuteMojo.session	CORRECTNESS	UWF_UNWRITTEN_FIELD	106

org.andromda.maven.plugin.andromdapp.SchemaMojo

Bug	Category	Details	Line
Method org.andromda.maven.plugin.andromdapp.SchemaMojo.executeSql(Connection, String) invokes toString() method on a String	PERFORMANCE	DM_STRING_TOSTRING	534
Method org.andromda.maven.plugin.andromdapp.SchemaMojo.executeSql(Statement, String) invokes toString() method on a String	PERFORMANCE	DM_STRING_TOSTRING	566
org.andromda.maven.plugin.andromdapp.SchemaMojo.initializeClassLoaderWithJdbcDriver() creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block	BAD_PRACTICE	DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED	385
org.andromda.maven.plugin.andromdapp.SchemaMojo.initializeClasspathFromClassPathElements(Set) creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block	BAD_PRACTICE	DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED	369
Null pointer dereference of tasksMap in org.andromda.maven.plugin.andromdapp.SchemaMojo.execute()	CORRECTNESS	NP_ALWAYS_NULL	200
Load of known null value in org.andromda.maven.plugin.andromdapp.SchemaMojo.execute()	STYLE	NP_LOAD_OF_KNOWN_NULL_VALUE	200
Read of unwritten field project in org.andromda.maven.plugin.andromdapp.SchemaMojo.execute()	CORRECTNESS	NP_UNWRITTEN_FIELD	204
Read of unwritten field project in org.andromda.maven.plugin.andromdapp.SchemaMojo.execute()	CORRECTNESS	NP_UNWRITTEN_FIELD	241
Read of unwritten field artifactResolver in org.andromda.maven.plugin.andromdapp.SchemaMojo.getDependencyFile(Dependency)	CORRECTNESS	NP_UNWRITTEN_FIELD	442
Read of unwritten field factory in org.andromda.maven.plugin.andromdapp.SchemaMojo.getDependencyFile(Dependency)	CORRECTNESS	NP_UNWRITTEN_FIELD	434
Read of unwritten field project in org.andromda.maven.plugin.andromdapp.SchemaMojo.getDependencyFile(Dependency)	CORRECTNESS	NP_UNWRITTEN_FIELD	442
Read of unwritten field project in org.andromda.maven.plugin.andromdapp.SchemaMojo.getProvidedClasspathElements()	CORRECTNESS	NP_UNWRITTEN_FIELD	402
org.andromda.maven.plugin.andromdapp.SchemaMojo.executeSql(Connection, String) may fail to close stream on exception	BAD_PRACTICE	OS_OPEN_STREAM_EXCEPTION_PATH	500
Method org.andromda.maven.plugin.andromdapp.SchemaMojo.executeSql(Statement, String) passes a nonconstant String to an execute method on an SQL statement	BAD_PRACTICE	SQL_NONCONSTANT_STRING_PASSED_TO_EXECUTE	566
Unwritten field: org.andromda.maven.plugin.andromdapp.SchemaMojo.artifactResolver	CORRECTNESS	UWF_UNWRITTEN_FIELD	442
Unwritten field: org.andromda.maven.plugin.andromdapp.SchemaMojo.factory	CORRECTNESS	UWF_UNWRITTEN_FIELD	434
Unwritten field: org.andromda.maven.plugin.andromdapp.SchemaMojo.jdbcConnectionUrl	CORRECTNESS	UWF_UNWRITTEN_FIELD	463
Unwritten field: org.andromda.maven.plugin.andromdapp.SchemaMojo.jdbcDriver	CORRECTNESS	UWF_UNWRITTEN_FIELD	461
Unwritten field: org.andromda.maven.plugin.andromdapp.SchemaMojo.jdbcDriverJar	CORRECTNESS	UWF_UNWRITTEN_FIELD	385
Unwritten field: org.andromda.maven.plugin.andromdapp.SchemaMojo.jdbcUsername	CORRECTNESS	UWF_UNWRITTEN_FIELD	463
Unwritten field: org.andromda.maven.plugin.andromdapp.SchemaMojo.localRepository	CORRECTNESS	UWF_UNWRITTEN_FIELD	442
Unwritten field: org.andromda.maven.plugin.andromdapp.SchemaMojo.pluginArtifacts	CORRECTNESS	UWF_UNWRITTEN_FIELD	341
Unwritten field: org.andromda.maven.plugin.andromdapp.SchemaMojo.project	CORRECTNESS	UWF_UNWRITTEN_FIELD	204
Unwritten field: org.andromda.maven.plugin.andromdapp.SchemaMojo.propertyFiles	CORRECTNESS	UWF_UNWRITTEN_FIELD	208
Unwritten field: org.andromda.maven.plugin.andromdapp.SchemaMojo.scripts	CORRECTNESS	UWF_UNWRITTEN_FIELD	306
Unwritten field: org.andromda.maven.plugin.andromdapp.SchemaMojo.taskType	CORRECTNESS	UWF_UNWRITTEN_FIELD	197
Unwritten field: org.andromda.maven.plugin.andromdapp.SchemaMojo.tasks	CORRECTNESS	UWF_UNWRITTEN_FIELD	291

org.andromda.maven.plugin.andromdapp.ScriptClassGeneratorMojo

Bug	Category	Details	Line
org.andromda.maven.plugin.andromdapp.ScriptClassGeneratorMojo.initializeClassLoader(List) creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block	BAD_PRACTICE	DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED	203
Method org.andromda.maven.plugin.andromdapp.ScriptClassGeneratorMojo.initializeClassLoader(List) uses Collection.toArray() with zero-length array argument	PERFORMANCE	ITA_INEFFICIENT_TO_ARRAY	203
Read of unwritten field project in org.andromda.maven.plugin.andromdapp.ScriptClassGeneratorMojo.execute()	CORRECTNESS	NP_UNWRITTEN_FIELD	92
Read of unwritten field project in org.andromda.maven.plugin.andromdapp.ScriptClassGeneratorMojo.getProvidedClasspathElements()	CORRECTNESS	NP_UNWRITTEN_FIELD	134
Read of unwritten field project in org.andromda.maven.plugin.andromdapp.ScriptClassGeneratorMojo.initializeClassLoader(List)	CORRECTNESS	NP_UNWRITTEN_FIELD	190
Unwritten field: org.andromda.maven.plugin.andromdapp.ScriptClassGeneratorMojo.locations	CORRECTNESS	UWF_UNWRITTEN_FIELD	89
Unwritten field: org.andromda.maven.plugin.andromdapp.ScriptClassGeneratorMojo.project	CORRECTNESS	UWF_UNWRITTEN_FIELD	92
Unwritten field: org.andromda.maven.plugin.andromdapp.ScriptClassGeneratorMojo.scriptWrapper	CORRECTNESS	UWF_UNWRITTEN_FIELD	88

org.andromda.maven.plugin.andromdapp.SymbolicLinkExplodedEarMojo

Bug	Category	Details	Line
Read of unwritten field artifactFactory in org.andromda.maven.plugin.andromdapp.SymbolicLinkExplodedEarMojo.getExplodedModuleArtifacts()	CORRECTNESS	NP_UNWRITTEN_FIELD	317
Nullcheck of root at line 250 of value previously dereferenced in org.andromda.maven.plugin.andromdapp.SymbolicLinkExplodedEarMojo.getRootProject()	CORRECTNESS	RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE	246
Unwritten field: org.andromda.maven.plugin.andromdapp.SymbolicLinkExplodedEarMojo.artifactFactory	CORRECTNESS	UWF_UNWRITTEN_FIELD	317
Unwritten field: org.andromda.maven.plugin.andromdapp.SymbolicLinkExplodedEarMojo.deployLocation	CORRECTNESS	UWF_UNWRITTEN_FIELD	194

org.andromda.maven.plugin.andromdapp.hibernate.HibernateSchemaManagement

Bug	Category	Details	Line
org.andromda.maven.plugin.andromdapp.hibernate.HibernateSchemaManagement.getExecutionClass() might ignore java.lang.Exception	BAD_PRACTICE	DE_MIGHT_IGNORE	70
Method org.andromda.maven.plugin.andromdapp.hibernate.HibernateSchemaManagement.execute(Connection, Map) uses Collection.toArray() with zero-length array argument	PERFORMANCE	ITA_INEFFICIENT_TO_ARRAY	169
org.andromda.maven.plugin.andromdapp.hibernate.HibernateSchemaManagement.logger isn't final but should be	MALICIOUS_CODE	MS_SHOULD_BE_FINAL	28

org.andromda.maven.plugin.andromdapp.hibernate.HibernateUpdateSchema

Bug	Category	Details	Line
Random object created and used only once in org.andromda.maven.plugin.andromdapp.hibernate.HibernateUpdateSchema.addArguments(Map, List)	BAD_PRACTICE	DMI_RANDOM_USED_ONLY_ONCE	56
org.andromda.maven.plugin.andromdapp.hibernate.HibernateUpdateSchema.getJdbcDriverJarLoader(Map) creates a java.net.URLClassLoader classloader, which should be performed within a doPrivileged block	BAD_PRACTICE	DP_CREATE_CLASSLOADER_INSIDE_DO_PRIVILEGED	85

org.andromda.maven.plugin.andromdapp.hibernate.HibernateValidateSchema

Bug	Category	Details	Line
Random object created and used only once in org.andromda.maven.plugin.andromdapp.hibernate.HibernateValidateSchema.addArguments(Map, List)	BAD_PRACTICE	DMI_RANDOM_USED_ONLY_ONCE	61

org.andromda.maven.plugin.andromdapp.utils.Projects

Bug	Category	Details	Line
Write to static field org.andromda.maven.plugin.andromdapp.utils.Projects.instance from instance method org.andromda.maven.plugin.andromdapp.utils.Projects.clear()	STYLE	ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD	62

Overview

Project Documentation

FindBugs Bug Detector Report

Summary

Files

org.andromda.maven.plugin.andromdapp.AbstractAndroMDAppMojo

org.andromda.maven.plugin.andromdapp.BeanProperties

org.andromda.maven.plugin.andromdapp.BuildMojo

org.andromda.maven.plugin.andromdapp.DeployMojo

org.andromda.maven.plugin.andromdapp.EclipseMojo

org.andromda.maven.plugin.andromdapp.Location

org.andromda.maven.plugin.andromdapp.MavenExecuteMojo

org.andromda.maven.plugin.andromdapp.SchemaMojo

org.andromda.maven.plugin.andromdapp.ScriptClassGeneratorMojo

org.andromda.maven.plugin.andromdapp.SymbolicLinkExplodedEarMojo

org.andromda.maven.plugin.andromdapp.hibernate.HibernateSchemaManagement

org.andromda.maven.plugin.andromdapp.hibernate.HibernateUpdateSchema

org.andromda.maven.plugin.andromdapp.hibernate.HibernateValidateSchema

org.andromda.maven.plugin.andromdapp.utils.Projects