PMD Results

The following document contains the results of PMD 5.0.2.

Files

org/andromda/cartridges/bpm4struts/Bpm4StrutsGlobals.java

Violation Line
Avoid excessively long variable names like PROPERTY_DEFAULT_INPUT_COLUMN_COUNT 14
Avoid excessively long variable names like PROPERTY_DEFAULT_INPUT_ROW_COUNT 19
Avoid excessively long variable names like PROPERTY_DEFAULT_ACTION_REDIRECT 39
Avoid excessively long variable names like PROPERTY_GENERATE_TABLE_DECORATORS 49
Avoid excessively long variable names like PROPERTY_DEFAULT_TABLE_EXPORT_TYPES 59
Avoid excessively long variable names like DISABLE_VALIDATION_FOR_HIDDEN_FORM_FIELDS 84

org/andromda/cartridges/bpm4struts/Bpm4StrutsProfile.java

Violation Line
Avoid excessively long variable names like TAGGEDVALUE_ACTION_SUCCESS_MESSAGE 27
Avoid excessively long variable names like TAGGEDVALUE_ACTION_WARNING_MESSAGE 29
Avoid excessively long variable names like TAGGEDVALUE_INPUT_DEFAULT_REQUIRED 97
Avoid excessively long variable names like TAGGEDVALUE_EXCEPTION_DEFAULT_TYPE 99
Avoid excessively long variable names like TAGGEDVALUE_ACTION_FORM_DEFAULT_KEY 101
Avoid excessively long variable names like TAGGEDVALUE_ACTION_TYPE_HYPERLINK 103
Avoid excessively long variable names like TAGGEDVALUE_INPUT_TYPE_PLAINTEXT 115
Avoid excessively long variable names like TAGGEDVALUE_INPUT_TYPE_OPTION_DEFAULT_COUNT 135
Avoid excessively long variable names like TAGGEDVALUE_TABLE_MAXROWS_DEFAULT_COUNT 137
Avoid excessively long variable names like TAGGEDVALUE_TABLE_SORTABLE_DEFAULT_VALUE 139
Avoid excessively long variable names like TAGGEDVALUE_TABLE_EXPORTABLE_DEFAULT_VALUE 141

org/andromda/cartridges/bpm4struts/Bpm4StrutsUtils.java

Violation Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 22 - 285
Parameter 'enumeration' is not assigned and could be declared final 29
Avoid reassigning parameters such as 'validatorTaggedValue' 52
Local variable 'left' could be declared final 71
Avoid reassigning parameters such as 'validatorTaggedValue' 103
Local variable 'left' could be declared final 119
Local variable 'right' could be declared final 122
Parameter 'validatorTaggedValue' is not assigned and could be declared final 143
Parameter 'collection' is not assigned and could be declared final 166
Use bitwise inversion to invert boolean values 201
Parameter 'string' is not assigned and could be declared final 257
Parameter 'left' is not assigned and could be declared final 276
Parameter 'right' is not assigned and could be declared final 277

org/andromda/cartridges/bpm4struts/metafacades/StrutsActionLogicImpl.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 1 - 1129
Avoid really long classes. 42 - 1129
This class has too many methods, consider refactoring it. 44 - 1129
Avoid using redundant field initializer for 'actionStates' 50
Found non-transient, non-static member. Please mark as transient or provide accessors. 50
Avoid using redundant field initializer for 'actionForwards' 55
Found non-transient, non-static member. Please mark as transient or provide accessors. 55
Found non-transient, non-static member. Please mark as transient or provide accessors. 60
Avoid using redundant field initializer for 'decisionTransitions' 60
Avoid using redundant field initializer for 'transitions' 65
Found non-transient, non-static member. Please mark as transient or provide accessors. 65
Parameter 'metaObject' is not assigned and could be declared final 71
Parameter 'context' is not assigned and could be declared final 72
Parameter 'transition' is not assigned and could be declared final 96
Parameter 'processedTransitions' is not assigned and could be declared final 97
Useless parentheses. 106
Useless parentheses. 106
Useless parentheses. 113
Useless parentheses. 153
Local variable 'field' could be declared final 163
Local variable 'table' could be declared final 242
Avoid excessively long variable names like tableNonColumnActionParametersMap 265
Local variable 'formSize' could be declared final 268
Local variable 'size' could be declared final 272
Prefer StringBuffer over += for concatenating strings 304
Useless parentheses. 326
Assigning an Object to null is a code smell. Consider refactoring. 327
Local variable 'value' could be declared final 557
Parameter 'string' is not assigned and could be declared final 564
Local variable 'source' could be declared final 577
Useless parentheses. 621
A method should have only one exit point, and that should be the last statement in the method 633
A method should have only one exit point, and that should be the last statement in the method 648
A method should have only one exit point, and that should be the last statement in the method 663
Avoid using if statements without curly braces 734
Avoid using if statements without curly braces 743
Avoid using if statements without curly braces 752
Local variable 'actionState' could be declared final 765
The method handleGetActionFormFields() has an NPath complexity of 432 818 - 901
Local variable 'size' could be declared final 915
Local variable 'forward' could be declared final 922
Line too long 944
Parameter 'finalState' is not assigned and could be declared final 946
Local variable 'parameter' could be declared final 964
Local variable 'targetPages' could be declared final 982
Local variable 'trigger' could be declared final 1016
Local variable 'triggerName' could be declared final 1019
Local variable 'value' could be declared final 1032
Parameter 'object' is not assigned and could be declared final 1049
Local variable 'value' could be declared final 1079

org/andromda/cartridges/bpm4struts/metafacades/StrutsActionStateLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 30
Parameter 'context' is not assigned and could be declared final 31
Deeply nested if..then statements are hard to read 57 - 60

org/andromda/cartridges/bpm4struts/metafacades/StrutsActivityGraphLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 22
Parameter 'context' is not assigned and could be declared final 23
Assigning an Object to null is a code smell. Consider refactoring. 39
Useless parentheses. 39

org/andromda/cartridges/bpm4struts/metafacades/StrutsAttributeLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 21
Parameter 'context' is not assigned and could be declared final 22
Parameter 'seed' is not assigned and could be declared final 54

org/andromda/cartridges/bpm4struts/metafacades/StrutsBackendServiceLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 19
Parameter 'context' is not assigned and could be declared final 20
Local variable 'accessorImplementation' could be declared final 31 - 32
Local variable 'packageName' could be declared final 41 - 42

org/andromda/cartridges/bpm4struts/metafacades/StrutsControllerLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 28
Parameter 'context' is not assigned and could be declared final 29

org/andromda/cartridges/bpm4struts/metafacades/StrutsControllerOperationLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 39
Parameter 'context' is not assigned and could be declared final 40
Unnecessary use of fully qualified name 'java.util.List' due to existing import 'java.util.List' 82
Deeply nested if..then statements are hard to read 101 - 104
Deeply nested if..then statements are hard to read 118 - 138
Assigning an Object to null is a code smell. Consider refactoring. 151
Useless parentheses. 151
These nested if statements could be combined 202 - 205
Deeply nested if..then statements are hard to read 202 - 205
Avoid if (x != y) ..; else ..; 241
Avoid if (x != y) ..; else ..; 256
Use bitwise inversion to invert boolean values 262
Use bitwise inversion to invert boolean values 264
Line too long 270
Useless parentheses. 294

org/andromda/cartridges/bpm4struts/metafacades/StrutsExceptionHandlerLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 22
Parameter 'context' is not assigned and could be declared final 23
Useless parentheses. 46
A method should have only one exit point, and that should be the last statement in the method 73
Avoid using if...else statements without curly braces 73
Avoid using if...else statements without curly braces 75
A method should have only one exit point, and that should be the last statement in the method 75
Avoid using if...else statements without curly braces 77
Avoid if (x != y) ..; else ..; 86

org/andromda/cartridges/bpm4struts/metafacades/StrutsFinalStateLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 31
Parameter 'context' is not assigned and could be declared final 32
Local variable 'name' could be declared final 70
Useless parentheses. 71
Local variable 'useCase' could be declared final 118
Line too long 143
Local variable 'actions' could be declared final 147
Local variable 'incomings' could be declared final 148
Local variable 'forward' could be declared final 152

org/andromda/cartridges/bpm4struts/metafacades/StrutsForwardLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 34
Parameter 'context' is not assigned and could be declared final 35
Assigning an Object to null is a code smell. Consider refactoring. 46
A method should have only one exit point, and that should be the last statement in the method 100
A method should have only one exit point, and that should be the last statement in the method 104
Avoid using if statements without curly braces 119
Avoid using if statements without curly braces 121
Avoid using if statements without curly braces 123
Avoid using if statements without curly braces 125
Parameter 'taggedValue' is not assigned and could be declared final 161

org/andromda/cartridges/bpm4struts/metafacades/StrutsJspLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 34
Parameter 'context' is not assigned and could be declared final 35
Avoid if (x != y) ..; else ..; 129 - 130
Useless parentheses. 129
Avoid if (x != y) ..; else ..; 149 - 150
Useless parentheses. 190
A method should have only one exit point, and that should be the last statement in the method 205
A method should have only one exit point, and that should be the last statement in the method 222
A method should have only one exit point, and that should be the last statement in the method 239
Parameter 'stateVertex' is not assigned and could be declared final 323
Parameter 'processedTransitions' is not assigned and could be declared final 324
Parameter 'actions' is not assigned and could be declared final 325
Parameter 'transition' is not assigned and could be declared final 341
Parameter 'processedTransitions' is not assigned and could be declared final 342
Parameter 'actions' is not assigned and could be declared final 343
Line too long 352
Unnecessary wrapper object creation 407

org/andromda/cartridges/bpm4struts/metafacades/StrutsManageableEntityAssociationEndLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 22
Parameter 'context' is not assigned and could be declared final 23
Line too long 78
Avoid if (x != y) ..; else ..; 82 - 83
Useless parentheses. 82

org/andromda/cartridges/bpm4struts/metafacades/StrutsManageableEntityAttributeLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 23
Parameter 'context' is not assigned and could be declared final 24
Prefer StringBuffer over += for concatenating strings 40
Useless parentheses. 105
Avoid empty catch blocks 152 - 155
Avoid empty catch blocks 180 - 183
Useless parentheses. 210
Avoid if (x != y) ..; else ..; 210 - 211

org/andromda/cartridges/bpm4struts/metafacades/StrutsManageableEntityLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 36
Parameter 'context' is not assigned and could be declared final 37
Useless parentheses. 243
Avoid if (x != y) ..; else ..; 243 - 244
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 304

org/andromda/cartridges/bpm4struts/metafacades/StrutsParameterLogicImpl.java

Violation Line
Avoid really long classes. 33 - 2082
The class 'StrutsParameterLogicImpl' has a Cyclomatic Complexity of 3 (Highest = 29). 33 - 2082
This class has too many methods, consider refactoring it. 35 - 2082
Parameter 'metaObject' is not assigned and could be declared final 41
Parameter 'context' is not assigned and could be declared final 42
Local variable 'actions' could be declared final 134
Local variable 'action' could be declared final 137
Local variable 'actionFormFields' could be declared final 138
Local variable 'parameter' could be declared final 141
Useless parentheses. 193
Useless parentheses. 267
Local variable 'documentation' could be declared final 272
Avoid if (x != y) ..; else ..; 273 - 275
Useless parentheses. 291
Avoid if (x != y) ..; else ..; 291 - 292
Avoid really long methods. 306 - 488
The method 'handleGetOnlineHelpValue' has a Cyclomatic Complexity of 24. 306 - 488
The method handleGetOnlineHelpValue() has an NPath complexity of 768000 306 - 488
Avoid if (x != y) ..; else ..; 312 - 313
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 322
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 329
The String literal "The value of this field should reflect a " appears 10 times in this file; the first occurrence is on line 329 329
Local variable 'dateFormat' could be declared final 336
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. 337
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 344
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 349
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 353
Local variable 'dateFormat' could be declared final 360
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. 362
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. 392
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. 412
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. 425
The String literal "<a href=\"http://java.sun.com/docs/books/tutorial/java/nutsandbolts/datatypes.html\" " appears 8 times in this file; the first occurrence is on line 426 426
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. 432
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. 439
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. 446
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. 453
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. 460
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. 467
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. 474
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. 481
Useless parentheses. 506
Avoid if (x != y) ..; else ..; 545 - 555
Unnecessary wrapper object creation 548
Unnecessary wrapper object creation 554
Line too long 572
Useless parentheses. 639
This statement may have some unnecessary parentheses 639
Parameter 'hyperlink' is not assigned and could be declared final 662
Parameter 'formPost' is not assigned and could be declared final 663
Parameter 'tableAction' is not assigned and could be declared final 664
A method should have only one exit point, and that should be the last statement in the method 669
These nested if statements could be combined 694 - 699
Useless parentheses. 694
Useless parentheses. 695
Useless parentheses. 696
Prefer StringBuffer over += for concatenating strings 715
Assigning an Object to null is a code smell. Consider refactoring. 725
Local variable 'suffix' could be declared final 738
Useless parentheses. 882
Parameter 'columnName' is not assigned and could be declared final 933
Assigning an Object to null is a code smell. Consider refactoring. 954
Parameter 'columnName' is not assigned and could be declared final 960
Useless parentheses. 962
Assigning an Object to null is a code smell. Consider refactoring. 962
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 977
The method 'handleGetWidgetType' has a Cyclomatic Complexity of 22. 988 - 1065
Local variable 'value' could be declared final 990
These nested if statements could be combined 1053 - 1056
Useless parentheses. 1061
Use explicit scoping instead of the default package private level 1070
Local variable 'type' could be declared final 1079
Local variable 'type' could be declared final 1094
The method 'handleGetResetValue' has a Cyclomatic Complexity of 24. 1303 - 1343
The method handleGetResetValue() has an NPath complexity of 16385 1303 - 1343
A method should have only one exit point, and that should be the last statement in the method 1310
A method should have only one exit point, and that should be the last statement in the method 1311
A method should have only one exit point, and that should be the last statement in the method 1315
A method should have only one exit point, and that should be the last statement in the method 1316
A method should have only one exit point, and that should be the last statement in the method 1317
A method should have only one exit point, and that should be the last statement in the method 1318
A method should have only one exit point, and that should be the last statement in the method 1319
A method should have only one exit point, and that should be the last statement in the method 1320
A method should have only one exit point, and that should be the last statement in the method 1321
A method should have only one exit point, and that should be the last statement in the method 1322
A method should have only one exit point, and that should be the last statement in the method 1326
A method should have only one exit point, and that should be the last statement in the method 1327
A method should have only one exit point, and that should be the last statement in the method 1328
A method should have only one exit point, and that should be the last statement in the method 1329
A method should have only one exit point, and that should be the last statement in the method 1330
A method should have only one exit point, and that should be the last statement in the method 1331
A method should have only one exit point, and that should be the last statement in the method 1332
A method should have only one exit point, and that should be the last statement in the method 1333
A method should have only one exit point, and that should be the last statement in the method 1336
A method should have only one exit point, and that should be the last statement in the method 1337
A method should have only one exit point, and that should be the last statement in the method 1338
Avoid excessively long variable names like disableValidationForHiddenFormFields 1351
Local variable 'value' could be declared final 1358
Assigning an Object to null is a code smell. Consider refactoring. 1360
The method 'handleGetValidatorTypes' has a Cyclomatic Complexity of 29. 1366 - 1427
The method handleGetValidatorTypes() has an NPath complexity of 13602 1366 - 1427
Local variable 'type' could be declared final 1370
Useless parentheses. 1374
Local variable 'formats' could be declared final 1401
Local variable 'additionalFormat' could be declared final 1404
The String literal "minlength" appears 5 times in this file; the first occurrence is on line 1,405 1405
The String literal "maxlength" appears 5 times in this file; the first occurrence is on line 1,406 1406
Local variable 'taggedValues' could be declared final 1419
Local variable 'validator' could be declared final 1422
Parameter 'validatorType' is not assigned and could be declared final 1443
Local variable 'taggedValues' could be declared final 1479
Local variable 'validator' could be declared final 1482
The method handleGetValidatorVars() has an NPath complexity of 339 1496 - 1573
Avoid using if...else statements without curly braces 1519 - 1520
Avoid using if...else statements without curly braces 1521 - 1522
Avoid using if statements without curly braces 1523 - 1524
Local variable 'taggedValues' could be declared final 1554
Local variable 'validator' could be declared final 1557
Local variable 'validatorVars' could be declared final 1560
Local variable 'validatorArgs' could be declared final 1561
Local variable 'validatorVar' could be declared final 1565
Local variable 'validatorArg' could be declared final 1566
Local variable 'value' could be declared final 1591
Assigning an Object to null is a code smell. Consider refactoring. 1592
Avoid using for statements without curly braces 1604 - 1605
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1638
Local variable 'value' could be declared final 1668
Unnecessary wrapper object creation 1671
Parameter 'format' is not assigned and could be declared final 1856
Parameter 'format' is not assigned and could be declared final 1864
Parameter 'format' is not assigned and could be declared final 1872
Parameter 'format' is not assigned and could be declared final 1886
Parameter 'format' is not assigned and could be declared final 1894
Line too long 1900
Parameter 'format' is not assigned and could be declared final 1902
Line too long 1908
Parameter 'format' is not assigned and could be declared final 1910
Parameter 'format' is not assigned and could be declared final 1918
Parameter 'format' is not assigned and could be declared final 1926
Parameter 'format' is not assigned and could be declared final 1934
Useless parentheses. 1936
Parameter 'format' is not assigned and could be declared final 1942
Parameter 'format' is not assigned and could be declared final 1950
Parameter 'format' is not assigned and could be declared final 1958
Parameter 'string' is not assigned and could be declared final 1966
Parameter 'index' is not assigned and could be declared final 1967
Parameter 'limit' is not assigned and could be declared final 1968
A method should have only one exit point, and that should be the last statement in the method 1970
Useless parentheses. 1973
Assigning an Object to null is a code smell. Consider refactoring. 1973
Useless parentheses. 1981
Use bitwise inversion to invert boolean values 1995 - 1999
Unnecessary wrapper object creation 2008
Avoid empty catch blocks 2038 - 2041
Avoid empty catch blocks 2066 - 2069

org/andromda/cartridges/bpm4struts/metafacades/StrutsPseudostateLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 26
Parameter 'context' is not assigned and could be declared final 27
Deeply nested if..then statements are hard to read 72 - 75

org/andromda/cartridges/bpm4struts/metafacades/StrutsSessionObjectLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 17
Parameter 'context' is not assigned and could be declared final 18

org/andromda/cartridges/bpm4struts/metafacades/StrutsTriggerLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 21
Parameter 'context' is not assigned and could be declared final 22
Deeply nested if..then statements are hard to read 85 - 88
Prefer StringBuffer over += for concatenating strings 87
Local variable 'transition' could be declared final 158
Unnecessary wrapper object creation 169

org/andromda/cartridges/bpm4struts/metafacades/StrutsUseCaseLogicImpl.java

Violation Line
The class 'StrutsUseCaseLogicImpl' has a Cyclomatic Complexity of 3 (Highest = 25). 33 - 685
Parameter 'metaObject' is not assigned and could be declared final 42
Parameter 'context' is not assigned and could be declared final 43
Avoid if (x != y) ..; else ..; 80 - 81
Avoid using if statements without curly braces 198 - 199
A method should have only one exit point, and that should be the last statement in the method 234
A method should have only one exit point, and that should be the last statement in the method 249
Avoid using if statements without curly braces 273
Parameter 'root' is not assigned and could be declared final 337
Avoid instantiating new objects inside loops 351
Avoid reassigning parameters such as 'node' 368
Parameter 'ancestorNode' is not assigned and could be declared final 369
Parameter 'root' is not assigned and could be declared final 392
Parameter 'useCase' is not assigned and could be declared final 393
Local variable 'node' could be declared final 400
Parameter 'useCase' is not assigned and could be declared final 423
Unnecessary wrapper object creation 440
The method handleGetAllMessages() has an NPath complexity of 19855 446 - 634
The method 'handleGetAllMessages' has a Cyclomatic Complexity of 25. 446 - 634
Avoid really long methods. 446 - 634
Useless parentheses. 449
Local variable 'forward' could be declared final 467
Useless parentheses. 606