The following document contains the results of PMD 5.0.2.
Violation | Line |
---|---|
Avoid excessively long variable names like IMPLEMENTATION_OPERATION_NAME_PATTERN | 47 |
Avoid excessively long variable names like TRANSACTION_MANAGEMENT_CONTAINER | 221 |
Avoid excessively long variable names like NO_TRANSFORMATION_CONSTANT_SUFFIX | 258 |
Avoid excessively long variable names like TRANSFORMATION_TO_COLLECTION_METHOD_SUFFIX | 268 |
Avoid excessively long variable names like SEAM_COMPONENT_SCOPE_CONVERSATION | 278 |
Violation | Line |
---|---|
Avoid really long classes. | 11 - 1373 |
Variables that are final and static should be all capitals, 'profile' is not all capitals. | 17 |
Avoid excessively long variable names like STEREOTYPE_SERVICE_TIMER_TIMEOUT | 126 |
Avoid excessively long variable names like STEREOTYPE_FINDER_RESULT_TYPE_FIRST | 133 |
Avoid excessively long variable names like STEREOTYPE_FINDER_RESULT_TYPE_MAX | 140 |
Avoid excessively long variable names like STEREOTYPE_SEAM_COMPONENT_STARTUP | 220 |
Avoid excessively long variable names like STEREOTYPE_SEAM_BIJECTION_UNWRAP | 239 |
Avoid excessively long variable names like STEREOTYPE_SEAM_BIJECTION_FACTORY | 260 |
Avoid excessively long variable names like STEREOTYPE_SEAM_BIJECTION_LOGGER | 267 |
Avoid excessively long variable names like STEREOTYPE_SEAM_BIJECTION_REQUEST_PARAMETER | 275 |
Avoid excessively long variable names like STEREOTYPE_SEAM_LIFECYCLE_CREATE | 283 |
Avoid excessively long variable names like STEREOTYPE_SEAM_LIFECYCLE_DESTROY | 293 |
Avoid excessively long variable names like STEREOTYPE_SEAM_CONVERSATION_BEGIN | 300 |
Avoid excessively long variable names like STEREOTYPE_SEAM_CONVERSATION_END | 307 |
Avoid excessively long variable names like STEREOTYPE_SEAM_CONVERSATION_BEGIN_TASK | 314 |
Avoid excessively long variable names like STEREOTYPE_SEAM_CONVERSATION_START_TASK | 331 |
Avoid excessively long variable names like STEREOTYPE_SEAM_CONVERSATION_END_TASK | 342 |
Avoid excessively long variable names like STEREOTYPE_SEAM_CONVERSATION_CREATE_PROCESS | 350 |
Avoid excessively long variable names like STEREOTYPE_SEAM_CONVERSATION_RESUME_PROCESS | 359 |
Avoid excessively long variable names like STEREOTYPE_SEAM_TRANSACTION_TRANSACTIONAL | 370 |
Avoid excessively long variable names like STEREOTYPE_SEAM_TRANSACTION_ROLLBACK | 378 |
Avoid excessively long variable names like STEREOTYPE_SEAM_VALIDATION_VALID | 386 |
Avoid excessively long variable names like STEREOTYPE_SEAM_VALIDATION_VALIDATOR | 395 |
Avoid excessively long variable names like STEREOTYPE_SEAM_ASYNCHRONOUS_DURATION | 427 |
Avoid excessively long variable names like STEREOTYPE_SEAM_ASYNCHRONOUS_EXPIRATION | 435 |
Avoid excessively long variable names like STEREOTYPE_SEAM_ASYNCHRONOUS_INTERVAL_DURATION | 442 |
Avoid excessively long variable names like STEREOTYPE_SEAM_DATA_DATAMODEL_SELECTION | 458 |
Avoid excessively long variable names like STEREOTYPE_SEAM_DATA_DATAMODEL_SELECTION_INDEX | 466 |
Avoid excessively long variable names like TAGGEDVALUE_EJB_TRANSACTION_TYPE | 492 |
Avoid excessively long variable names like TAGGEDVALUE_EJB_TRANSACTION_MANAGEMENT | 500 |
Avoid excessively long variable names like TAGGEDVALUE_EJB_NO_SYNTHETIC_CREATE_METHOD | 507 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_TEMPORAL_TYPE | 514 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_OVERRIDE_TYPE | 521 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_ENTITY_TABLE_NAME | 527 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_FETCH_TYPE | 533 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_CASCADE_TYPE | 539 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_ENUMERATION_TYPE | 545 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_GENERATOR_TYPE | 551 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_GENERATOR_NAME | 557 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_GENERATOR_GENERIC_STRATEGY | 563 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_GENERATOR_SOURCE_NAME | 569 |
Line too long | 573 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_GENERATOR_PKCOLUMN_VALUE | 575 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_GENERATOR_INITIAL_VALUE | 581 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_GENERATOR_ALLOCATION_SIZE | 587 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_COLUMN_DEFINITION | 593 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_COLUMN_PRECISION | 599 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_COLUMN_SCALE | 605 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_COLUMN_NULLABLE | 611 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_COLUMN_INSERT | 618 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_COLUMN_UPDATE | 625 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_OPTIONAL | 640 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_INHERITANCE | 650 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_DISCRIMINATOR_TYPE | 660 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_DISCRIMINATOR_VALUE | 667 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_DISCRIMINATOR_COLUMN | 675 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_DISCRIMINATOR_COLUMN_DEFINITION | 683 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_DISCRIMINATOR_COLUMN_LENGTH | 691 |
Avoid excessively long variable names like TAGGEDVALUE_EJB_PERSISTENCE_CONTEXT_UNIT_NAME | 699 |
Avoid excessively long variable names like TAGGEDVALUE_EJB_PERSISTENCE_CONTEXT_TYPE | 707 |
Avoid excessively long variable names like TAGGEDVALUE_EJB_PERSISTENCE_CONTEXT_DATASOURCE | 715 |
Avoid excessively long variable names like TAGGEDVALUE_EJB_PERSISTENCE_FLUSH_MODE | 722 |
Avoid excessively long variable names like TAGGEDVALUE_EJB_PERSISTENCE_LOB_TYPE | 729 |
Avoid excessively long variable names like TAGGEDVALUE_EJB_SECURITY_PERMIT_ALL | 744 |
Avoid excessively long variable names like TAGGEDVALUE_EJB_SECURITY_DENY_ALL | 752 |
Avoid excessively long variable names like TAGGEDVALUE_EJB_MDB_ACKNOWLEDGE_MODE | 768 |
Avoid excessively long variable names like TAGGEDVALUE_EJB_MDB_DESTINATION_TYPE | 784 |
Avoid excessively long variable names like TAGGEDVALUE_EJB_SESSION_JNDI_NAME_REMOTE | 808 |
Variables that are final and static should be all capitals, 'TAGGEDVALUE_EJB_SESSION_JNDI_NAME_Local' is not all capitals. | 816 |
Avoid excessively long variable names like TAGGEDVALUE_EJB_SESSION_JNDI_NAME_Local | 816 |
Avoid excessively long variable names like TAGGEDVALUE_EJB_MDB_MINIMUM_POOL_SIZE | 823 |
Avoid excessively long variable names like TAGGEDVALUE_EJB_MDB_MAXIMUM_POOL_SIZE | 830 |
Avoid excessively long variable names like TAGGEDVALUE_ASSOCIATION_COLLECTION_TYPE | 837 |
Avoid excessively long variable names like TAGGEDVALUE_ASSOCIATION_INDEX_TYPE | 844 |
Avoid excessively long variable names like TAGGEDVALUE_SERVICE_INTERCEPTOR_EXCLUDE_DEFAULT | 858 |
Avoid excessively long variable names like TAGGEDVALUE_SERVICE_INTERCEPTOR_EXCLUDE_CLASS | 865 |
Avoid excessively long variable names like TAGGEDVALUE_HIBERNATE_ENTITY_CACHE | 879 |
Avoid excessively long variable names like TAGGEDVALUE_HIBERNATE_ASSOCIATION_CACHE | 886 |
Avoid excessively long variable names like TAGGEDVALUE_PERSISTENCE_ASSOCIATION_END_PRIMARY | 893 |
Avoid excessively long variable names like TAGGEDVALUE_WEBSERVICE_PARAMETER_STYLE | 914 |
Avoid excessively long variable names like TAGGEDVALUE_WEBSERVICE_OPERATION_ONEWAY | 921 |
Avoid excessively long variable names like TAGGEDVALUE_WEBSERVICE_OPERATION_NAME | 928 |
Avoid excessively long variable names like TAGGEDVALUE_WEBSERVICE_OPERATION_RESULT_NAME | 935 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_COMPONENT_ROLE_NAME | 960 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_COMPONENT_ROLE_SCOPE_TYPE | 970 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_COMPONENT_INTERCEPT | 980 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_COMPONENT_JNDI_NAME | 989 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_COMPONENT_CONVERSIONAL_IFNOTBEGUNOUTCOME | 999 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_COMPONENT_STARTUP_DEPENDS | 1006 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_COMPONENT_SYNCHRONIZED_TIMEOUT | 1016 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_COMPONENT_READONLY | 1024 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_BIJECTION_IN_CREATE | 1033 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_BIJECTION_IN_VALUE | 1042 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_BIJECTION_OUT_VALUE | 1050 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_BIJECTION_OUT_SCOPE_TYPE | 1063 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_BIJECTION_FACTORY_VALUE | 1071 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_BIJECTION_FACTORY_SCOPE_TYPE | 1079 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_BIJECTION_LOGGER_VALUE | 1087 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_BIJECTION_REQUEST_PARAMETER_VALUE | 1095 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_LIFECYCLE_OBSERVER_EVENT | 1103 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_CONVERSATION_BEGIN_IF_OUTCOME | 1113 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_CONVERSATION_BEGIN_JOIN | 1121 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_CONVERSATION_BEGIN_NESTED | 1133 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_CONVERSATION_BEGIN_FLUSH_MODE | 1144 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_CONVERSATION_BEGIN_PAGEFLOW | 1152 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_CONVERSATION_END_IF_OUTCOME | 1160 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_CONVERSATION_END_BEFORE_REDIRECT | 1171 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_CONVERSATION_END_EVEN_IF_EXCEPTION | 1179 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_CONVERSATION_START_TASK_ID_PARAMETER | 1188 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_CONVERSATION_START_TASK_FLUSH_MODE | 1196 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_CONVERSATION_BEGIN_TASK_ID_PARAMETER | 1205 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_CONVERSATION_BEGIN_TASK_FLUSH_MODE | 1213 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_CONVERSATION_END_TASK_TRANSITION_NAME | 1220 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_CONVERSATION_END_TASK_IF_OUTCOME | 1228 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_CONVERSATION_END_TASK_BEFORE_REDIRECT | 1239 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_CONVERSATION_CREATE_PROCESS_DEFINITION | 1247 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_CONVERSATION_RESUME_PROCESS_PROCESS_ID_PARAMETER | 1255 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_TRANSACTION_ROLLBACK_IF_OUTCOME | 1263 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_VALIDATION_OUTCOME | 1270 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_VALIDATION_REFRESH_ENTITIES | 1278 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_WEBREMOTE_EXCLUDE | 1286 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_INTERCEPTOR_STATELESS | 1294 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_INTERCEPTOR_TYPE | 1302 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_INTERCEPTOR_AROUND | 1310 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_INTERCEPTOR_WITHIN | 1318 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_DATA_DATAMODEL_VALUE | 1325 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_DATA_DATAMODEL_SCOPE_TYPE | 1333 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_DATA_DATAMODEL_SELECTION_VALUE | 1341 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_DATA_DATAMODEL_SELECTION_INDEX_VALUE | 1349 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_DATA_DATABINDER_CLASS | 1360 |
Avoid excessively long variable names like TAGGEDVALUE_SEAM_DATA_DATASELECTOR_CLASS | 1371 |
Violation | Line |
---|---|
Avoid variables with short names like st | 31 |
Local variable 'st' could be declared final | 31 |
Local variable 'retval' could be declared final | 32 |
Local variable 'elem' could be declared final | 53 |
Local variable 'attr' could be declared final | 77 |
Useless parentheses. | 79 |
Useless parentheses. | 80 - 81 |
System.out.print is used | 85 |
Local variable 'attr' could be declared final | 111 |
Useless parentheses. | 116 - 118 |
Local variable 'attr' could be declared final | 148 |
Useless parentheses. | 150 - 151 |
System.out.print is used | 159 |
Local variable 'assoc' could be declared final | 182 |
System.out.print is used | 192 |
Local variable 'sb' could be declared final | 237 |
Avoid variables with short names like sb | 237 |
Local variable 'interceptor' could be declared final | 246 |
Violation | Line |
---|---|
The class 'EJB3AssociationEndFacadeLogicImpl' has a Cyclomatic Complexity of 4 (Highest = 22). | 33 - 1157 |
Avoid really long classes. | 33 - 1157 |
Avoid excessively long variable names like ENTITY_DEFAULT_COMPOSITE_CASCADE | 40 |
Avoid excessively long variable names like ENTITY_DEFAULT_AGGREGATION_CASCADE | 45 |
Variables that are final and static should be all capitals, 'cascadeTable' is not all capitals. | 115 |
Variables that are final and static should be all capitals, 'collectionTypes' is not all capitals. | 149 |
Avoid excessively long variable names like COMPOSITION_DEFINES_EAGER_LOADING | 163 |
Avoid excessively long variable names like HIBERNATE_ASSOCIATION_ENABLE_CACHE | 168 |
Unnecessary wrapper object creation | 213 |
Avoid if (x != y) ..; else ..; | 217 - 246 |
These nested if statements could be combined | 270 - 275 |
Prefer StringBuffer over += for concatenating strings | 272 |
Local variable 'type' could be declared final | 290 |
Useless parentheses. | 292 |
Local variable 'entity' could be declared final | 294 |
Unnecessary wrapper object creation | 322 |
These nested if statements could be combined | 364 - 367 |
These nested if statements could be combined | 381 - 384 |
Line too long | 426 |
Line too long | 440 |
Local variable 'optionalString' could be declared final | 451 |
Use bitwise inversion to invert boolean values | 455 |
Unnecessary wrapper object creation | 459 |
Avoid reassigning parameters such as 'name' | 491 |
Local variable 'taggedValue' could be declared final | 500 |
Local variable 'tagName' could be declared final | 504 |
Avoid variables with short names like ct | 527 |
Local variable 'ct' could be declared final | 527 |
Avoid instantiating new objects inside loops | 535 |
The method 'handleGetCascadeType' has a Cyclomatic Complexity of 22. | 553 - 640 |
Avoid if (x != y) ..; else ..; | 557 - 638 |
Local variable 'value' could be declared final | 560 |
Avoid instantiating new objects inside loops | 564 |
Useless parentheses. | 580 |
Local variable 'entity' could be declared final | 590 |
Useless parentheses. | 591 - 592 |
Assigning an Object to null is a code smell. Consider refactoring. | 592 |
Useless parentheses. | 597 - 598 |
Assigning an Object to null is a code smell. Consider refactoring. | 598 |
Local variable 'entity' could be declared final | 607 |
Useless parentheses. | 608 - 609 |
Assigning an Object to null is a code smell. Consider refactoring. | 609 |
Useless parentheses. | 614 - 615 |
Assigning an Object to null is a code smell. Consider refactoring. | 615 |
Avoid empty if statements | 620 - 628 |
Avoid empty if statements | 630 - 638 |
Avoid excessively long variable names like collectionTypeImplementationClass | 690 |
Local variable 'implementation' could be declared final | 727 |
Unnecessary wrapper object creation | 734 |
Avoid appending characters as strings in StringBuffer.append. | 737 |
Avoid appending characters as strings in StringBuffer.append. | 744 |
Avoid appending characters as strings in StringBuffer.append. | 746 |
Avoid appending characters as strings in StringBuffer.append. | 751 |
The method handleGetCollectionIndexType() has an NPath complexity of 775 | 772 - 829 |
Local variable 'name' could be declared final | 777 |
Local variable 'facade' could be declared final | 780 |
Local variable 'identifier' could be declared final | 784 |
A method should have only one exit point, and that should be the last statement in the method | 788 |
A method should have only one exit point, and that should be the last statement in the method | 793 |
Local variable 'attributes' could be declared final | 798 |
Local variable 'attrib' could be declared final | 799 |
Local variable 'attribute' could be declared final | 801 |
A method should have only one exit point, and that should be the last statement in the method | 805 |
Assigning an Object to null is a code smell. Consider refactoring. | 813 |
Assigning an Object to null is a code smell. Consider refactoring. | 828 |
Avoid if (x != y) ..; else ..; | 828 |
Useless parentheses. | 838 |
Assigning an Object to null is a code smell. Consider refactoring. | 843 |
A method should have only one exit point, and that should be the last statement in the method | 849 |
Use bitwise inversion to invert boolean values | 869 |
Use bitwise inversion to invert boolean values | 897 |
Useless parentheses. | 922 - 924 |
Local variable 'labelNamePattern' could be declared final | 922 - 924 |
Do not use the short type | 1044 |
Unnecessary wrapper object creation | 1044 |
Do not use the short type | 1044 |
Avoid reassigning parameters such as 'suffix' | 1063 |
Avoid reassigning parameters such as 'suffix' | 1063 |
Assigning an Object to null is a code smell. Consider refactoring. | 1083 |
Local variable 'nullableString' could be declared final | 1145 |
Useless parentheses. | 1149 |
Unnecessary wrapper object creation | 1153 |
Violation | Line |
---|---|
Local variable 'facade' could be declared final | 49 |
Useless parentheses. | 52 |
Useless parentheses. | 53 |
Deeply nested if..then statements are hard to read | 57 - 72 |
Assigning an Object to null is a code smell. Consider refactoring. | 62 |
Assigning an Object to null is a code smell. Consider refactoring. | 93 |
Useless parentheses. | 93 |
A method should have only one exit point, and that should be the last statement in the method | 120 |
A method should have only one exit point, and that should be the last statement in the method | 124 |
Violation | Line |
---|---|
Avoid excessively long variable names like TRANSFORMATION_ANONYMOUS_NAME_SUFFIX | 26 |
Avoid excessively long variable names like TRANSFORMATION_TO_ENTITY_METHOD_NAME_SUFFIX | 31 |
Avoid excessively long variable names like VALUE_OBJECT_TO_ENTITY_TRANSFORMER_SUFFIX | 36 |
Local variable 'dependency' could be declared final | 93 |
Useless parentheses. | 94 |
Local variable 'element' could be declared final | 108 |
Violation | Line |
---|---|
Use explicit scoping instead of the default package private level | 21 |
Avoid excessively long variable names like EMBEDDED_VALUE_IMPLEMENTATION_NAME_PATTERN | 21 |
Local variable 'value' could be declared final | 39 |
Unnecessary wrapper object creation | 42 |
Violation | Line |
---|---|
Avoid excessively long variable names like ENTITY_DEFAULT_GENERATOR_INITIAL_VALUE | 27 |
Avoid excessively long variable names like ENTITY_DEFAULT_GENERATOR_ALLOCATION_SIZE | 32 |
Avoid excessively long variable names like DEFAULT_ENUM_LITERAL_COLUMN_LENGTH | 37 |
Local variable 'entity' could be declared final | 68 |
These nested if statements could be combined | 125 - 128 |
These nested if statements could be combined | 142 - 145 |
These nested if statements could be combined | 216 - 219 |
These nested if statements could be combined | 233 - 236 |
These nested if statements could be combined | 250 - 253 |
These nested if statements could be combined | 267 - 270 |
These nested if statements could be combined | 284 - 287 |
These nested if statements could be combined | 301 - 304 |
Prefer StringBuffer over += for concatenating strings | 329 |
Local variable 'attribute' could be declared final | 477 |
Local variable 'nullableString' could be declared final | 522 |
Useless parentheses. | 526 |
Unnecessary wrapper object creation | 530 |
Unnecessary wrapper object creation | 569 |
Unnecessary wrapper object creation | 579 |
Violation | Line |
---|---|
A high number of imports can indicate a high degree of coupling within an object. | 1 - 1790 |
The class 'EJB3EntityFacadeLogicImpl' has a Cyclomatic Complexity of 2 (Highest = 22). | 44 - 1790 |
Avoid really long classes. | 44 - 1790 |
This class has too many methods, consider refactoring it. | 46 - 1790 |
Avoid excessively long variable names like ENTITY_DISCRIMINATOR_COLUMN_NAME | 68 |
Avoid excessively long variable names like INHERITANCE_STRATEGY_TABLE_PER_CLASS | 78 |
Avoid excessively long variable names like INHERITANCE_STRATEGY_SINGLE_TABLE | 83 |
Avoid excessively long variable names like INHERITANCE_STRATEGY_JOINED_SUBLCASS | 88 |
Variables that are final and static should be all capitals, 'inheritanceStrategies' is not all capitals. | 93 |
Variables that are final and static should be all capitals, 'discriminatorTypes' is not all capitals. | 120 |
Avoid excessively long variable names like ENTITY_IMPLEMENTATION_NAME_PATTERN | 138 |
Avoid excessively long variable names like ENTITY_COMPOSITE_PRIMARY_KEY_NAME_PATTERN | 156 |
Avoid excessively long variable names like DAO_DEFAULT_EXCEPTION_NAME_PATTERN | 192 |
A method should have only one exit point, and that should be the last statement in the method | 223 |
Local variable 'entityIdentifiers' could be declared final | 228 |
Local variable 'general' could be declared final | 235 |
Parameter 'follow' is not assigned and could be declared final | 258 |
A method should have only one exit point, and that should be the last statement in the method | 274 |
A method should have only one exit point, and that should be the last statement in the method | 278 |
Local variable 'identifiers' could be declared final | 281 |
Local variable 'attribute' could be declared final | 282 |
Local variable 'association' could be declared final | 286 |
Local variable 'jndiName' could be declared final | 317 |
Local variable 'jndiNamePrefix' could be declared final | 318 |
Avoid appending characters as strings in StringBuffer.append. | 322 |
Local variable 'dependencies' could be declared final | 389 |
Parameter 'object' is not assigned and could be declared final | 394 |
Local variable 'dep' could be declared final | 399 |
Local variable 'result' could be declared final | 415 |
Local variable 'target' could be declared final | 418 |
Parameter 'follow' is not assigned and could be declared final | 433 |
Parameter 'follow' is not assigned and could be declared final | 443 |
Local variable 'retval' could be declared final | 445 |
Avoid variables with short names like op | 449 |
Parameter 'follow' is not assigned and could be declared final | 474 |
Parameter 'follow' is not assigned and could be declared final | 484 |
Avoid variables with short names like op | 493 |
Parameter 'op' is not assigned and could be declared final | 493 |
Local variable 'collOps' could be declared final | 495 |
A method should have only one exit point, and that should be the last statement in the method | 501 |
Parameter 'att' is not assigned and could be declared final | 511 |
Local variable 'collAttrib' could be declared final | 513 |
A method should have only one exit point, and that should be the last statement in the method | 519 |
Avoid variables with short names like id | 529 |
Parameter 'id' is not assigned and could be declared final | 529 |
Local variable 'collIdentifier' could be declared final | 531 |
A method should have only one exit point, and that should be the last statement in the method | 537 |
Local variable 'property' could be declared final | 565 |
A catch statement should never catch throwable since it includes errors. | 576 |
Local variable 'errMsg' could be declared final | 578 |
Local variable 'operations' could be declared final | 595 |
Parameter 'object' is not assigned and could be declared final | 598 |
Local variable 'compPKPattern' could be declared final | 617 - 618 |
Local variable 'entityListenerPattern' could be declared final | 631 |
Local variable 'embeddableSuperclassName' could be declared final | 644 - 645 |
Local variable 'entityNamePattern' could be declared final | 658 |
Local variable 'implNamePattern' could be declared final | 683 - 684 |
Local variable 'lengthAsStr' could be declared final | 793 - 794 |
Parameter 'entity' is not assigned and could be declared final | 847 |
Local variable 'value' could be declared final | 852 |
Useless parentheses. | 871 |
Local variable 'superEntity' could be declared final | 895 |
Useless parentheses. | 896 |
Useless parentheses. | 934 |
Useless parentheses. | 953 - 956 |
Local variable 'isEmbeddableSuperclass' could be declared final | 965 |
Useless parentheses. | 979 |
The method handleGetAttributesAsList() has an NPath complexity of 1188 | 986 - 1070 |
The method 'handleGetAttributesAsList' has a Cyclomatic Complexity of 22. | 986 - 1070 |
Parameter 'attributes' is not assigned and could be declared final | 987 |
Parameter 'includeTypes' is not assigned and could be declared final | 988 |
Parameter 'includeNames' is not assigned and could be declared final | 989 |
Parameter 'includeAutoIdentifiers' is not assigned and could be declared final | 990 |
Useless parentheses. | 992 |
A method should have only one exit point, and that should be the last statement in the method | 994 |
Local variable 'sb' could be declared final | 997 |
Avoid variables with short names like sb | 997 |
Local variable 'isCompositePKPresent' could be declared final | 1000 |
Local variable 'attr' could be declared final | 1014 |
These nested if statements could be combined | 1020 - 1045 |
Useless parentheses. | 1021 |
Avoid appending characters as strings in StringBuffer.append. | 1039 |
Local variable 'assoc' could be declared final | 1050 |
Line too long | 1053 |
Avoid appending characters as strings in StringBuffer.append. | 1060 |
These nested if statements could be combined | 1117 - 1121 |
Avoid if (x != y) ..; else ..; | 1181 - 1196 |
Local variable 'facade' could be declared final | 1183 |
Local variable 'finders' could be declared final | 1362 |
Local variable 'operations' could be declared final | 1363 |
Local variable 'nonFinders' could be declared final | 1365 |
Parameter 'object' is not assigned and could be declared final | 1370 |
Parameter 'follow' is not assigned and could be declared final | 1417 |
Local variable 'valueDependencies' could be declared final | 1428 |
Local variable 'dependency' could be declared final | 1429 |
Local variable 'targetElement' could be declared final | 1431 |
Local variable 'element' could be declared final | 1434 |
Avoid using for statements without curly braces | 1451 - 1454 |
Parameter 'follow' is not assigned and could be declared final | 1514 |
Parameter 'withIdentifiers' is not assigned and could be declared final | 1515 |
Parameter 'object' is not assigned and could be declared final | 1522 |
Use bitwise inversion to invert boolean values | 1527 |
Line too long | 1532 |
Line too long | 1538 |
Local variable 'associationEnd' could be declared final | 1539 |
Line too long | 1541 |
Local variable 'ejb3AssociationEnd' could be declared final | 1544 |
Line too long | 1545 |
Local variable 'entity' could be declared final | 1548 |
Local variable 'identifierAttributes' could be declared final | 1549 |
Line too long | 1550 |
Local variable 'identifier' could be declared final | 1551 |
Parameter 'withIdentifiers' is not assigned and could be declared final | 1570 |
Parameter 'follow' is not assigned and could be declared final | 1570 |
Parameter 'withIdentifiers' is not assigned and could be declared final | 1579 |
Parameter 'follow' is not assigned and could be declared final | 1579 |
Parameter 'object' is not assigned and could be declared final | 1642 |
Avoid instantiating new objects inside loops | 1685 |
Local variable 'role' could be declared final | 1688 |
Avoid if (x != y) ..; else ..; | 1694 |
Local variable 'roles' could be declared final | 1717 |
Local variable 'dependency' could be declared final | 1724 |
Violation | Line |
---|---|
Useless parentheses. | 33 |
A method should have only one exit point, and that should be the last statement in the method | 35 |
Local variable 'sb' could be declared final | 38 |
Avoid variables with short names like sb | 38 |
Local variable 'obj' could be declared final | 41 |
Avoid appending characters as strings in StringBuffer.append. | 49 |
Violation | Line |
---|---|
Local variable 'classifier' could be declared final | 37 |
These nested if statements could be combined | 40 - 54 |
Deeply nested if..then statements are hard to read | 46 - 53 |
Local variable 'literal' could be declared final | 87 |
Local variable 'literal' could be declared final | 105 |
Violation | Line |
---|---|
Found non-transient, non-static member. Please mark as transient or provide accessors. | 43 |
Avoid using redundant field initializer for 'translatedQuery' | 43 |
Local variable 'queryCacheEnabledStr' could be declared final | 92 |
Local variable 'variableName' could be declared final | 135 |
Local variable 'arguments' could be declared final | 137 |
Local variable 'facade' could be declared final | 142 |
Local variable 'argument' could be declared final | 144 |
Deeply nested if..then statements are hard to read | 147 - 151 |
Prefer StringBuffer over += for concatenating strings | 149 |
Deeply nested if..then statements are hard to read | 153 - 156 |
Prefer StringBuffer over += for concatenating strings | 157 |
Violation | Line |
---|---|
Local variable 'interceptorNamePattern' could be declared final | 45 |
Local variable 'references' could be declared final | 70 |
Local variable 'dependency' could be declared final | 77 |
Local variable 'targetElement' could be declared final | 78 |
Local variable 'isDefaultInterceptorStr' could be declared final | 114 - 115 |
Violation | Line |
---|---|
Avoid excessively long variable names like MANAGEABLE_SERVICE_BASE_NAME_PATTERN | 51 |
Local variable 'exceptionNamePattern' could be declared final | 70 |
Local variable 'exceptionNamePattern' could be declared final | 95 |
Local variable 'exceptionNamePattern' could be declared final | 120 |
Local variable 'exceptionNamePattern' could be declared final | 145 |
Assigning an Object to null is a code smell. Consider refactoring. | 181 |
Local variable 'exceptionNamePattern' could be declared final | 190 |
Local variable 'roles' could be declared final | 225 - 228 |
Avoid instantiating new objects inside loops | 235 |
Avoid if (x != y) ..; else ..; | 243 |
Use bitwise inversion to invert boolean values | 300 |
Violation | Line |
---|---|
Avoid excessively long variable names like MESSAGE_DRIVEN_TOPIC_SUBSCRIPTION_DURABILITY | 38 |
Avoid excessively long variable names like MESSAGE_DRIVEN_LISTENER_NAME_PATTERN | 49 |
Avoid excessively long variable names like MESSAGE_DRIVEN_IMPLEMENTATION_NAME_PATTERN | 54 |
Avoid excessively long variable names like MESSAGE_DRIVEN_TEST_NAME_PATTERN | 59 |
Avoid excessively long variable names like MESSAGE_DRIVEN_TEST_PACKAGE_NAME_PATTERN | 64 |
Avoid excessively long variable names like MESSAGE_DRIVEN_DURABLE_SUBSCRIPTION_ID_PATTERN | 69 |
Local variable 'namespacePattern' could be declared final | 142 |
Local variable 'messageDrivenImplNamePattern' could be declared final | 202 - 203 |
Local variable 'messageDrivenListenerNamePattern' could be declared final | 216 - 217 |
Avoid excessively long variable names like messageDrivenListenerNamePattern | 216 |
Local variable 'messageDrivenNamePattern' could be declared final | 230 - 231 |
Local variable 'messageDrivenTestNamePattern' could be declared final | 244 - 245 |
Local variable 'dependency' could be declared final | 268 - 280 |
Local variable 'role' could be declared final | 283 |
Local variable 'durableSubscriptionIdPattern' could be declared final | 334 - 335 |
Parameter 'attributes' is not assigned and could be declared final | 375 |
Parameter 'includeTypes' is not assigned and could be declared final | 376 |
Parameter 'includeNames' is not assigned and could be declared final | 377 |
A method should have only one exit point, and that should be the last statement in the method | 381 |
Avoid variables with short names like sb | 384 |
Local variable 'sb' could be declared final | 384 |
Local variable 'attr' could be declared final | 389 |
Avoid appending characters as strings in StringBuffer.append. | 395 |
Parameter 'follow' is not assigned and could be declared final | 410 |
Local variable 'references' could be declared final | 420 |
Parameter 'object' is not assigned and could be declared final | 425 |
Local variable 'targetElement' could be declared final | 427 |
Parameter 'follow' is not assigned and could be declared final | 465 |
Local variable 'minPoolSizeStr' could be declared final | 476 |
Local variable 'maxPoolSizeStr' could be declared final | 490 |
Local variable 'references' could be declared final | 512 |
Parameter 'object' is not assigned and could be declared final | 517 |
Local variable 'dependency' could be declared final | 519 |
Local variable 'targetElement' could be declared final | 520 |
Useless parentheses. | 521 |
Parameter 'object' is not assigned and could be declared final | 538 |
Local variable 'excludeDefaultStr' could be declared final | 556 - 557 |
Violation | Line |
---|---|
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. | 27 - 571 |
Use explicit scoping instead of the default package private level | 35 - 58 |
Parameter 'classifier' is not assigned and could be declared final | 36 |
Parameter 'follow' is not assigned and could be declared final | 37 |
The String literal "classifer" appears 11 times in this file; the first occurrence is on line 39 | 39 |
Local variable 'retval' could be declared final | 40 |
Avoid variables with short names like op | 44 |
Use explicit scoping instead of the default package private level | 66 - 79 |
Parameter 'classifier' is not assigned and could be declared final | 66 |
Use explicit scoping instead of the default package private level | 93 - 125 |
Parameter 'classifier' is not assigned and could be declared final | 94 |
Parameter 'defaultViewType' is not assigned and could be declared final | 95 |
These nested if statements could be combined | 101 - 122 |
Parameter 'object' is not assigned and could be declared final | 110 |
Useless parentheses. | 119 - 120 |
Parameter 'classifier' is not assigned and could be declared final | 134 |
Use explicit scoping instead of the default package private level | 134 - 149 |
Local variable 'current' could be declared final | 137 |
A method should have only one exit point, and that should be the last statement in the method | 140 |
Local variable 'retval' could be declared final | 142 |
Use explicit scoping instead of the default package private level | 158 - 164 |
Parameter 'classifier' is not assigned and could be declared final | 158 |
Local variable 'retval' could be declared final | 161 |
Use explicit scoping instead of the default package private level | 176 - 202 |
Avoid reassigning parameters such as 'classifier' | 177 |
Avoid reassigning parameters such as 'classifier' | 177 |
Parameter 'follow' is not assigned and could be declared final | 178 |
Local variable 'attributes' could be declared final | 182 |
Parameter 'object' is not assigned and could be declared final | 195 |
Parameter 'defaultTransactionType' is not assigned and could be declared final | 211 |
Use explicit scoping instead of the default package private level | 211 - 225 |
Parameter 'classifier' is not assigned and could be declared final | 211 |
Parameter 'transType' is not assigned and could be declared final | 235 |
Use explicit scoping instead of the default package private level | 235 - 265 |
Use explicit scoping instead of the default package private level | 278 - 304 |
Avoid reassigning parameters such as 'classifier' | 279 |
Avoid reassigning parameters such as 'classifier' | 279 |
Parameter 'follow' is not assigned and could be declared final | 280 |
Local variable 'attributes' could be declared final | 284 |
Parameter 'object' is not assigned and could be declared final | 297 |
Use explicit scoping instead of the default package private level | 312 - 317 |
Parameter 'classifier' is not assigned and could be declared final | 312 |
Use explicit scoping instead of the default package private level | 328 - 341 |
Parameter 'packageName' is not assigned and could be declared final | 329 |
Parameter 'name' is not assigned and could be declared final | 330 |
Parameter 'suffix' is not assigned and could be declared final | 331 |
Local variable 'fullyQualifiedName' could be declared final | 333 |
Use explicit scoping instead of the default package private level | 349 - 357 |
Parameter 'classifier' is not assigned and could be declared final | 349 |
Parameter 'stateless' is not assigned and could be declared final | 369 |
Use explicit scoping instead of the default package private level | 369 - 385 |
Parameter 'classifier' is not assigned and could be declared final | 369 |
Use explicit scoping instead of the default package private level | 394 - 403 |
Parameter 'classifier' is not assigned and could be declared final | 394 |
Parameter 'parameters' is not assigned and could be declared final | 410 |
Use explicit scoping instead of the default package private level | 410 - 433 |
Local variable 'buf' could be declared final | 412 |
Avoid if (x != y) ..; else ..; | 413 - 432 |
Avoid appending characters as strings in StringBuffer.append. | 415 |
Local variable 'it' could be declared final | 416 |
Avoid variables with short names like it | 416 |
Local variable 'option' could be declared final | 419 |
Avoid appending characters as strings in StringBuffer.append. | 426 |
A method should have only one exit point, and that should be the last statement in the method | 427 |
Parameter 'name' is not assigned and could be declared final | 441 |
Use explicit scoping instead of the default package private level | 441 - 444 |
Parameter 'values' is not assigned and could be declared final | 441 |
Parameter 'values' is not assigned and could be declared final | 453 |
Use explicit scoping instead of the default package private level | 453 - 456 |
Parameter 'areStrings' is not assigned and could be declared final | 453 |
Parameter 'name' is not assigned and could be declared final | 453 |
Parameter 'suffix' is not assigned and could be declared final | 467 |
Parameter 'name' is not assigned and could be declared final | 467 |
Parameter 'areStrings' is not assigned and could be declared final | 467 |
Use explicit scoping instead of the default package private level | 467 - 503 |
Parameter 'values' is not assigned and could be declared final | 467 |
A method should have only one exit point, and that should be the last statement in the method | 471 |
Local variable 'buf' could be declared final | 475 |
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). | 476 |
Local variable 'it' could be declared final | 478 |
Avoid variables with short names like it | 478 |
Local variable 'parameter' could be declared final | 481 |
Avoid appending characters as strings in StringBuffer.append. | 484 |
Useless parentheses. | 487 |
Avoid appending characters as strings in StringBuffer.append. | 493 |
Avoid appending characters as strings in StringBuffer.append. | 500 |
Avoid reassigning parameters such as 'prefix' | 523 |
Avoid reassigning parameters such as 'name' | 525 |
Avoid reassigning parameters such as 'suffix' | 527 |
Local variable 'value' could be declared final | 533 |
Do not use the short type | 548 |
Do not use the short type | 548 |
Avoid instantiating Short objects. Call Short.valueOf() instead | 553 |
Violation | Line |
---|---|
Local variable 'implementationNamePattern' could be declared final | 183 - 184 |
Violation | Line |
---|---|
Local variable 'parameters' could be declared final | 74 |
Avoid if (x != y) ..; else ..; | 75 - 86 |
Local variable 'value' could be declared final | 87 |
The String literal "value = \"" appears 7 times in this file; the first occurrence is on line 90 | 90 |
Local variable 'parameters' could be declared final | 111 |
Local variable 'scope' could be declared final | 117 |
Local variable 'value' could be declared final | 123 |
Local variable 'parameters' could be declared final | 161 |
Local variable 'value' could be declared final | 162 |
Local variable 'scope' could be declared final | 167 |
Local variable 'parameters' could be declared final | 191 |
Local variable 'value' could be declared final | 192 |
Local variable 'parameters' could be declared final | 216 |
Local variable 'value' could be declared final | 217 - 218 |
A method should have only one exit point, and that should be the last statement in the method | 244 |
Local variable 'parameters' could be declared final | 246 |
Local variable 'value' could be declared final | 247 |
Local variable 'parameters' could be declared final | 271 |
Local variable 'value' could be declared final | 272 - 273 |
Violation | Line |
---|---|
Avoid really long classes. | 28 - 1453 |
This class has too many methods, consider refactoring it. | 30 - 1453 |
Avoid excessively long variable names like SERVICE_LOCAL_INTERFACE_NAME_PATTERN | 45 |
Avoid excessively long variable names like SERVICE_REMOTE_INTERFACE_NAME_PATTERN | 50 |
Avoid excessively long variable names like SERVICE_IMPLEMENTATION_NAME_PATTERN | 60 |
Avoid excessively long variable names like SERVICE_TEST_PACKAGE_NAME_PATTERN | 80 |
Avoid excessively long variable names like SERVICE_DEFAULT_EXCEPTION_NAME_PATTERN | 86 |
Local variable 'operations' could be declared final | 156 |
Parameter 'object' is not assigned and could be declared final | 161 |
Parameter 'attributes' is not assigned and could be declared final | 218 |
Parameter 'object' is not assigned and could be declared final | 224 |
Prefer StringBuffer over += for concatenating strings | 246 |
Prefer StringBuffer over += for concatenating strings | 260 |
Assigning an Object to null is a code smell. Consider refactoring. | 272 |
Local variable 'sessionType' could be declared final | 282 |
Use bitwise inversion to invert boolean values | 285 |
Local variable 'sessionType' could be declared final | 301 |
Local variable 'operationWithRemoteViewExists' could be declared final | 353 - 373 |
Parameter 'object' is not assigned and could be declared final | 358 |
Useless parentheses. | 374 |
Prefer StringBuffer over += for concatenating strings | 374 |
Local variable 'operationWithLocalViewExists' could be declared final | 378 - 398 |
Parameter 'object' is not assigned and could be declared final | 383 |
Prefer StringBuffer over += for concatenating strings | 399 |
Useless parentheses. | 399 |
Local variable 'viewType' could be declared final | 455 - 456 |
Local variable 'viewType' could be declared final | 472 - 473 |
Local variable 'viewType' could be declared final | 489 - 490 |
Parameter 'follow' is not assigned and could be declared final | 521 |
Parameter 'follow' is not assigned and could be declared final | 531 |
Parameter 'follow' is not assigned and could be declared final | 541 |
Local variable 'namespacePattern' could be declared final | 552 |
Local variable 'serviceNamePattern' could be declared final | 564 |
Local variable 'serviceInterfaceNamePattern' could be declared final | 577 - 578 |
Avoid excessively long variable names like serviceLocalInterfaceNamePattern | 591 |
Local variable 'serviceLocalInterfaceNamePattern' could be declared final | 591 - 592 |
Local variable 'serviceRemoteInterfaceNamePattern' could be declared final | 605 - 606 |
Avoid excessively long variable names like serviceRemoteInterfaceNamePattern | 605 |
Avoid excessively long variable names like serviceImplementationNamePattern | 619 |
Local variable 'serviceImplementationNamePattern' could be declared final | 619 - 620 |
Local variable 'serviceListenerNamePattern' could be declared final | 633 - 634 |
Local variable 'serviceDelegateNamePattern' could be declared final | 648 - 649 |
Local variable 'serviceBaseNamePattern' could be declared final | 662 - 663 |
Local variable 'serviceTestNamePattern' could be declared final | 676 - 677 |
Local variable 'references' could be declared final | 822 |
Parameter 'object' is not assigned and could be declared final | 827 |
Local variable 'targetElement' could be declared final | 829 |
Useless parentheses. | 830 - 831 |
Local variable 'references' could be declared final | 853 |
Parameter 'object' is not assigned and could be declared final | 858 |
Local variable 'targetElement' could be declared final | 860 |
Parameter 'attributes' is not assigned and could be declared final | 872 |
Parameter 'includeTypes' is not assigned and could be declared final | 873 |
Parameter 'includeNames' is not assigned and could be declared final | 874 |
A method should have only one exit point, and that should be the last statement in the method | 878 |
Local variable 'sb' could be declared final | 881 |
Avoid variables with short names like sb | 881 |
Local variable 'attr' could be declared final | 886 |
Avoid appending characters as strings in StringBuffer.append. | 892 |
Avoid instantiating new objects inside loops | 943 |
Local variable 'role' could be declared final | 946 |
Avoid if (x != y) ..; else ..; | 952 |
Local variable 'permitAllStr' could be declared final | 962 |
Local variable 'denyAllStr' could be declared final | 977 |
Local variable 'dependency' could be declared final | 1016 - 1028 |
Local variable 'role' could be declared final | 1031 |
Local variable 'references' could be declared final | 1060 |
Parameter 'object' is not assigned and could be declared final | 1065 |
Local variable 'dependency' could be declared final | 1067 |
Local variable 'targetElement' could be declared final | 1068 |
Useless parentheses. | 1069 - 1072 |
Local variable 'references' could be declared final | 1083 |
Parameter 'object' is not assigned and could be declared final | 1088 |
Local variable 'dependency' could be declared final | 1090 |
Local variable 'targetElement' could be declared final | 1091 |
Useless parentheses. | 1092 - 1095 |
Local variable 'references' could be declared final | 1106 |
Parameter 'object' is not assigned and could be declared final | 1109 |
Local variable 'dependency' could be declared final | 1111 |
Local variable 'targetElement' could be declared final | 1112 |
Useless parentheses. | 1113 - 1114 |
Local variable 'references' could be declared final | 1125 |
Parameter 'object' is not assigned and could be declared final | 1130 |
Local variable 'dependency' could be declared final | 1132 |
Local variable 'targetElement' could be declared final | 1133 |
Useless parentheses. | 1134 - 1135 |
Parameter 'object' is not assigned and could be declared final | 1152 |
Local variable 'roles' could be declared final | 1168 |
Local variable 'dependency' could be declared final | 1175 |
Local variable 'defaultExceptionNamePattern' could be declared final | 1211 - 1212 |
Unnecessary wrapper object creation | 1245 |
Local variable 'excludeDefaultStr' could be declared final | 1265 - 1266 |
Local variable 'depends' could be declared final | 1392 |
A method should have only one exit point, and that should be the last statement in the method | 1395 |
Local variable 'buf' could be declared final | 1399 |
Local variable 'it' could be declared final | 1401 |
Avoid variables with short names like it | 1401 |
Local variable 'dependency' could be declared final | 1404 |
Avoid appending characters as strings in StringBuffer.append. | 1405 |
Avoid appending characters as strings in StringBuffer.append. | 1407 |
Violation | Line |
---|---|
Avoid really long classes. | 28 - 1106 |
This class has too many methods, consider refactoring it. | 30 - 1106 |
Avoid excessively long variable names like SERVICE_OPERATION_TEST_NAME_PATTERN | 35 |
Local variable 'sessionFacade' could be declared final | 55 |
Local variable 'viewType' could be declared final | 117 |
Local variable 'viewType' could be declared final | 132 |
Local variable 'viewType' could be declared final | 147 |
Local variable 'session' could be declared final | 162 |
Useless parentheses. | 165 - 168 |
Useless parentheses. | 166 |
Useless parentheses. | 167 - 168 |
Useless parentheses. | 169 |
Local variable 'session' could be declared final | 184 |
Useless parentheses. | 187 - 190 |
Useless parentheses. | 188 |
Useless parentheses. | 189 - 190 |
Useless parentheses. | 191 |
Avoid appending characters as strings in StringBuffer.append. | 225 |
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 225 |
Avoid appending characters as strings in StringBuffer.append. | 227 |
Local variable 'serviceOperationTestNamePattern' could be declared final | 248 - 249 |
Local variable 'operations' could be declared final | 253 |
Local variable 'operation' could be declared final | 254 |
Local variable 'argument' could be declared final | 260 |
Prefer StringBuffer over += for concatenating strings | 262 |
Avoid appending characters as strings in StringBuffer.append. | 285 |
StringBuffer (or StringBuilder).append is called 3 consecutive times with literal Strings. Use a single append with a single combined String. | 285 |
Avoid appending characters as strings in StringBuffer.append. | 287 |
Local variable 'session' could be declared final | 308 |
Avoid instantiating new objects inside loops | 336 |
Local variable 'role' could be declared final | 339 |
Avoid if (x != y) ..; else ..; | 345 |
Local variable 'permitAllStr' could be declared final | 355 |
Local variable 'denyAllStr' could be declared final | 370 |
Avoid if (x != y) ..; else ..; | 402 |
Parameter 'initialExceptions' is not assigned and could be declared final | 409 |
Avoid if (x != y) ..; else ..; | 412 - 420 |
Local variable 'operationRoles' could be declared final | 434 |
Parameter 'object' is not assigned and could be declared final | 439 |
Local variable 'dependency' could be declared final | 441 |
Parameter 'object' is not assigned and could be declared final | 452 |
Parameter 'object' is not assigned and could be declared final | 465 |
Useless parentheses. | 509 - 511 |
Parameter 'replacement' is not assigned and could be declared final | 521 |
Local variable 'implementationNamePattern' could be declared final | 523 - 524 |
Local variable 'references' could be declared final | 536 |
Parameter 'object' is not assigned and could be declared final | 541 |
Local variable 'dependency' could be declared final | 543 |
Local variable 'targetElement' could be declared final | 544 |
Useless parentheses. | 545 |
Parameter 'object' is not assigned and could be declared final | 562 |
Local variable 'excludeDefaultStr' could be declared final | 580 - 581 |
Local variable 'excludeClassStr' could be declared final | 596 - 597 |
Prefer StringBuffer over += for concatenating strings | 674 |
Local variable 'parameters' could be declared final | 764 |
Local variable 'value' could be declared final | 765 |
Local variable 'scope' could be declared final | 771 |
Avoid if (x != y) ..; else ..; | 795 - 832 |
A method should have only one exit point, and that should be the last statement in the method | 797 |
Local variable 'parameters' could be declared final | 801 |
Local variable 'flushMode' could be declared final | 802 |
Local variable 'pageflow' could be declared final | 808 |
Local variable 'join' could be declared final | 814 |
Local variable 'nested' could be declared final | 820 |
Local variable 'ifOutcome' could be declared final | 826 |
The String literal "ifOutcome" appears 5 times in this file; the first occurrence is on line 829 | 829 |
Avoid if (x != y) ..; else ..; | 850 - 871 |
A method should have only one exit point, and that should be the last statement in the method | 852 |
Local variable 'parameters' could be declared final | 856 |
Local variable 'flushMode' could be declared final | 857 - 858 |
Local variable 'taskIdParameter' could be declared final | 864 - 865 |
Avoid if (x != y) ..; else ..; | 908 - 940 |
A method should have only one exit point, and that should be the last statement in the method | 910 |
Local variable 'parameters' could be declared final | 914 |
Local variable 'beforeRedirect' could be declared final | 915 - 916 |
Local variable 'ifOutcome' could be declared final | 922 |
Local variable 'exceptions' could be declared final | 928 - 929 |
Avoid if (x != y) ..; else ..; | 957 - 983 |
A method should have only one exit point, and that should be the last statement in the method | 959 |
Local variable 'parameters' could be declared final | 963 |
Local variable 'transition' could be declared final | 964 - 965 |
Local variable 'beforeRedirect' could be declared final | 971 - 972 |
Local variable 'ifOutcome' could be declared final | 977 |
Avoid if (x != y) ..; else ..; | 1021 - 1043 |
A method should have only one exit point, and that should be the last statement in the method | 1023 |
Local variable 'parameters' could be declared final | 1027 |
Local variable 'flushMode' could be declared final | 1028 - 1029 |
Local variable 'taskIdParameter' could be declared final | 1035 - 1036 |
Local variable 'outcomes' could be declared final | 1070 |
A method should have only one exit point, and that should be the last statement in the method | 1073 |
Local variable 'excludes' could be declared final | 1096 |
A method should have only one exit point, and that should be the last statement in the method | 1099 |
Violation | Line |
---|---|
Local variable 'uri' could be declared final | 58 |
A catch statement should never catch throwable since it includes errors. | 66 |
Violation | Line |
---|---|
Avoid excessively long variable names like WEB_SERVICE_INTERFACE_NAME_PATTERN | 25 |
Avoid excessively long variable names like PROPERTY_DEFAULT_PARAMETER_STYLE | 60 |
Local variable 'webServiceInterfaceNamePattern' could be declared final | 115 - 116 |
Local variable 'qnameLocalPartPattern' could be declared final | 248 |
Local variable 'namespacePattern' could be declared final | 265 |
Unnecessary wrapper object creation | 281 |
Violation | Line |
---|---|
Variables that are final and static should be all capitals, 'logger' is not all capitals. | 22 |
Avoid appending characters as strings in StringBuffer.append. | 60 |
Avoid appending characters as strings in StringBuffer.append. | 62 |
Local variable 'paramter' could be declared final | 75 |
Avoid appending characters as strings in StringBuffer.append. | 93 |
StringBuffer (or StringBuilder).append is called 2 consecutive times with literal Strings. Use a single append with a single combined String. | 101 |
Avoid appending characters as strings in StringBuffer.append. | 102 |
Avoid appending characters as strings in StringBuffer.append. | 107 |
Avoid appending characters as strings in StringBuffer.append. | 112 |