PMD Results

The following document contains the results of PMD 5.0.2.

Files

org/andromda/cartridges/jsf/JSFGlobals.java

Violation Line
Avoid excessively long variable names like PROPERTY_DEFAULT_TABLE_EXPORT_TYPES 18
Avoid excessively long variable names like PROPERTY_DEFAULT_INPUT_COLUMN_COUNT 23
Avoid excessively long variable names like PROPERTY_DEFAULT_INPUT_ROW_COUNT 28
Avoid excessively long variable names like CONTROLLER_IMPLEMENTATION_PATTERN 72
Avoid excessively long variable names like DOCUMENTATION_MESSAGE_KEY_SUFFIX 82

org/andromda/cartridges/jsf/JSFProfile.java

Violation Line
Avoid excessively long variable names like STEREOTYPE_FRONT_END_REGISTRATION 19
Avoid excessively long variable names like TAGGEDVALUE_INPUT_TABLE_IDENTIFIER_COLUMNS 51
Avoid excessively long variable names like TAGGEDVALUE_ACTION_SUCCESS_MESSAGE 66
Avoid excessively long variable names like TAGGEDVALUE_ACTION_WARNING_MESSAGE 68
Avoid excessively long variable names like TAGGEDVALUE_TABLE_SORTABLE_DEFAULT_VALUE 108
Avoid excessively long variable names like TAGGEDVALUE_TABLE_EXPORTABLE_DEFAULT_VALUE 110
Avoid excessively long variable names like TAGGEDVALUE_TABLE_MAXROWS_DEFAULT_COUNT 112

org/andromda/cartridges/jsf/JSFUtils.java

Violation Line
This class has a bunch of public methods and attributes 1 - 1238
Avoid really long classes. 35 - 1238
The class 'JSFUtils' has a Cyclomatic Complexity of 3 (Highest = 34). 35 - 1238
Avoid reassigning parameters such as 'validatorTaggedValue' 63
Local variable 'left' could be declared final 86
Avoid reassigning parameters such as 'validatorTaggedValue' 121
Local variable 'left' could be declared final 141
Local variable 'right' could be declared final 144
A method should have only one exit point, and that should be the last statement in the method 179
Avoid appending characters as strings in StringBuffer.append. 214
Avoid reassigning parameters such as 'format' 222
Avoid variables with short names like df 229
Parameter 'format' is not assigned and could be declared final 237
Singleton is not thread safe 239 - 242
Parameter 'format' is not assigned and could be declared final 263
Parameter 'format' is not assigned and could be declared final 277
Parameter 'format' is not assigned and could be declared final 291
The String literal "minlength" appears 4 times in this file; the first occurrence is on line 324 324
Parameter 'format' is not assigned and could be declared final 336
The String literal "maxlength" appears 4 times in this file; the first occurrence is on line 338 338
Parameter 'string' is not assigned and could be declared final 351
Parameter 'index' is not assigned and could be declared final 352
Parameter 'limit' is not assigned and could be declared final 353
Assigning an Object to null is a code smell. Consider refactoring. 361
Parameter 'typeName' is not assigned and could be declared final 490
These nested if statements could be combined 498 - 507
Unnecessary wrapper object creation 534
The method getValidatorTypes() has an NPath complexity of 68002 689 - 814
Avoid really long methods. 689 - 814
The method 'getValidatorTypes' has a Cyclomatic Complexity of 34. 689 - 814
These nested if statements could be combined 707 - 710
Local variable 'formats' could be declared final 777
Local variable 'additionalFormat' could be declared final 780
Local variable 'validator' could be declared final 809
The method getValidatorVars() has an NPath complexity of 2690 825 - 959
Avoid really long methods. 825 - 959
The method 'getValidatorVars' has a Cyclomatic Complexity of 20. 825 - 959
Avoid throwing raw exception types. 894
Unnecessary use of fully qualified name 'java.util.Collection' due to existing import 'java.util.Collection' 968
Found non-transient, non-static member. Please mark as transient or provide accessors. 1134
Parameter 'portletContainer' is not assigned and could be declared final 1139
Parameter 'buffer' is not assigned and could be declared final 1204
Local variable 'md' could be declared final 1210
Avoid variables with short names like md 1210
Local variable 'hashBytes' could be declared final 1211
Avoid throwing raw exception types. 1224
Parameter 'string' is not assigned and could be declared final 1234
Avoid if (x != y) ..; else ..; 1236

org/andromda/cartridges/jsf/metafacades/JSFActionLogicImpl.java

Violation Line
This class has too many methods, consider refactoring it. 38 - 854
Parameter 'metaObject' is not assigned and could be declared final 45
Parameter 'context' is not assigned and could be declared final 46
Parameter 'withUseCaseName' is not assigned and could be declared final 71
Avoid if (x != y) ..; else ..; 78 - 79
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 149
Prefer StringBuffer over += for concatenating strings 225
Prefer StringBuffer over += for concatenating strings 319
Useless parentheses. 343
Assigning an Object to null is a code smell. Consider refactoring. 344
Deeply nested if..then statements are hard to read 370 - 373
Avoid if (x != y) ..; else ..; 428
Parameter 'string' is not assigned and could be declared final 474
Local variable 'attribute' could be declared final 532
The method handleGetFormSerialVersionUID() has an NPath complexity of 30000 637 - 701
Avoid if (x != y) ..; else ..; 644
Avoid if (x != y) ..; else ..; 647
Avoid if (x != y) ..; else ..; 650
Avoid if (x != y) ..; else ..; 653
Avoid variables with short names like md 681
Local variable 'md' could be declared final 681
Local variable 'hashBytes' could be declared final 682
Unnecessary wrapper object creation 709
Parameter 'taggedValue' is not assigned and could be declared final 763
A method should have only one exit point, and that should be the last statement in the method 809
A method should have only one exit point, and that should be the last statement in the method 819
Avoid using for statements without curly braces 823 - 825
Avoid using if statements without curly braces 824 - 825
A method should have only one exit point, and that should be the last statement in the method 825
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 842

org/andromda/cartridges/jsf/metafacades/JSFActivityGraphLogicImpl.java

Violation Line
Parameter 'context' is not assigned and could be declared final 16
Parameter 'metaObject' is not assigned and could be declared final 16

org/andromda/cartridges/jsf/metafacades/JSFAttributeLogicImpl.java

Violation Line
The class 'JSFAttributeLogicImpl' has a Cyclomatic Complexity of 3 (Highest = 33). 24 - 784
Parameter 'metaObject' is not assigned and could be declared final 33
Parameter 'context' is not assigned and could be declared final 34
String.trim().length()==0 is an inefficient way to validate an empty String. 56
Unnecessary wrapper object creation 72
Avoid really long methods. 117 - 222
The method 'handleGetDummyValue' has a Cyclomatic Complexity of 33. 117 - 222
The method handleGetDummyValue() has an NPath complexity of 214990849 117 - 222
A method should have only one exit point, and that should be the last statement in the method 126
A method should have only one exit point, and that should be the last statement in the method 130
A method should have only one exit point, and that should be the last statement in the method 134
A method should have only one exit point, and that should be the last statement in the method 138
A method should have only one exit point, and that should be the last statement in the method 142
A method should have only one exit point, and that should be the last statement in the method 146
A method should have only one exit point, and that should be the last statement in the method 150
A method should have only one exit point, and that should be the last statement in the method 154
A method should have only one exit point, and that should be the last statement in the method 158
A method should have only one exit point, and that should be the last statement in the method 162
A method should have only one exit point, and that should be the last statement in the method 166
A method should have only one exit point, and that should be the last statement in the method 170
A method should have only one exit point, and that should be the last statement in the method 174
A method should have only one exit point, and that should be the last statement in the method 178
A method should have only one exit point, and that should be the last statement in the method 182
A method should have only one exit point, and that should be the last statement in the method 186
A method should have only one exit point, and that should be the last statement in the method 190
A method should have only one exit point, and that should be the last statement in the method 194
A method should have only one exit point, and that should be the last statement in the method 198
A method should have only one exit point, and that should be the last statement in the method 202
A method should have only one exit point, and that should be the last statement in the method 206
A method should have only one exit point, and that should be the last statement in the method 212
A method should have only one exit point, and that should be the last statement in the method 216
String.trim().length()==0 is an inefficient way to validate an empty String. 250
The String literal "{0}" appears 4 times in this file; the first occurrence is on line 267 267
Unnecessary use of fully qualified name 'org.andromda.utils.StringUtilsHelper.lowerCamelCaseName' due to existing import 'org.andromda.utils.StringUtilsHelper' 269
Unnecessary use of fully qualified name 'org.andromda.utils.StringUtilsHelper.lowerCamelCaseName' due to existing import 'org.andromda.utils.StringUtilsHelper' 284
Deeply nested if..then statements are hard to read 353 - 368
Deeply nested if..then statements are hard to read 382 - 389
Parameter 'ownerParameter' is not assigned and could be declared final 422
Avoid if (x != y) ..; else ..; 530
Local variable 'type' could be declared final 564
Assigning an Object to null is a code smell. Consider refactoring. 620
Assigning an Object to null is a code smell. Consider refactoring. 631
Prefer StringBuffer over += for concatenating strings 647
String.trim().length()==0 is an inefficient way to validate an empty String. 660
Deeply nested if..then statements are hard to read 698 - 705
Deeply nested if..then statements are hard to read 726 - 729
A method should have only one exit point, and that should be the last statement in the method 773
A method should have only one exit point, and that should be the last statement in the method 779

org/andromda/cartridges/jsf/metafacades/JSFBackendServiceLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 19
Parameter 'context' is not assigned and could be declared final 20
Local variable 'accessorImplementation' could be declared final 31
Local variable 'packageName' could be declared final 41

org/andromda/cartridges/jsf/metafacades/JSFControllerLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 28
Parameter 'context' is not assigned and could be declared final 28
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 54
This statement may have some unnecessary parentheses 86
Useless parentheses. 86
Parameter 'buffer' is not assigned and could be declared final 107

org/andromda/cartridges/jsf/metafacades/JSFControllerOperationLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 21
Parameter 'context' is not assigned and could be declared final 21
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 46
Avoid appending characters as strings in StringBuffer.append. 68
Avoid appending characters as strings in StringBuffer.append. 73
Parameter 'isAbstract' is not assigned and could be declared final 101
StringBuffer constructor is initialized with size 16, but has at least 18 characters appended. 103
Avoid if (x != y) ..; else ..; 110
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 114
Avoid appending characters as strings in StringBuffer.append. 116

org/andromda/cartridges/jsf/metafacades/JSFEnumerationLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 21
Parameter 'context' is not assigned and could be declared final 21

org/andromda/cartridges/jsf/metafacades/JSFEventLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 19
Parameter 'context' is not assigned and could be declared final 19
Deeply nested if..then statements are hard to read 37 - 40
Prefer StringBuffer over += for concatenating strings 39
Unnecessary wrapper object creation 80

org/andromda/cartridges/jsf/metafacades/JSFExceptionHandlerLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 27
Parameter 'context' is not assigned and could be declared final 27
Useless parentheses. 46
A method should have only one exit point, and that should be the last statement in the method 63
A method should have only one exit point, and that should be the last statement in the method 67
Avoid if (x != y) ..; else ..; 97

org/andromda/cartridges/jsf/metafacades/JSFFinalStateLogicImpl.java

Violation Line
Parameter 'context' is not assigned and could be declared final 19
Parameter 'metaObject' is not assigned and could be declared final 19
Local variable 'useCase' could be declared final 32
Local variable 'name' could be declared final 39
This call to String.startsWith can be rewritten using String.charAt(0) 40

org/andromda/cartridges/jsf/metafacades/JSFForwardLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 27
Parameter 'context' is not assigned and could be declared final 27
Local variable 'name' could be declared final 37
Parameter 'taggedValue' is not assigned and could be declared final 94

org/andromda/cartridges/jsf/metafacades/JSFManageableEntityAssociationEndLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 24
Parameter 'context' is not assigned and could be declared final 24
Unnecessary use of fully qualified name 'org.andromda.utils.StringUtilsHelper.lowerCamelCaseName' due to existing import 'org.andromda.utils.StringUtilsHelper' 100

org/andromda/cartridges/jsf/metafacades/JSFManageableEntityAttributeLogicImpl.java

Violation Line
The class 'JSFManageableEntityAttributeLogicImpl' has a Cyclomatic Complexity of 2 (Highest = 33). 20 - 694
This class has too many methods, consider refactoring it. 22 - 694
Parameter 'metaObject' is not assigned and could be declared final 28
Parameter 'context' is not assigned and could be declared final 28
Prefer StringBuffer over += for concatenating strings 44
Useless parentheses. 119
Assigning an Object to null is a code smell. Consider refactoring. 179
Assigning an Object to null is a code smell. Consider refactoring. 189
Unnecessary use of fully qualified name 'org.andromda.utils.StringUtilsHelper.lowerCamelCaseName' due to existing import 'org.andromda.utils.StringUtilsHelper' 203
Avoid if (x != y) ..; else ..; 279
Local variable 'type' could be declared final 291
The method handleGetDummyValue() has an NPath complexity of 214990849 401 - 506
Avoid really long methods. 401 - 506
The method 'handleGetDummyValue' has a Cyclomatic Complexity of 33. 401 - 506
A method should have only one exit point, and that should be the last statement in the method 410
A method should have only one exit point, and that should be the last statement in the method 414
A method should have only one exit point, and that should be the last statement in the method 418
A method should have only one exit point, and that should be the last statement in the method 422
A method should have only one exit point, and that should be the last statement in the method 426
A method should have only one exit point, and that should be the last statement in the method 430
A method should have only one exit point, and that should be the last statement in the method 434
A method should have only one exit point, and that should be the last statement in the method 438
A method should have only one exit point, and that should be the last statement in the method 442
A method should have only one exit point, and that should be the last statement in the method 446
A method should have only one exit point, and that should be the last statement in the method 450
A method should have only one exit point, and that should be the last statement in the method 454
A method should have only one exit point, and that should be the last statement in the method 458
A method should have only one exit point, and that should be the last statement in the method 462
A method should have only one exit point, and that should be the last statement in the method 466
A method should have only one exit point, and that should be the last statement in the method 470
A method should have only one exit point, and that should be the last statement in the method 474
A method should have only one exit point, and that should be the last statement in the method 478
A method should have only one exit point, and that should be the last statement in the method 482
A method should have only one exit point, and that should be the last statement in the method 486
A method should have only one exit point, and that should be the last statement in the method 490
A method should have only one exit point, and that should be the last statement in the method 496
A method should have only one exit point, and that should be the last statement in the method 500
String.trim().length()==0 is an inefficient way to validate an empty String. 515
Parameter 'validatorType' is not assigned and could be declared final 541
String.trim().length()==0 is an inefficient way to validate an empty String. 626
Local variable 'typeName' could be declared final 655
Prefer StringBuffer over += for concatenating strings 658
A method should have only one exit point, and that should be the last statement in the method 682
Local variable 'it' could be declared final 684
This statement may have some unnecessary parentheses 686
Useless parentheses. 686
A method should have only one exit point, and that should be the last statement in the method 689

org/andromda/cartridges/jsf/metafacades/JSFManageableEntityLogicImpl.java

Violation Line
This class has too many methods, consider refactoring it. 29 - 700
Parameter 'metaObject' is not assigned and could be declared final 35
Parameter 'context' is not assigned and could be declared final 35
Unnecessary use of fully qualified name 'org.andromda.metafacades.uml.ManageableEntityAttribute' due to existing import 'org.andromda.metafacades.uml.ManageableEntityAttribute' 164
Overriding method merely calls super 164 - 167
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 295
Unnecessary wrapper object creation 312
A method should have only one exit point, and that should be the last statement in the method 444
Avoid using if statements without curly braces 501 - 502
Parameter 'element' is not assigned and could be declared final 522
A method should have only one exit point, and that should be the last statement in the method 533
Parameter 'buffer' is not assigned and could be declared final 549
Local variable 'dependency' could be declared final 573
A method should have only one exit point, and that should be the last statement in the method 633
A method should have only one exit point, and that should be the last statement in the method 653
A method should have only one exit point, and that should be the last statement in the method 664

org/andromda/cartridges/jsf/metafacades/JSFParameterLogicImpl.java

Violation Line
Avoid really long classes. 37 - 1302
The class 'JSFParameterLogicImpl' has a Cyclomatic Complexity of 3 (Highest = 34). 37 - 1302
This class has too many methods, consider refactoring it. 39 - 1302
Parameter 'metaObject' is not assigned and could be declared final 46
Parameter 'context' is not assigned and could be declared final 47
Unnecessary wrapper object creation 70
Unnecessary wrapper object creation 138
Local variable 'messageKey' could be declared final 157
Parameter 'hyperlink' is not assigned and could be declared final 196
Deeply nested if..then statements are hard to read 215 - 225
These nested if statements could be combined 220 - 223
Deeply nested if..then statements are hard to read 279 - 287
These nested if statements could be combined 281 - 286
Assigning an Object to null is a code smell. Consider refactoring. 358
Assigning an Object to null is a code smell. Consider refactoring. 368
Avoid if (x != y) ..; else ..; 484
Local variable 'type' could be declared final 496
The String literal "\\{0\\}" appears 4 times in this file; the first occurrence is on line 511 511
Deeply nested if..then statements are hard to read 583 - 588
Deeply nested if..then statements are hard to read 612 - 615
These nested if statements could be combined 612 - 615
Found non-transient, non-static member. Please mark as transient or provide accessors. 627
The method handleGetDummyValue() has an NPath complexity of 810 642 - 738
Avoid if (x != y) ..; else ..; 645
Avoid if (x != y) ..; else ..; 662
Do not use the short type 675
Use bitwise inversion to invert boolean values 822
Use bitwise inversion to invert boolean values 838
Unnecessary wrapper object creation 881
A method should have only one exit point, and that should be the last statement in the method 881
Unnecessary wrapper object creation 930
Use bitwise inversion to invert boolean values 950
Use bitwise inversion to invert boolean values 953
String.trim().length()==0 is an inefficient way to validate an empty String. 1010
These nested if statements could be combined 1075 - 1078
A method should have only one exit point, and that should be the last statement in the method 1130
Local variable 'it' could be declared final 1132
This statement may have some unnecessary parentheses 1134
Useless parentheses. 1134
A method should have only one exit point, and that should be the last statement in the method 1137
Use explicit scoping instead of the default package private level 1145
Use explicit scoping instead of the default package private level 1147
Use explicit scoping instead of the default package private level 1149
Use explicit scoping instead of the default package private level 1151
Use explicit scoping instead of the default package private level 1153
Use explicit scoping instead of the default package private level 1155
Use explicit scoping instead of the default package private level 1157
Use explicit scoping instead of the default package private level 1159
Use explicit scoping instead of the default package private level 1161
Use explicit scoping instead of the default package private level 1163
The method handleGetAnnotations() has an NPath complexity of 255 1170 - 1301
Avoid really long methods. 1170 - 1301
The method 'handleGetAnnotations' has a Cyclomatic Complexity of 34. 1170 - 1301
Local variable 'vt' could be declared final 1174
Avoid variables with short names like vt 1174
This call to String.startsWith can be rewritten using String.charAt(0) 1176
Avoid instantiating new objects inside loops 1191
Avoid variables with short names like sb 1191
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 1197
Avoid appending characters as strings in StringBuffer.append. 1205
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 1207
Avoid appending characters as strings in StringBuffer.append. 1209
Avoid instantiating new objects inside loops 1214
Avoid variables with short names like sb 1214
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 1220
Avoid appending characters as strings in StringBuffer.append. 1228
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 1230
Avoid appending characters as strings in StringBuffer.append. 1232
Avoid variables with short names like sb 1245
Avoid instantiating new objects inside loops 1245
Avoid appending characters as strings in StringBuffer.append. 1255
Avoid appending characters as strings in StringBuffer.append. 1265
Avoid appending characters as strings in StringBuffer.append. 1272

org/andromda/cartridges/jsf/metafacades/JSFPortletPreferencesLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 21
Parameter 'context' is not assigned and could be declared final 21

org/andromda/cartridges/jsf/metafacades/JSFSessionObjectLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 16
Parameter 'context' is not assigned and could be declared final 16

org/andromda/cartridges/jsf/metafacades/JSFUseCaseLogicImpl.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 1 - 952
The class 'JSFUseCaseLogicImpl' has a Cyclomatic Complexity of 3 (Highest = 28). 42 - 952
Parameter 'metaObject' is not assigned and could be declared final 51
Parameter 'context' is not assigned and could be declared final 52
Avoid if (x != y) ..; else ..; 84
Unnecessary wrapper object creation 126
The method handleGetAllMessages() has an NPath complexity of 50440 133 - 411
Avoid really long methods. 133 - 411
The method 'handleGetAllMessages' has a Cyclomatic Complexity of 28. 133 - 411
Avoid instantiating new objects inside loops 176
Deeply nested if..then statements are hard to read 185 - 193
Local variable 'columnName' could be declared final 187
No need to check for null before an instanceof 205
Deeply nested if..then statements are hard to read 277 - 291
Parameter 'messages' is not assigned and could be declared final 420
Parameter 'attributes' is not assigned and could be declared final 420
Parameter 'associationEnds' is not assigned and could be declared final 444
Parameter 'messages' is not assigned and could be declared final 444
Parameter 'messages' is not assigned and could be declared final 457
Avoid reassigning parameters such as 'type' 457
The String literal "unchecked" appears 4 times in this file; the first occurrence is on line 518 518
Avoid if (x != y) ..; else ..; 618
Avoid if (x != y) ..; else ..; 619
Parameter 'object' is not assigned and could be declared final 792
Parameter 'object' is not assigned and could be declared final 804
Parameter 'o' is not assigned and could be declared final 821
Avoid variables with short names like o 821

org/andromda/cartridges/jsf/metafacades/JSFViewLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 36
Parameter 'context' is not assigned and could be declared final 37
Unnecessary wrapper object creation 81
Avoid concatenating nonliterals in a StringBuffer/StringBuilder constructor or append(). 130
Local variable 'parameter' could be declared final 175
Avoid if (x != y) ..; else ..; 336
A method should have only one exit point, and that should be the last statement in the method 404
A method should have only one exit point, and that should be the last statement in the method 414
A method should have only one exit point, and that should be the last statement in the method 422