PMD Results

The following document contains the results of PMD 5.0.2.

Files

org/andromda/cartridges/meta/MetaCartridgeUtils.java

Violation Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 20 - 96
Parameter 'modelElements' is not assigned and could be declared final 27
Found non-transient, non-static member. Please mark as transient or provide accessors. 46
Local variable 'a' could be declared final 63
Avoid variables with short names like a 63
Local variable 'b' could be declared final 64
Avoid variables with short names like b 64
Avoid if (x != y) ..; else ..; 86

org/andromda/cartridges/meta/MetaProfile.java

Violation Line
Variables that are final and static should be all capitals, 'profile' is not all capitals. 18
Avoid excessively long variable names like TAGGEDVALUE_GENERALIZATION_PRECEDENCE 37

org/andromda/cartridges/meta/metafacades/ArgumentData.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 10
Private field 'fullyQualifiedTypeName' could be made final; it is only initialized in the declaration or constructor. 10
Found non-transient, non-static member. Please mark as transient or provide accessors. 11
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 11
Parameter 'nameIn' is not assigned and could be declared final 17
Parameter 'fullyQualifiedTypeNameIn' is not assigned and could be declared final 17

org/andromda/cartridges/meta/metafacades/MetaGlobals.java

Violation Line
Use explicit scoping instead of the default package private level 14 - 15
Avoid excessively long variable names like PROPERTY_IMPLEMENTATION_OPERATION_NAME_PATTERN 14
Avoid excessively long variable names like PROPERTY_GENERALIZATION_NAME_PATTERN 20
Use explicit scoping instead of the default package private level 20

org/andromda/cartridges/meta/metafacades/MetafacadeAssociationEndLogicImpl.java

Violation Line
Parameter 'metaObjectIn' is not assigned and could be declared final 20
Parameter 'context' is not assigned and could be declared final 21

org/andromda/cartridges/meta/metafacades/MetafacadeAttributeLogicImpl.java

Violation Line
Parameter 'metaObjectIn' is not assigned and could be declared final 20
Parameter 'context' is not assigned and could be declared final 21

org/andromda/cartridges/meta/metafacades/MetafacadeGeneralizationLogicImpl.java

Violation Line
Parameter 'metaObjectIn' is not assigned and could be declared final 24
Parameter 'context' is not assigned and could be declared final 25
Local variable 'value' could be declared final 37 - 39
Avoid empty catch blocks 46 - 49
These nested if statements could be combined 63 - 66
Local variable 'child' could be declared final 79
Local variable 'generalizations' could be declared final 84
Useless parentheses. 85
Useless parentheses. 85
Useless parentheses. 100

org/andromda/cartridges/meta/metafacades/MetafacadeLogicImpl.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 47
Avoid using redundant field initializer for 'featureMap' 47
Variables that are final and static should be all capitals, 'logger' is not all capitals. 51
Parameter 'metaObjectIn' is not assigned and could be declared final 58
Parameter 'context' is not assigned and could be declared final 59
Parameter 'classifier' is not assigned and could be declared final 85
Local variable 'dep' could be declared final 87
Local variable 'target' could be declared final 89
Local variable 'stereotypes' could be declared final 90
Useless parentheses. 91
Useless parentheses. 91
Local variable 'stereotypeName' could be declared final 93
A method should have only one exit point, and that should be the last statement in the method 96
Local variable 'superclass' could be declared final 101
Assigning an Object to null is a code smell. Consider refactoring. 102
Avoid if (x != y) ..; else ..; 102
Local variable 'dependencies' could be declared final 112
Useless parentheses. 113
Local variable 'dependency' could be declared final 116
Local variable 'targetElement' could be declared final 119
Deeply nested if..then statements are hard to read 120 - 123
Parameter 'name' is not assigned and could be declared final 217
Local variable 'fullyQualifiedName' could be declared final 219
Line too long 229
Parameter 'facade' is not assigned and could be declared final 232
Local variable 'general' could be declared final 262
Avoid instantiating new objects inside loops 264
Local variable 'features' could be declared final 278
A catch statement should never catch throwable since it includes errors. 293
Avoid throwing raw exception types. 295
Avoid instantiating new objects inside loops 325 - 331
Avoid instantiating new objects inside loops 337 - 343
Local variable 'operation' could be declared final 359
Avoid instantiating new objects inside loops 361
A catch statement should never catch throwable since it includes errors. 375
Useless parentheses. 394
Parameter 'objectA' is not assigned and could be declared final 469
Parameter 'objectB' is not assigned and could be declared final 470
Local variable 'a' could be declared final 472
Avoid variables with short names like a 472
Avoid variables with short names like b 473
Local variable 'b' could be declared final 473
Local variable 'allParents' could be declared final 484
Local variable 'object' could be declared final 487

org/andromda/cartridges/meta/metafacades/MetafacadeOperationLogicImpl.java

Violation Line
Parameter 'metaObjectIn' is not assigned and could be declared final 21
Parameter 'context' is not assigned and could be declared final 22

org/andromda/cartridges/meta/metafacades/MethodData.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 16
Private field 'metafacadeName' could be made final; it is only initialized in the declaration or constructor. 16
Private field 'visibility' could be made final; it is only initialized in the declaration or constructor. 17
Found non-transient, non-static member. Please mark as transient or provide accessors. 17
Field isAbstract has the same name as a method 18
Found non-transient, non-static member. Please mark as transient or provide accessors. 18
Private field 'isAbstract' could be made final; it is only initialized in the declaration or constructor. 18
Private field 'name' could be made final; it is only initialized in the declaration or constructor. 19
Found non-transient, non-static member. Please mark as transient or provide accessors. 19
Private field 'returnTypeName' could be made final; it is only initialized in the declaration or constructor. 20
Found non-transient, non-static member. Please mark as transient or provide accessors. 20
Found non-transient, non-static member. Please mark as transient or provide accessors. 21
Private field 'documentation' could be made final; it is only initialized in the declaration or constructor. 21
Found non-transient, non-static member. Please mark as transient or provide accessors. 22
Found non-transient, non-static member. Please mark as transient or provide accessors. 23
Parameter 'metafacadeNameIn' is not assigned and could be declared final 34
Parameter 'visibilityIn' is not assigned and could be declared final 35
Parameter 'isAbstractIn' is not assigned and could be declared final 36
Parameter 'returnTypeNameIn' is not assigned and could be declared final 37
Parameter 'nameIn' is not assigned and could be declared final 38
Parameter 'documentationIn' is not assigned and could be declared final 39
Parameter 'argument' is not assigned and could be declared final 52
Parameter 'typeName' is not assigned and could be declared final 68
Parameter 'suppressAbstractDeclaration' is not assigned and could be declared final 118
Useless parentheses. 121
Avoid if (x != y) ..; else ..; 122
Useless parentheses. 122
Prefer StringBuffer over += for concatenating strings 124
Prefer StringBuffer over += for concatenating strings 134
Prefer StringBuffer over += for concatenating strings 138
Local variable 'exception' could be declared final 141
Prefer StringBuffer over += for concatenating strings 142
Prefer StringBuffer over += for concatenating strings 145
Parameter 'modifier' is not assigned and could be declared final 169
Prefer StringBuffer over += for concatenating strings 178
Prefer StringBuffer over += for concatenating strings 180
Useless parentheses. 180
Prefer StringBuffer over += for concatenating strings 183
Prefer StringBuffer over += for concatenating strings 201
Prefer StringBuffer over += for concatenating strings 204
Prefer StringBuffer over += for concatenating strings 207
Useless parentheses. 219
Avoid if (x != y) ..; else ..; 219
Prefer StringBuffer over += for concatenating strings 224
Prefer StringBuffer over += for concatenating strings 227
Prefer StringBuffer over += for concatenating strings 230
Local variable 'other' could be declared final 280
Avoid if (x != y) ..; else ..; 284 - 285
Useless parentheses. 284

org/andromda/cartridges/meta/metafacades/PSMmetaclassLogicImpl.java

Violation Line
Line too long 3
Parameter 'metaObjectIn' is not assigned and could be declared final 17
Parameter 'context' is not assigned and could be declared final 17
Local variable 'operation' could be declared final 46

org/andromda/cartridges/meta/metafacades/UMLOperationData.java

Violation Line
Local variable 'parameter' could be declared final 31
Avoid instantiating new objects inside loops 34 - 36