Member ApiQueryAllPagesTest ()

give this test a real name explaining what is being tested here

Class ApiWatchTest

This test suite is severly broken and need a full review

Class Article

Move and rewrite code to an Action class

Member Article$mContent

BC cruft

Member Article ($reason)

FIXME: Move to another file?

Member Article ()

When is this null?

Member Article ($action, $pOutput=null)

actions other than 'view'

Member Article ()

Make protected

Member AtomFeed ($ts)

document

Member BackupDumper ()

Fixme: the --server parameter is currently not respected, as it doesn't seem terribly easy to ask the load balancer for a particular connection by name.

File Benchmarker.php

Report PHP version, OS ..

Class BitmapMetadataHandler

Other image formats.

Member BitmapMetadataHandler ($filename)

Add XMP support, so this function actually makes sense to put here.

Member Block ($address= '', $user=0, $by=0, $reason= '', $timestamp=0, $auto=0, $expiry= '', $anonOnly=0, $createAccount=0, $enableAutoblock=0, $hideName=0, $blockEmail=0, $allowUsertalk=0, $byText= '')

FIXME: Don't know what the best format to have for this constructor is, but fourteen optional parameters certainly isn't it.

Member Block ()

FIXME: This should be an integral part of the Block member variables

Member CacheTime ($id)

We always return false if $this->getCacheRevisionId() is null; this prevents invalidating the whole parser cache when this change is deployed. Someday that should probably be changed.

Class Category

Move some stuff from CategoryPage.php to here, and use that.

Member CategoryFinder ($articleIds, $categories, $mode= 'AND')

FIXME: $categories/$mode

File cdb.php

document

Class ChangesListSpecialPage

Way too many public functions, most of them should be protected

Member ChangesListSpecialPage ($opts)

This should handle options returned by getDefaultOptions().

Not called by anything, should be called by something… doHeader() maybe?

Member ChangesListSpecialPage (IContextSource $context)

This should not be static, then we can drop the parameter

Not called by anything, should be called by doHeader()

Class ChannelFeed

document (needs one-sentence top-level class description).

Class CleanUpTest

covers tags, will be UtfNormal::cleanUp once the below is resolved

split me into test methods and providers per the below comment

Member CleanUpTest ()

document

Member CleanUpTest ()

document

Member CleanUpTest ()

document

Member CleanUpTest ($head, $tail)

document

Member CleanUpTest ()

document

Member CleanUpTest ($head, $tail)

document

Member CleanUpTest ()

document

Member CleanUpTest ()

document

Member CleanUpTest ()

document

Member CleanUpTest ()

document

Member CleanUpTest ()

document

Member CleanUpTest ()

document

Member CleanUpTest ()

document

Member CleanUpTest ()

document

Member CleanUpTest ($head, $tail)

document

Member CleanUpTest ()

document

Member CompressOld ($start=0, $extdb= '')

document

Member CompressOld ($row, $extdb)

document

Member CompressOld

document

Member Content ()

Test that this actually works

Make sure this also works with LuceneSearch / WikiSearch

Member Content ()

Allow native handling, bypassing wikitext representation, like for includable special pages.

Allow transclusion into other content models than Wikitext!

Used in WikiPage and MessageCache to get message text. Not so nice. What should we use instead?!

Member ContentHandler (Title $title, &$hasHistory)

&$hasHistory is extremely ugly, it's here because WikiPage::getAutoDeleteReason() and Article::generateReason() have it / want it.

Member ContribsPager ($row)

This would probably look a lot nicer in a table.

Member ConverterRule ()

FIXME: code this function :)

Member Cookie ($domain, $originDomain=null)

fixme fails to detect 3-letter top-level domains

fixme fails to detect 2-letter top-level domains for single-domain use (probably not a big problem in practice, but there are test cases)

Member CoreTagHooks ($content, $attributes, $parser)

break Parser::renderImageGallery out here too.

Member DatabaseBase ($db)

Explain what exactly will fail if this is not overridden.

Member DatabaseInstaller$parent

Naming this parent is confusing, 'installer' would be clearer.

Member DatabaseMysqlBase (DBMasterPos $pos, $timeout)

Return values for this and base class are rubbish

Member DatabasePostgres ($destTable, $srcTable, $varMap, $conds, $fname=__METHOD__, $insertOptions=array(), $selectOptions=array())

FIXME: Implement this a little better (seperate select/insert)?

Member DatabaseSqlite ()

Check if it should be true like parent class

Member DatabaseSqliteTest ()

Currently only checks list of tables

Class DateFormatter

preferences, OutputPage

Member DateFormatter ()

document

Member DateFormatter ($year)

document

Member DateFormatter ($iso)

document

Member DeletedContribsPager ($row)

This would probably look a lot nicer in a table.

Member DeletedContributionsPage ($userObj)

FIXME: Almost the same as contributionsSub in SpecialContributions.php. Could be combined.

File deleteOrphanedRevisions.php

More efficient cleanup of text records

Class Diff

document

Class DifferenceEngine

document

Member DifferenceEngine ($otext, $ntext)

move this to TextDifferenceEngine, make DifferenceEngine abstract. At some point.

Class DifferenceEngineTest

tests for the rest of DifferenceEngine!

Class DiffFormatter

document

Class DiffOp

document

Class DiffOpAdd

document

Class DiffOpChange

document

Class DiffOpCopy

document

Class DiffOpDelete

document

File dumpMessages.php

Make this more useful, right now just dumps $wgContLang

Member EditPage (&$result, $bot=false)

FIXME: This interface is TERRIBLE, but hard to get rid of due to various error display idiosyncrasies. There are also lots of cases where error metadata is set in the object and retrieved later instead of being returned, e.g. AS_CONTENT_TOO_BIG and AS_BLOCKED_PAGE_FOR_USER. All that stuff needs to be cleaned up some time.

Member EditPage ()

This doesn't include category or interlanguage links. Would need to enhance it a bit, "<s>maybe wrap them in XML or something...</s>" that might also require more skin initialization, so check whether that's a problem.

Member EnhancedChangesList (RCCacheEntry $cacheEntry)

use rc_source to group, if set; fallback to rc_type

Member EnhancedChangesListTest ()

more tests for actual formatting, this is more of a smoke test

Member EnhancedChangesListTest ()

more tests

Class EraseArchivedFile

Maybe add some simple logging

Member Exif ($file, $byteOrder= '')

FIXME: The following are broke: SubjectArea. Need to test the more obscure tags. DigitalZoomRatio = 0/0 is rejected. need to determine if that's valid. Possibly should treat 0/0 = 0. need to read exif spec on that.

Member ExifBitmapHandler ($data)

FIXME: Orientation can include flipping as well; see if this is an issue!

Class ExifRotationTest

covers tags

Member FauxResponse ($name, $value, $expire=0, $options=null)

document.

Class FormOptions

This badly needs some examples and tests :) The usage in SpecialRecentchanges class is a good ersatz in the meantime.

Member GIFHandler ($image)

Add unit tests

Member HistoryPager ($row, $next, $notificationtimestamp=false, $latest=false, $firstInList=false)

document some more, and maybe clean up the code (some params redundant?)

Member Html ($contents)

do some useful escaping as well, like if $contents contains literal "</script>" or (for XML) literal "]]>".

Class HTMLForm

Document 'section' / 'subsection' stuff

Member HTMLForm ($fields, $sectionName= '', $fieldsetIDPrefix= '', &$hasUserVisibleFields=false)

Document

Member HTMLForm ($p)

Currently only used for the "<fieldset>" legend on forms with multiple sections; should be used elsewhere?

Member HTMLForm ($t)

FIXME: Integrity of $t is *not* validated

Class HTMLSelectAndOtherField

FIXME: If made 'required', only the text field should be compulsory.

Member Http ($uri)

FIXME this is wildly inaccurate and fails to actually check most stuff

Class HttpStatus

document

Class HWLDFWordAccumulator

document

File IEContentAnalyzer.php

Define the exact license of this file.

Class IEUrlExtensionTest

tests below for findIE6Extension should be split into...

Member ImagePage ($metadata)

FIXME: Bad interface, see note on MediaHandler::formatMetadata().

Class ImportStreamSource

document (e.g.

Class ImportStringSource

document (e.g.

Member IORMTable ()

Get rid of the id field. Every row instance needs to have one so this is just causing hassle at various locations by requiring an extra check for field name.

Member IPTC ($date, $time, $c)

Potentially this should also capture the timezone offset.

Class IPTest

Test methods in this call should be split into a method and a dataprovider.

Member IPTest ()

Most probably incomplete

Class JavaScriptContentHandler

make ScriptContentHandler base class, do highlighting stuff there?

Member JavaScriptContentTest ()

Test needs database!

Member JavaScriptMinifierTest ($num)

give this test a real name explaining what is being tested here

Class JpegMetadataExtractorTest

Could use a test of extended XMP segments.

Member Language ($text, $isTitle=false)

this should get integrated somewhere sane

Member Language ($expiry, $format=true)

FIXME: why are we returnings DBMS-dependent strings???

Member Language ($number, $nocommafy=false)

check if it's viable to use localeconv() for the decimal separator thing.

Member Language ($seconds, $format=array())

Document

Member Language ($format, $ts, DateTimeZone $zone=null, &$ttl=null)

handling of "o" format character for Iranian, Hebrew, Hijri & Thai?

Member Language ($str)

Maybe translate block durations.

Member LanguageAr ($s)

FIXME: This is language-specific for now only to avoid the negative performance impact of enabling it for all languages.

Member LanguageArTest ()

split into a test and a dataprovider

Member LanguageMl ($s)

FIXME: This is language-specific for now only to avoid the negative performance impact of enabling it for all languages.

Member LanguageNlTest ()

split into a test and a dataprovider

File LanguageSrTest.php

methods in test class should be tidied:

Should be split into separate test methods and data providers
Tests for LanguageConverter and Language should probably be separate..

File LanguageUzTest.php

methods in test class should be tidied:

Should be split into separate test methods and data providers
Tests for LanguageConverter and Language should probably be separate..

Member LanguageYue ($string)

FIXME: Only do this for Han characters...

Member LanguageZh_hans ($string)

FIXME: Only do this for Han characters...

Class Linker

turn this into a legacy interface for HtmlPageLinkRenderer and similar services.

Member Linker ($comment, $title=null, $local=false)

FIXME: Doesn't handle sub-links as in image thumb texts like the main parser

Member Linker (Title $title, $file, $html= '')

Handle invalid or missing images better.

Class LinkFilter

implement the filter. Currently these are just some functions to help maintenance/cleanupSpam.php remove links to a single specified domain. The next thing is to implement functions for checking a given page against a big list of domains.

Member LinkSearchPage (PageLinkRenderer $linkRenderer)

query logic and rendering logic should be split and also injected

Class LinksUpdate

document (e.g. one-sentence top-level class description).

Class LoadBalancer

document

Class LocalFileTest

Split tests into providers and test methods

Member LogPage ($type, $lang, $title, &$params)

Document

Member LogPage ($type)

handle missing log types

File MagicVariableTest.php

covers tags

Member MagicWord ($magicarr, $subject, &$result)

Should this be static? It doesn't seem to be used at all

Member MagicWordArray$matches

Unused?

Class MappedDiff

document, bad name.

File mcc.php

document

Member MediaHandler ($image)

FIXME: This interface is not very flexible.

Member MediaHandlerTest ()

split into a dataprovider and test method

Member MediaWikiTitleCodec ($text, $defaultNamespace=NS_MAIN)

this method is only exposed as a temporary measure to ease refactoring. It was copied with minimal changes from Title::secureAndSplit().

This method should be split up and an appropriate interface defined for use by the Title class.

Class Message

test, can we have tests?
this documentation needs to be extended

Member Message ()

FIXME: Merge with isDisabled()?

Member MimeMagic (Config $config=null)

Make this constructor private once everything uses the singleton instance

Member MimeMagic ($path=null, $mime=null)

analyse file if need be

look at multiple extension, separately and together.

Member MimeMagic ($extension)

Be more accurate when using fancy MIME detector plugins; right now this is the bare minimum getimagesize() list.

Class MWDebug

Profiler support

Member MWDebug ($str)

Add support for passing objects

File mwdocgen.php

document

Member MWHttpRequest ($args)

overload the args param

Class MWNamespaceTest

covers tags

FIXME: this test file is a mess

Member MWNamespaceTest ()

Implement testGetCanonicalNamespaces().

Implement testGetCanonicalName().

Implement testGetCanonicalIndex().

Implement testGetValidNamespaces().

Member MWNamespaceTest ()

Implement testExists().

Member MWNamespaceTest ()

split groups of assertions in autonomous testing functions MWNamespace::isCapitalized

Member MWNamespaceTest ()

Write more texts, handle $wgAllowImageMoving setting MWNamespace::isMovable

File MWTerm.php

Fixme: Make this more generic

Member NamespaceConflictChecker ($fix, $suffix= '')

Document

Member NamespaceConflictChecker ($ns, $name, $fix, $suffix= '')

Document

Member NamespaceConflictChecker ($key, $prefix, $fix, $suffix= '')

Do this for real

Class NewParserTest

covers tags

Member NewParserTest ()

fixme Needs some work to not eat memory until the world explodes

Class OldChangesListTest

add tests to cover article link, timestamp, character difference, log entry, user tool links, direction marks, tags, rollback, watching users, and date header.

Member Orphans ($fix)

DON'T USE THIS YET! It will remove entries which have children, but which aren't properly attached (eg if page_latest is bogus but valid revisions do exist)

Class OutputPage

FIXME: Another class handles sending the whole page to the client.

document

Member OutputPage$mContainsOldMagic

Unused?

Member OutputPage$mLinkColours

Unused?

Member OutputPage$mPreventClickjacking

Document

Member OutputPage$mScripts

We should split JS / CSS.

Member OutputPage ($header, $option=null)

FIXME: Document the $option parameter; it appears to be for X-Vary-Options but what format is acceptable?

Member OutputPage ($modules, $only, $useESI=false, array $extraQuery=array(), $loadCall=false)

Document

Member OutputPage ($source=null, $protected=false, array $reasons=array(), $action=null)

Needs to be split into multiple functions.

Class OutputPageTest

factor tests in this class into providers and test methods

Member PageArchive ()

Does this belong in Image for fuller encapsulation?

Member PageLinkRenderer (TitleValue $page, $params=array())

expand this to cover the functionality of Linker::linkUrl

Member PageLinkRenderer (TitleValue $page, $text=null)

expand this to cover the functionality of Linker::link

Member Parser ($char)

Document

Member Parser (&$text, $options=0)

FIXME: Update documentation.

Member Parser ($tag, $callback)

better document or deprecate this

Class ParserCache

document

Member ParserCache ($article, $popts, $useOutdated=true)

Document parameter $useOutdated

File parserTest.inc

Make this more independent of the configuration (and if possible the database)

document

Member PostgresUpdater ()

FIXME: Postgres should use sequential updates like Mysql, Sqlite and everybody else.

Class ProfilerSimpleTrace

document methods (?)

Class ProtectedPagesPager

document

Class ProtectedTitlesPager

document

Member PurgeChangedPages (ResultWrapper $res, $column, $limit)

move this elsewhere

File rebuildrecentchanges.php

Document

File rebuildtextindex.php

document

Member RecentChangeTest ($expected, $type, $action, $params, $comment=null, $msg= '')

Emulate these edits somehow and extract raw edit summary from RecentChange object --

Class Revision

document

Member Revision ($audience=self::FOR_PUBLIC, User $user=null)

Replace usage in core

Member Revision ($row, $overrides=array())

FIXME: Should be a subclass for RevisionDelete. [TS]

Member Sanitizer ($class)

For extra validity, input should be validated UTF-8.

Member Sanitizer ($a, $b)

implement merging for other attributes such as style

Member Sanitizer ($text)

Remove, unused?

Member Sanitizer ($attribs, $whitelist)

Check for legal values where the DTD limits things.

Check for unique id attribute :P

Member Sanitizer ($attribs, $element)

Check for legal values where the DTD limits things.

Check for unique id attribute :P

Class SanitizerTest

Tests covering decodeCharReferences can be refactored into a single method and dataprovider.

Class SanitizerValidateEmailTest

all test methods in this class should be refactored and...

Member SearchEngine (Title $t, Content $c=null)

This isn't ideal, we'd really like to have content-specific handling here

Class SearchEngineDummy

FIXME: Dummy class should probably try something at least mildly useful, such as a LIKE search through titles.

Member SearchMssql ($filteredText, $fulltext)

document

Class SearchResult

FIXME: This class is horribly factored.

Member SearchUpdateTest ()

give this test a real name explaining what is being tested here

File Setup.php

UGLY UGLY

Member SideBarTest ($expected, $text, $message= '')

this assert method to should be converted to a test using a dataprovider..

Class SiteConfiguration

Give examples for, suffixes: $conf->suffixes = array( 'wiki' ); localVHosts callbacks!

Member Skin (OutputPage $out)

delete

Class SkinTemplate

Needs some serious refactoring into functions that correspond to the computations individual esi snippets need. Most importantly no body parsing for most of those of course.

Member SpecialBlock ($lang=null)

FIXME: This uses a rather odd syntax for the options, should it be converted to the standard "**<duration>|<displayname>" format?

Member SpecialBlock ($par, WebRequest $request=null)

Should be in Block.php?

Class SpecialBookSources

Validate ISBNs using the standard check-digit method

Member SpecialCategories (PageLinkRenderer $linkRenderer)

the pager should also be injected, and de-coupled from the rendering logic.

Member SpecialContributions ($userObj)

FIXME: Almost the same as getSubTitle in SpecialDeletedContributions.php. Could be combined.

Class SpecialCreateAccount

FIXME: This (and the rest of the login frontend) needs to die a horrible painful death

Member SpecialMergeHistory ()

if all versions of page A are moved to B and then a user tries to do a reverse-merge via the "unmerge" log link, then page A will still be a redirect (as it was after the original merge), though it will have the old revisions back from before (as expected). The user may have to "undo" the redirect manually to finish the "unmerge". Maybe this should delete redirects at the target page of merges?

Member SpecialPreferencesTest ()

give this test a real name explaining what is being tested here

Member SpecialRevisionDelete ()

FIXME: Wikimedia-specific policy text

Member SpecialRevisionDelete ($archiveName)

Mostly copied from Special:Undelete. Refactor.

Member SpecialUpload ($comment= '', $license= '', $copyStatus= '', $source= '')

Use Config obj instead of globals

Member SpecialUpload ()

What about non-BitmapHandler handled files?

Member SpecialUploadStash ($contentType, $size)

Unsure about encoding as binary; if we received from HTTP perhaps we should use that encoding, concatenated with semicolon to `$contentType` as it usually is.

File SpecialWhatlinkshere.php

Use some variant of Pager or something; the pagination here is lousy.

Member StatusTest (Status $status, $wikitext, $html)

test long and short context messages generated through this method this can not really be done now due to use of $this->getWikiText using wfMessage()->plain().

Member StatusTest (Status $status, $expectedParams=array(), $expectedKey)

test long and short context messages generated through this method

Member StatusTest (Status $status, $wikitext, $html)

test long and short context messages generated through this method this can not really be done now due to use of wfMessage()->plain() It is possible to mock such methods but only if namespaces are used

Class StripState

document, briefly.

Class TableDiffFormatter

document

Member TextContentTest ()

Test needs database! Should be done by a test class in the Database group.

Member Title ()

check if needed (used only in SpecialBrokenRedirects.php, and should use redirect table in this case).

Member Title ()

move this into MediaWikiTitleCodec

Member Title ($action, $user, $doExpensiveQueries=true, $ignoreErrors=array())

FIXME: This *does not* check throttles (User::pingLimiter()).

Member Title (&$nt, $auth=true, $reason= '')

move this into MovePage

Member Title (&$nt, $auth=true, $reason= '', $createRedirect=true)

Deprecate this in favor of MovePage

Member TitleFormatter ($namespace, $text)

Move this to a separate interface

Member TitlePermissionTest ()