PMD Results

The following document contains the results of PMD 5.0.2.

Files

org/andromda/cartridges/spring/SpringHibernateUtils.java

Violation Line
Found non-transient, non-static member. Please mark as transient or provide accessors. 21
Parameter 'entities' is not assigned and could be declared final 59
Local variable 'base' could be declared final 61
Local variable 'packages' could be declared final 62
Local variable 'entity' could be declared final 64
Local variable 'packageName' could be declared final 66
Parameter 'hibernateVersionPropertyValue' is not assigned and could be declared final 166
Parameter 'hibernateVersionPropertyValue' is not assigned and could be declared final 175
Parameter 'hibernateVersionPropertyValue' is not assigned and could be declared final 184
Found non-transient, non-static member. Please mark as transient or provide accessors. 192
Parameter 'hibernateVersionPropertyValue' is not assigned and could be declared final 219
Parameter 'hibernateXMLPersistencePropertyValue' is not assigned and could be declared final 220
Avoid excessively long variable names like hibernateXMLPersistencePropertyValue 220
Found non-transient, non-static member. Please mark as transient or provide accessors. 226
Parameter 'hibernateMappingStrategyIn' is not assigned and could be declared final 231
Parameter 'hibernateMappingStrategyIn' is not assigned and could be declared final 249

org/andromda/cartridges/spring/SpringProfile.java

Violation Line
Avoid excessively long variable names like STEREOTYPE_POST_CONSTRUCT_METHOD 25
Avoid excessively long variable names like TAGGEDVALUE_EJB_TRANSACTION_TYPE 67
Avoid excessively long variable names like TAGGEDVALUE_HIBERNATE_CRITERIA_NULLABLE 82
Avoid excessively long variable names like TAGGEDVALUE_HIBERNATE_CRITERIA_ATTRIBUTE 87
Avoid excessively long variable names like TAGGEDVALUE_HIBERNATE_CRITERIA_COMPARATOR 92
Avoid excessively long variable names like TAGGEDVALUE_HIBERNATE_CRITERIA_MATCHMODE 97
Avoid excessively long variable names like TAGGEDVALUE_HIBERNATE_CRITERIA_ORDER_DIRECTION 102
Avoid excessively long variable names like TAGGEDVALUE_HIBERNATE_CRITERIA_ORDER_RELEVANCE 108
Avoid excessively long variable names like TAGGEDVALUE_HIBERNATE_CRITERIA_COMPARATOR_IGNORE_CASE 114
Avoid excessively long variable names like TAGGEDVALUE_HIBERNATE_INHERITANCE 125
Avoid excessively long variable names like TAGGEDVALUE_HIBERNATE_USE_NAMED_PARAMETERS 130
Avoid excessively long variable names like TAGGEDVALUE_SPRING_SERVICE_REMOTING_TYPE 136
Avoid excessively long variable names like TAGGEDVALUE_SPRING_SERVICE_REMOTE_PORT 141
Avoid excessively long variable names like TAGGEDVALUE_SPRING_SERVICE_INTERCEPTORS 146
Avoid excessively long variable names like TAGGEDVALUEVALUE_ACTIVEMQ_OPTIMIZE_ACKNOWLEDGE 161
Avoid excessively long variable names like TAGGEDVALUEVALUE_MESSAGING_SESSION_ACKNOWLEDGE_MODE 166
Avoid excessively long variable names like TAGGEDVALUEVALUE_COMPARATOR_LIKE 173
Avoid excessively long variable names like TAGGEDVALUEVALUE_INSENSITIVE_LIKE_COMPARATOR 178
Avoid excessively long variable names like TAGGEDVALUEVALUE_COMPARATOR_EQUAL 184
Avoid excessively long variable names like TAGGEDVALUEVALUE_COMPARATOR_GREATER_OR_EQUAL 189
Avoid excessively long variable names like TAGGEDVALUEVALUE_COMPARATOR_GREATER 195
Avoid excessively long variable names like TAGGEDVALUEVALUE_COMPARATOR_LESS_OR_EQUAL 200
Avoid excessively long variable names like TAGGEDVALUEVALUE_COMPARATOR_LESS 205
Avoid excessively long variable names like TAGGEDVALUEVALUE_COMPARATOR_NOT_EQUAL 215
Avoid excessively long variable names like TAGGEDVALUEVALUE_MATCHMODE_ANYWHERE 221
Avoid excessively long variable names like TAGGEDVALUEVALUE_MATCHMODE_EXACT 233
Avoid excessively long variable names like TAGGEDVALUEVALUE_MATCHMODE_START 239
Avoid excessively long variable names like TAGGEDVALUEVALUE_ORDER_ASCENDING 244
Avoid excessively long variable names like TAGGEDVALUEVALUE_ORDER_DESCENDING 249

org/andromda/cartridges/spring/SpringUtils.java

Violation Line
Avoid unused imports such as 'org.andromda.metafacades.uml.EnumerationLiteralFacade' 19
Avoid unused imports such as 'org.andromda.metafacades.uml.EnumerationLiteralFacade' 19
The class 'SpringUtils' has a Cyclomatic Complexity of 5 (Highest = 32). 38 - 802
Variables that are final and static should be all capitals, 'logger' is not all capitals. 43
Parameter 'services' is not assigned and could be declared final 51
Parameter 'object' is not assigned and could be declared final 58
Use bitwise inversion to invert boolean values 248
Local variable 'position' could be declared final 289
Avoid using redundant field initializer for 'richClient' 301
Parameter 'fullyQualifiedName' is not assigned and could be declared final 327
Local variable 'lastDot' could be declared final 332
Parameter 'fullyQualifiedName' is not assigned and could be declared final 356
Local variable 'lastDot' could be declared final 361
Useless parentheses. 362
Parameter 'modelElements' is not assigned and could be declared final 381
Avoid reassigning parameters such as 'value' 407
These nested if statements could be combined 411 - 414
Local variable 'results' could be declared final 461
Local variable 'literals' could be declared final 465
Local variable 'results' could be declared final 482
Prefer StringBuffer over += for concatenating strings 494
Prefer StringBuffer over += for concatenating strings 497
Prefer StringBuffer over += for concatenating strings 501
Local variable 'attr' could be declared final 504
The String literal "Test" appears 5 times in this file; the first occurrence is on line 534 534
The method getRooEntity() has an NPath complexity of 3168 543 - 643
Parameter 'recordType' is not assigned and could be declared final 543
Avoid really long methods. 543 - 643
Local variable 'results' could be declared final 545
Local variable 'identifiers' could be declared final 546
Local variable 'associationEnd' could be declared final 554
Local variable 'identifier' could be declared final 563
Avoid variables with short names like id 577
Local variable 'id' could be declared final 577
Line too long 579
Local variable 'type' could be declared final 582
Avoid empty if statements 593 - 595
Position literals first in String comparisons 599
Local variable 'general' could be declared final 609
Local variable 'entityVersion' could be declared final 625
Local variable 'attr' could be declared final 626
Local variable 'line' could be declared final 640
Avoid really long methods. 650 - 776
The method getRooField() has an NPath complexity of 1896 650 - 776
The method 'getRooField' has a Cyclomatic Complexity of 32. 650 - 776
Local variable 'end' could be declared final 655
Local variable 'type' could be declared final 656
Local variable 'typeName' could be declared final 657
Prefer StringBuffer over += for concatenating strings 660
Prefer StringBuffer over += for concatenating strings 664
Prefer StringBuffer over += for concatenating strings 668
Prefer StringBuffer over += for concatenating strings 675
Local variable 'attribute' could be declared final 684
Local variable 'type' could be declared final 685
Local variable 'typeName' could be declared final 686
Line too long 687
Prefer StringBuffer over += for concatenating strings 691
Prefer StringBuffer over += for concatenating strings 708
Prefer StringBuffer over += for concatenating strings 712
Prefer StringBuffer over += for concatenating strings 716
Prefer StringBuffer over += for concatenating strings 720
Prefer StringBuffer over += for concatenating strings 725
Prefer StringBuffer over += for concatenating strings 729
Prefer StringBuffer over += for concatenating strings 733
Prefer StringBuffer over += for concatenating strings 737
Prefer StringBuffer over += for concatenating strings 741
Local variable 'column' could be declared final 745
Prefer StringBuffer over += for concatenating strings 748
Avoid empty if statements 752 - 754
Local variable 'lower' could be declared final 755
Prefer StringBuffer over += for concatenating strings 758
Local variable 'comment' could be declared final 760
Prefer StringBuffer over += for concatenating strings 763
Avoid throwing raw exception types. 769
Avoid variables with short names like DF 777
When instantiating a SimpleDateFormat object, specify a Locale 777
Parameter 'format' is not assigned and could be declared final 784
Static DateFormatter objects should be accessed in a synchronized manner 790
Static DateFormatter objects should be accessed in a synchronized manner 800

org/andromda/cartridges/spring/metafacades/SpringCriteriaAttributeLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 24
Parameter 'context' is not assigned and could be declared final 25
Local variable 'value' could be declared final 40
Local variable 'value' could be declared final 56
Local variable 'comparator' could be declared final 79
Local variable 'value' could be declared final 130 - 131
Local variable 'value' could be declared final 145
Local variable 'matchMode' could be declared final 158
Local variable 'value' could be declared final 207 - 209
Local variable 'value' could be declared final 235 - 237
Avoid empty catch blocks 244 - 246
Avoid excessively long variable names like HIBERNATE_CRITERIA_QUERY_IGNORE_CASE 254
Line too long 256
Unnecessary wrapper object creation 267

org/andromda/cartridges/spring/metafacades/SpringCriteriaSearchLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 21
Parameter 'context' is not assigned and could be declared final 21
Parameter 'follow' is not assigned and could be declared final 31
Local variable 'arguments' could be declared final 33
Local variable 'parameter' could be declared final 34

org/andromda/cartridges/spring/metafacades/SpringDependencyLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 31
Parameter 'context' is not assigned and could be declared final 32
Avoid excessively long variable names like TRANSFORMATION_ANONYMOUS_NAME_SUFFIX 58
Parameter 'object' is not assigned and could be declared final 86
Local variable 'dependency' could be declared final 88
Local variable 'element' could be declared final 110
Line too long 151
Avoid excessively long variable names like TRANSFORMATION_TO_ENTITY_METHOD_NAME_SUFFIX 221
Avoid excessively long variable names like VALUE_OBJECT_TO_ENTITY_TRANSFORMER_SUFFIX 235

org/andromda/cartridges/spring/metafacades/SpringEntityLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 38
Parameter 'context' is not assigned and could be declared final 39
The String literal "\\{0\\}" appears 4 times in this file; the first occurrence is on line 84 84
Parameter 'targetSuffix' is not assigned and could be declared final 199
Local variable 'beanNameBuffer' could be declared final 202
Local variable 'finders' could be declared final 265
Local variable 'operations' could be declared final 266
Local variable 'nonFinders' could be declared final 268
Parameter 'object' is not assigned and could be declared final 272
Parameter 'follow' is not assigned and could be declared final 295
Parameter 'object' is not assigned and could be declared final 310
Local variable 'targetElement' could be declared final 313
Local variable 'element' could be declared final 316
Avoid excessively long variable names like NO_TRANSFORMATION_CONSTANT_SUFFIX 346
Parameter 'inheritance' is not assigned and could be declared final 362
Local variable 'superEntity' could be declared final 415
Avoid if (x != y) ..; else ..; 419
Prefer StringBuffer over += for concatenating strings 419
Parameter 'entity' is not assigned and could be declared final 444
Local variable 'value' could be declared final 449
Useless parentheses. 471
Local variable 'abstractConcreteEntity' could be declared final 481 - 482
Useless parentheses. 485
Local variable 'richClient' could be declared final 534 - 535
Parameter 'attributeName' is not assigned and could be declared final 545

org/andromda/cartridges/spring/metafacades/SpringEntityOperationLogicImpl.java

Violation Line
Parameter 'context' is not assigned and could be declared final 26
Parameter 'metaObject' is not assigned and could be declared final 26
Parameter 'replacement' is not assigned and could be declared final 65
Local variable 'arguments' could be declared final 77
Local variable 'parameter' could be declared final 78

org/andromda/cartridges/spring/metafacades/SpringGlobals.java

Violation Line
Avoid excessively long variable names like HIBERNATE_MAPPING_STRATEGY_SUBCLASS 19
Avoid excessively long variable names like HIBERNATE_MAPPING_STRATEGY_HIERARCHY 24
Use explicit scoping instead of the default package private level 29
Use explicit scoping instead of the default package private level 34
Use explicit scoping instead of the default package private level 39
Use explicit scoping instead of the default package private level 44
Use explicit scoping instead of the default package private level 49
Use explicit scoping instead of the default package private level 54
Use explicit scoping instead of the default package private level 59
Avoid excessively long variable names like TRANSFORMATION_TO_COLLECTION_METHOD_SUFFIX 64
Use explicit scoping instead of the default package private level 64
Use explicit scoping instead of the default package private level 69
Avoid excessively long variable names like TRANSFORMATION_TO_ARRAY_METHOD_SUFFIX 69
Use explicit scoping instead of the default package private level 74
Use explicit scoping instead of the default package private level 79
Avoid excessively long variable names like IMPLEMENTATION_OPERATION_NAME_PATTERN 79
Use explicit scoping instead of the default package private level 84
Avoid excessively long variable names like IMPLEMENTATION_PACKAGE_NAME_PATTERN 84
Use explicit scoping instead of the default package private level 89
Use explicit scoping instead of the default package private level 94
Use explicit scoping instead of the default package private level 99
Use explicit scoping instead of the default package private level 104
Avoid excessively long variable names like WEBSERVICE_OUTGOING_ATTACHMENT_HANDLER_CALL_PATTERN 109
Use explicit scoping instead of the default package private level 109
Use explicit scoping instead of the default package private level 114
Avoid excessively long variable names like WEBSERVICE_INCOMING_ATTACHMENT_HANDLER_CALL_PATTERN 114
Use explicit scoping instead of the default package private level 119
Use explicit scoping instead of the default package private level 124
Use explicit scoping instead of the default package private level 129
Use explicit scoping instead of the default package private level 134
Use explicit scoping instead of the default package private level 139
Use explicit scoping instead of the default package private level 144
Use explicit scoping instead of the default package private level 149
Avoid excessively long variable names like DEFAULT_SERVICE_EXCEPTION_NAME_PATTERN 159
Use explicit scoping instead of the default package private level 159
Use explicit scoping instead of the default package private level 164
Avoid excessively long variable names like JMS_DESTINATION_TEMPLATE_PATTERN 169
Use explicit scoping instead of the default package private level 169
Use explicit scoping instead of the default package private level 174
Use explicit scoping instead of the default package private level 179
Use explicit scoping instead of the default package private level 184
Use explicit scoping instead of the default package private level 189
Use explicit scoping instead of the default package private level 194
Use explicit scoping instead of the default package private level 199
Use explicit scoping instead of the default package private level 204
Use explicit scoping instead of the default package private level 209
Use explicit scoping instead of the default package private level 220
Avoid excessively long variable names like HIBERNATE_XML_PERSISTENCE_ID_AS_ATTRIBUTE 220

org/andromda/cartridges/spring/metafacades/SpringManageableEntityAssociationEndLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 21
Parameter 'context' is not assigned and could be declared final 21

org/andromda/cartridges/spring/metafacades/SpringManageableEntityAttributeLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 18
Parameter 'context' is not assigned and could be declared final 18

org/andromda/cartridges/spring/metafacades/SpringManageableEntityLogicImpl.java

Violation Line
Parameter 'context' is not assigned and could be declared final 27
Parameter 'metaObject' is not assigned and could be declared final 27
Line too long 81
Line too long 105
Line too long 137
Line too long 161
Local variable 'propertyPrefix' could be declared final 215
Avoid empty if statements 218 - 220
Parameter 'object' is not assigned and could be declared final 347
Parameter 'object' is not assigned and could be declared final 371
Parameter 'operation' is not assigned and could be declared final 389
Useless parentheses. 391

org/andromda/cartridges/spring/metafacades/SpringMetafacadeUtils.java

Violation Line
All methods are static. Consider using Singleton instead. Alternatively, you could add a private constructor or make the class abstract to silence this warning. 22 - 206
Use explicit scoping instead of the default package private level 32 - 45
Parameter 'name' is not assigned and could be declared final 32
Parameter 'packageName' is not assigned and could be declared final 32
Parameter 'suffix' is not assigned and could be declared final 32
Local variable 'fullyQualifiedName' could be declared final 34
Use explicit scoping instead of the default package private level 55 - 58
Parameter 'packageName' is not assigned and could be declared final 55
Parameter 'name' is not assigned and could be declared final 55
Parameter 'defaultServiceRemotingType' is not assigned and could be declared final 67
Parameter 'classifier' is not assigned and could be declared final 67
Use explicit scoping instead of the default package private level 67 - 97
Local variable 'remotingTypeValue' could be declared final 73 - 74
Parameter 'object' is not assigned and could be declared final 80
Use explicit scoping instead of the default package private level 109 - 141
Parameter 'classifier' is not assigned and could be declared final 109
Parameter 'defaultInterceptors' is not assigned and could be declared final 110
Parameter 'object' is not assigned and could be declared final 123
Use explicit scoping instead of the default package private level 151 - 181
Parameter 'defaultRemoteServicePort' is not assigned and could be declared final 151
Parameter 'classifier' is not assigned and could be declared final 151
Local variable 'remoteServicePortValue' could be declared final 157 - 158
Parameter 'object' is not assigned and could be declared final 164
Parameter 'operation' is not assigned and could be declared final 190
Use explicit scoping instead of the default package private level 190 - 205
Parameter 'defaultUseNamedParameters' is not assigned and could be declared final 191
Local variable 'useNamedParametersValue' could be declared final 197 - 198
Unnecessary wrapper object creation 201

org/andromda/cartridges/spring/metafacades/SpringQueryOperationLogicImpl.java

Violation Line
Parameter 'context' is not assigned and could be declared final 30
Parameter 'metaObject' is not assigned and could be declared final 30
Found non-transient, non-static member. Please mark as transient or provide accessors. 47
Avoid using redundant field initializer for 'translatedQuery' 47
Unnecessary wrapper object creation 72
Local variable 'useNamedParameters' could be declared final 72 - 74
Line too long 110
Parameter 'entity' is not assigned and could be declared final 112
Local variable 'value' could be declared final 121
Local variable 'variableName' could be declared final 146
Prefer StringBuffer over += for concatenating strings 150
Local variable 'arguments' could be declared final 151
Local variable 'iterator' could be declared final 152
Deeply nested if..then statements are hard to read 166 - 169
Prefer StringBuffer over += for concatenating strings 170
Deeply nested if..then statements are hard to read 171 - 174
Prefer StringBuffer over += for concatenating strings 173
Deeply nested if..then statements are hard to read 180 - 183
Prefer StringBuffer over += for concatenating strings 184
Deeply nested if..then statements are hard to read 185 - 188
Prefer StringBuffer over += for concatenating strings 187

org/andromda/cartridges/spring/metafacades/SpringQueueLogicImpl.java

Violation Line
Parameter 'context' is not assigned and could be declared final 21
Parameter 'metaObject' is not assigned and could be declared final 21

org/andromda/cartridges/spring/metafacades/SpringServiceLogicImpl.java

Violation Line
This class has too many methods, consider refactoring it. 29 - 793
Parameter 'context' is not assigned and could be declared final 37
Parameter 'metaObject' is not assigned and could be declared final 37
Local variable 'jndiName' could be declared final 48
Local variable 'jndiNamePrefix' could be declared final 49
Local variable 'jndiName' could be declared final 66
Local variable 'jndiNamePrefix' could be declared final 67
Useless parentheses. 77
Assigning an Object to null is a code smell. Consider refactoring. 77
Assigning an Object to null is a code smell. Consider refactoring. 135
Useless parentheses. 135
Parameter 'targetSuffix' is not assigned and could be declared final 254
Local variable 'beanName' could be declared final 256
Assigning an Object to null is a code smell. Consider refactoring. 283
Use bitwise inversion to invert boolean values 316
Local variable 'serviceInterceptorString' could be declared final 326 - 328
Assigning an Object to null is a code smell. Consider refactoring. 328
Local variable 'serviceRemotePort' could be declared final 370 - 371
Local variable 'propertyPrefix' could be declared final 414
Avoid empty if statements 417 - 419
Prefer StringBuffer over += for concatenating strings 428
Prefer StringBuffer over += for concatenating strings 434
Prefer StringBuffer over += for concatenating strings 438
Prefer StringBuffer over += for concatenating strings 443
Prefer StringBuffer over += for concatenating strings 453
Prefer StringBuffer over += for concatenating strings 457
Parameter 'object' is not assigned and could be declared final 474
Avoid instantiating new objects inside loops 501 - 510
Parameter 'object' is not assigned and could be declared final 503
Local variable 'name' could be declared final 523 - 524
Unnecessary wrapper object creation 554
Unnecessary wrapper object creation 623
Useless parentheses. 657 - 658
Useless parentheses. 667 - 668
Local variable 'value' could be declared final 697
Local variable 'value' could be declared final 706
Local variable 'operation' could be declared final 766
Local variable 'operation' could be declared final 783

org/andromda/cartridges/spring/metafacades/SpringServiceOperationLogicImpl.java

Violation Line
Parameter 'context' is not assigned and could be declared final 31
Parameter 'metaObject' is not assigned and could be declared final 31
Parameter 'modifier' is not assigned and could be declared final 101
Parameter 'replacement' is not assigned and could be declared final 161
Avoid excessively long variable names like SERVICE_OPERATION_TRANSACTION_TYPE 170
Avoid excessively long variable names like EJB_SERVICE_OPERATION_TRANSACTION_TYPE 193
Avoid if (x != y) ..; else ..; 228
Parameter 'initialExceptions' is not assigned and could be declared final 236
Avoid if (x != y) ..; else ..; 239 - 247
Parameter 'firstArgument' is not assigned and could be declared final 260
Useless parentheses. 266
Parameter 'modifier' is not assigned and could be declared final 302
Useless parentheses. 326
Local variable 'name' could be declared final 388
Avoid excessively long variable names like MESSAGE_LISTENER_CONTAINER_SUFFIX 429
Local variable 'value' could be declared final 450
Local variable 'arguments' could be declared final 476
Local variable 'parameter' could be declared final 479
Local variable 'parameterType' could be declared final 480
Local variable 'jmsMessageTypes' could be declared final 482

org/andromda/cartridges/spring/metafacades/SpringTopicLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 21
Parameter 'context' is not assigned and could be declared final 21