PMD Results

The following document contains the results of PMD 5.0.2.

Files

org/andromda/cartridges/webservice/WebServiceGlobals.java

Violation Line
Line too long 37
Line too long 57
Line too long 58
Line too long 70
Line too long 75
Line too long 80
Line too long 85
Line too long 110

org/andromda/cartridges/webservice/WebServiceUtils.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 1 - 2727
Avoid really long classes. 55 - 2727
The class 'WebServiceUtils' has a Cyclomatic Complexity of 23 (Highest = 115). 55 - 2727
Variables that are final and static should be all capitals, 'logger' is not all capitals. 60
Parameter 'services' is not assigned and could be declared final 68
Parameter 'object' is not assigned and could be declared final 73
Parameter 'types' is not assigned and could be declared final 98
Parameter 'service' is not assigned and could be declared final 98
Parameter 'follow' is not assigned and could be declared final 98
Parameter 'pkg' is not assigned and could be declared final 109
Parameter 'pkgAbbr' is not assigned and could be declared final 109
Parameter 'pkg' is not assigned and could be declared final 134
The method getPkgAbbr() has an NPath complexity of 1296 145 - 192
Parameter 'currentPackage' is not assigned and could be declared final 145
Parameter 'pkg' is not assigned and could be declared final 145
A method should have only one exit point, and that should be the last statement in the method 150
A method should have only one exit point, and that should be the last statement in the method 154
Local variable 'pkgName' could be declared final 161
Local variable 'namespaceCount' could be declared final 178
Parameter 'service' is not assigned and could be declared final 201
The method setPkgAbbr() has an NPath complexity of 6739360 201 - 568
Parameter 'types' is not assigned and could be declared final 201
The method 'setPkgAbbr' has a Cyclomatic Complexity of 95. 201 - 568
Avoid really long methods. 201 - 568
The method setPkgAbbr() has an NCSS line count of 188 201 - 568
Parameter 'follow' is not assigned and could be declared final 201
Local variable 'pkgSet' could be declared final 204
The String literal " ns" appears 16 times in this file; the first occurrence is on line 223 223
Avoid variables with short names like op 229
Deeply nested if..then statements are hard to read 283 - 286
Avoid if (x != y) ..; else ..; 295 - 565
Local variable 'attr' could be declared final 306
Local variable 'attrType' could be declared final 310
Deeply nested if..then statements are hard to read 317 - 320
Deeply nested if..then statements are hard to read 321 - 329
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 333
The String literal "setPkgAbbr error in service " appears 5 times in this file; the first occurrence is on line 335 335
Local variable 'otherEnd' could be declared final 338
Local variable 'endType' could be declared final 342
Deeply nested if..then statements are hard to read 349 - 352
Deeply nested if..then statements are hard to read 353 - 361
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 365
Line too long 386
Local variable 'attr' could be declared final 390
Local variable 'attrType' could be declared final 394
Deeply nested if..then statements are hard to read 401 - 404
Deeply nested if..then statements are hard to read 405 - 413
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 417
Local variable 'otherEnd' could be declared final 422
Local variable 'endType' could be declared final 426
Deeply nested if..then statements are hard to read 433 - 436
Deeply nested if..then statements are hard to read 437 - 445
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 449
No need to check for null before an instanceof 467
Local variable 'typeLogic' could be declared final 469
Deeply nested if..then statements are hard to read 481 - 484
Local variable 'otherEnd' could be declared final 497
Local variable 'endType' could be declared final 501
Deeply nested if..then statements are hard to read 508 - 511
Deeply nested if..then statements are hard to read 512 - 520
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 524
Avoid empty if statements 558 - 560
Line too long 572
Parameter 'service' is not assigned and could be declared final 579
Avoid really long methods. 579 - 942
Parameter 'types' is not assigned and could be declared final 579
The method getPackageReferences() has an NCSS line count of 197 579 - 942
Parameter 'follow' is not assigned and could be declared final 579
The method 'getPackageReferences' has a Cyclomatic Complexity of 115. 579 - 942
The method getPackageReferences() has an NPath complexity of 9389300 579 - 942
Parameter 'packageName' is not assigned and could be declared final 579
Local variable 'pkgRef' could be declared final 581
Avoid if (x != y) ..; else ..; 593 - 850
Local variable 'generalization' could be declared final 605
Prefer StringBuffer over += for concatenating strings 614
The String literal "getPackageReferences packageName=" appears 33 times in this file; the first occurrence is on line 615 615
The String literal " add facadeAttribute " appears 6 times in this file; the first occurrence is on line 615 615
Local variable 'attr' could be declared final 619
Local variable 'attrType' could be declared final 623
Prefer StringBuffer over += for concatenating strings 633
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 639
Local variable 'otherEnd' could be declared final 650
Prefer StringBuffer over += for concatenating strings 658
The String literal " add facadeOtherEnd " appears 4 times in this file; the first occurrence is on line 659 659
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 664
Local variable 'attr' could be declared final 687
Local variable 'attrType' could be declared final 691
Prefer StringBuffer over += for concatenating strings 702
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 707
Local variable 'endFacade' could be declared final 716
Local variable 'otherEnd' could be declared final 719
Prefer StringBuffer over += for concatenating strings 727
The String literal " add otherEnd " appears 6 times in this file; the first occurrence is on line 728 728
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 733
No need to check for null before an instanceof 756
Local variable 'typeLogic' could be declared final 758
Prefer StringBuffer over += for concatenating strings 770
Local variable 'endFacade' could be declared final 787
Local variable 'otherEnd' could be declared final 790
Prefer StringBuffer over += for concatenating strings 798
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 804
Local variable 'attr' could be declared final 822
Local variable 'attrType' could be declared final 824
Prefer StringBuffer over += for concatenating strings 835
Avoid empty if statements 843 - 845
Local variable 'op' could be declared final 856
Avoid variables with short names like op 856
Local variable 'opit' could be declared final 858
Local variable 'arg' could be declared final 862
Local variable 'type' could be declared final 872
Local variable 'fault' could be declared final 876
Assigning an Object to null is a code smell. Consider refactoring. 883
Prefer StringBuffer over += for concatenating strings 890
Prefer StringBuffer over += for concatenating strings 904
The String literal " add parameter " appears 5 times in this file; the first occurrence is on line 905 905
Prefer StringBuffer over += for concatenating strings 922
Parameter 'packageFacade' is not assigned and could be declared final 950
Local variable 'pkgRef' could be declared final 952
Local variable 'name' could be declared final 955
Local variable 'packageName' could be declared final 957
Avoid variables with short names like op 970
Parameter 'follow' is not assigned and could be declared final 1001
The method 'getPackageReferences' has a Cyclomatic Complexity of 52. 1001 - 1159
Parameter 'packageFacade' is not assigned and could be declared final 1001
Avoid really long methods. 1001 - 1159
The method getPackageReferences() has an NPath complexity of 10302 1001 - 1159
Local variable 'pkgRef' could be declared final 1003
Avoid if (x != y) ..; else ..; 1004 - 1157
Local variable 'packageName' could be declared final 1008
Local variable 'generalization' could be declared final 1023
Prefer StringBuffer over += for concatenating strings 1032
Local variable 'attr' could be declared final 1040
Local variable 'attrType' could be declared final 1044
Prefer StringBuffer over += for concatenating strings 1054
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1060
Local variable 'otherEnd' could be declared final 1071
Prefer StringBuffer over += for concatenating strings 1079
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1085
Avoid variables with short names like op 1094
Prefer StringBuffer over += for concatenating strings 1105
Prefer StringBuffer over += for concatenating strings 1119
Prefer StringBuffer over += for concatenating strings 1133
Parameter 'packageFacade' is not assigned and could be declared final 1166
Local variable 'operations' could be declared final 1168
No need to check for null before an instanceof 1171
Local variable 'facade' could be declared final 1173
Local variable 'webService' could be declared final 1174
Avoid variables with short names like op 1175
Local variable 'visibility' could be declared final 1177
Parameter 'packageFacade' is not assigned and could be declared final 1197
Line too long 1212
The method getPackageTypes() has an NPath complexity of 5228 1217 - 1353
The method 'getPackageTypes' has a Cyclomatic Complexity of 43. 1217 - 1353
Avoid really long methods. 1217 - 1353
Parameter 'follow' is not assigned and could be declared final 1217
Parameter 'packageFacade' is not assigned and could be declared final 1217
Local variable 'pkgTypes' could be declared final 1219
Avoid if (x != y) ..; else ..; 1220 - 1351
Local variable 'packageName' could be declared final 1224
The String literal "getPackageTypes packageName=" appears 31 times in this file; the first occurrence is on line 1,232 1232
No need to check for null before an instanceof 1234
Local variable 'facade' could be declared final 1236
Prefer StringBuffer over += for concatenating strings 1250
Prefer StringBuffer over += for concatenating strings 1263
Prefer StringBuffer over += for concatenating strings 1277
Avoid variables with short names like op 1285
Prefer StringBuffer over += for concatenating strings 1296
Prefer StringBuffer over += for concatenating strings 1313
Prefer StringBuffer over += for concatenating strings 1331
Line too long 1357
Parameter 'follow' is not assigned and could be declared final 1364
Parameter 'service' is not assigned and could be declared final 1364
The method getPackageTypes() has an NPath complexity of 45248386 1364 - 1668
Parameter 'packageName' is not assigned and could be declared final 1364
The method 'getPackageTypes' has a Cyclomatic Complexity of 91. 1364 - 1668
Parameter 'types' is not assigned and could be declared final 1364
Avoid really long methods. 1364 - 1668
The method getPackageTypes() has an NCSS line count of 159 1364 - 1668
Local variable 'pkgTypes' could be declared final 1366
Prefer StringBuffer over += for concatenating strings 1390
These nested if statements could be combined 1414 - 1417
Prefer StringBuffer over += for concatenating strings 1432
The String literal " name=" appears 4 times in this file; the first occurrence is on line 1,438 1438
Local variable 'attr' could be declared final 1441
Local variable 'attrType' could be declared final 1445
Prefer StringBuffer over += for concatenating strings 1455
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1461
No need to check for null before an instanceof 1477
Local variable 'typeLogic' could be declared final 1479
Prefer StringBuffer over += for concatenating strings 1487
Prefer StringBuffer over += for concatenating strings 1507
Useless parentheses. 1514
This statement may have some unnecessary parentheses 1514
Local variable 'otherEnd' could be declared final 1514
Local variable 'endType' could be declared final 1515
Prefer StringBuffer over += for concatenating strings 1529
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1535
Local variable 'endFacade' could be declared final 1545
Prefer StringBuffer over += for concatenating strings 1560
The String literal " add NavOtherEnd " appears 4 times in this file; the first occurrence is on line 1,561 1561
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 1566
Avoid if (x != y) ..; else ..; 1568 - 1575
Prefer StringBuffer over += for concatenating strings 1594
Avoid empty if statements 1600 - 1602
Avoid variables with short names like op 1610
Prefer StringBuffer over += for concatenating strings 1621
Prefer StringBuffer over += for concatenating strings 1635
Prefer StringBuffer over += for concatenating strings 1649
Parameter 'modelElement' is not assigned and could be declared final 1677
A catch statement should never catch throwable since it includes errors. 1699
Local variable 'errMsg' could be declared final 1701
Line too long 1709
Parameter 'facade' is not assigned and could be declared final 1716
Parameter 'follow' is not assigned and could be declared final 1716
Local variable 'rtn' could be declared final 1718
A method should have only one exit point, and that should be the last statement in the method 1722
Local variable 'attr' could be declared final 1727
A method should have only one exit point, and that should be the last statement in the method 1730
Local variable 'fqn' could be declared final 1736
Local variable 'cpkg' could be declared final 1737
Avoid empty if statements 1741 - 1744
A method should have only one exit point, and that should be the last statement in the method 1748
A method should have only one exit point, and that should be the last statement in the method 1755
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
Avoid reassigning parameters such as 'namespace' 1772
A method should have only one exit point, and that should be the last statement in the method 1776
Parameter 'namespace' is not assigned and could be declared final 1841
Parameter 'elementName' is not assigned and could be declared final 1841
A method should have only one exit point, and that should be the last statement in the method 1845
Parameter 'facade' is not assigned and could be declared final 1855
Parameter 'useMany' is not assigned and could be declared final 1866
Parameter 'facade' is not assigned and could be declared final 1866
The method createConstructor() has an NCSS line count of 218 1879 - 2283
The method 'createConstructor' has a Cyclomatic Complexity of 110. 1879 - 2283
Avoid reassigning parameters such as 'facade' 1879
Parameter 'parent' is not assigned and could be declared final 1879
Avoid really long methods. 1879 - 2283
Avoid reassigning parameters such as 'facade' 1879
Avoid reassigning parameters such as 'facade' 1879
The method createConstructor() has an NPath complexity of 861020162 1879 - 2283
Parameter 'useMany' is not assigned and could be declared final 1879
Avoid reassigning parameters such as 'facade' 1879
A method should have only one exit point, and that should be the last statement in the method 1883
Local variable 'name' could be declared final 1889
Local variable 'collectionType' could be declared final 1892
Local variable 'classifier' could be declared final 1915
Local variable 'attr' could be declared final 1921
Local variable 'attr' could be declared final 1939
Local variable 'attr' could be declared final 1957
Local variable 'attr' could be declared final 1980
Local variable 'attr' could be declared final 1998
Local variable 'wsdlType' could be declared final 2027
The String literal " type=" appears 4 times in this file; the first occurrence is on line 2,049 2049
Local variable 'enumer' could be declared final 2062
Local variable 'literals' could be declared final 2064
Local variable 'literal' could be declared final 2068
Local variable 'enumLiteral' could be declared final 2071
Local variable 'useEnumValueInXSD' could be declared final 2073
Local variable 'attrib' could be declared final 2085
Prefer StringBuffer over += for concatenating strings 2095
Prefer StringBuffer over += for concatenating strings 2099
Avoid if (x != y) ..; else ..; 2105 - 2125
The String literal "new " appears 6 times in this file; the first occurrence is on line 2,107 2107
Useless parentheses. 2129
Useless parentheses. 2133
Useless parentheses. 2137
Useless parentheses. 2142
Useless parentheses. 2179
Avoid if (x != y) ..; else ..; 2179
Useless parentheses. 2183
Avoid if (x != y) ..; else ..; 2183
Prefer StringBuffer over += for concatenating strings 2194
Prefer StringBuffer over += for concatenating strings 2198
Avoid if (x != y) ..; else ..; 2217 - 2271
The String literal ")new " appears 4 times in this file; the first occurrence is on line 2,224 2224
Local variable 'spec' could be declared final 2244
Local variable 'generalization' could be declared final 2255
Local variable 'spec' could be declared final 2256
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 2278
Avoid printStackTrace(); use a logger call instead. 2280
Parameter 'added' is not assigned and could be declared final 2292
Parameter 'element' is not assigned and could be declared final 2292
The method getServiceDescendantPackages() has an NPath complexity of 936 2292 - 2349
Avoid reassigning parameters such as 'pkgRef' 2292
Avoid reassigning parameters such as 'pkgRef' 2292
The method 'getServiceDescendantPackages' has a Cyclomatic Complexity of 21. 2292 - 2349
Avoid using if statements without curly braces 2294
A method should have only one exit point, and that should be the last statement in the method 2294
Local variable 'pkg' could be declared final 2295
Avoid using if statements without curly braces 2296 - 2297
A method should have only one exit point, and that should be the last statement in the method 2297
The String literal "getServiceDescendantPackages " appears 5 times in this file; the first occurrence is on line 2,305 2305
The String literal " size=" appears 5 times in this file; the first occurrence is on line 2,305 2305
Local variable 'classifier' could be declared final 2309
Local variable 'attrib' could be declared final 2320
Local variable 'assoc' could be declared final 2334
Parameter 'service' is not assigned and could be declared final 2358
Parameter 'follow' is not assigned and could be declared final 2358
Local variable 'added' could be declared final 2365
Avoid variables with short names like op 2367
Line too long 2379
Parameter 'follow' is not assigned and could be declared final 2411
Parameter 'service' is not assigned and could be declared final 2411
Local variable 'typeRef' could be declared final 2413
Local variable 'opRef' could be declared final 2415
Avoid variables with short names like op 2422
Avoid reassigning parameters such as 'packageName' 2502
A method should have only one exit point, and that should be the last statement in the method 2506
Avoid variables with short names like df 2515
Parameter 'format' is not assigned and could be declared final 2523
Singleton is not thread safe 2525 - 2528
Parameter 'mappings' is not assigned and could be declared final 2553
Parameter 'from' is not assigned and could be declared final 2553
Parameter 'type' is not assigned and could be declared final 2584
Parameter 'schemaTypeMappings' is not assigned and could be declared final 2585
Avoid reassigning parameters such as 'namespacePrefix' 2586
Parameter 'qName' is not assigned and could be declared final 2587
Parameter 'wrappedArrayTypePrefix' is not assigned and could be declared final 2588
Parameter 'withPrefix' is not assigned and could be declared final 2589
Parameter 'preserveArray' is not assigned and could be declared final 2590
Local variable 'modelName' could be declared final 2593
Local variable 'mappedValue' could be declared final 2597
Local variable 'nonArray' could be declared final 2610
Parameter 'element' is not assigned and could be declared final 2665
Local variable 'attrib' could be declared final 2673
Local variable 'association' could be declared final 2679
Local variable 'param' could be declared final 2685
Local variable 'attrib' could be declared final 2691
Local variable 'association' could be declared final 2697
Local variable 'param' could be declared final 2703
Local variable 'classifier' could be declared final 2709
A method should have only one exit point, and that should be the last statement in the method 2714
These nested if statements could be combined 2720 - 2723

org/andromda/cartridges/webservice/metafacades/WSDLEnumerationTypeLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 25
Parameter 'context' is not assigned and could be declared final 25
Variables that are final and static should be all capitals, 'logger' is not all capitals. 33
Unnecessary wrapper object creation 101
Line too long 110
Parameter 'preserveArray' is not assigned and could be declared final 112
Parameter 'withPrefix' is not assigned and could be declared final 112
Local variable 'name' could be declared final 133
Local variable 'property' could be declared final 146
A catch statement should never catch throwable since it includes errors. 157
Local variable 'errMsg' could be declared final 159
Local variable 'property' could be declared final 180
Unnecessary wrapper object creation 183
A method should have only one exit point, and that should be the last statement in the method 183

org/andromda/cartridges/webservice/metafacades/WSDLTypeAssociationEndLogicImpl.java

Violation Line
Parameter 'context' is not assigned and could be declared final 25
Parameter 'metaObject' is not assigned and could be declared final 25
Line too long 40
Parameter 'validationMessages' is not assigned and could be declared final 46
A catch statement should never catch throwable since it includes errors. 62
Local variable 'cause' could be declared final 64

org/andromda/cartridges/webservice/metafacades/WSDLTypeAttributeLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 27
Parameter 'context' is not assigned and could be declared final 27
Avoid empty if statements 77 - 79
Local variable 'isElement' could be declared final 95
Local variable 'isAttribute' could be declared final 124
Use bitwise inversion to invert boolean values 143
Line too long 150
Parameter 'validationMessages' is not assigned and could be declared final 156
A catch statement should never catch throwable since it includes errors. 173
Local variable 'cause' could be declared final 175

org/andromda/cartridges/webservice/metafacades/WSDLTypeLogicImpl.java

Violation Line
Parameter 'context' is not assigned and could be declared final 32
Parameter 'metaObject' is not assigned and could be declared final 32
Variables that are final and static should be all capitals, 'logger' is not all capitals. 40
Parameter 'withPrefix' is not assigned and could be declared final 57
Parameter 'preserveArray' is not assigned and could be declared final 57
Local variable 'name' could be declared final 69
Local variable 'property' could be declared final 124
A catch statement should never catch throwable since it includes errors. 136
Local variable 'errMsg' could be declared final 138
Unnecessary wrapper object creation 183
These nested if statements could be combined 196 - 201
Variables that are final and static should be all capitals, 'weboperations' is not all capitals. 206
Local variable 'classifier' could be declared final 220
Local variable 'isService' could be declared final 222
Local variable 'operation' could be declared final 223
Local variable 'visibility' could be declared final 225
Local variable 'op' could be declared final 233
Avoid variables with short names like op 233
Local variable 'exception' could be declared final 235

org/andromda/cartridges/webservice/metafacades/WebServiceLogicImpl.java

Violation Line
A high number of imports can indicate a high degree of coupling within an object. 1 - 1673
The class 'WebServiceLogicImpl' has a Cyclomatic Complexity of 4 (Highest = 22). 53 - 1673
Avoid really long classes. 53 - 1673
This class has too many methods, consider refactoring it. 55 - 1673
Parameter 'metaObject' is not assigned and could be declared final 63
Parameter 'context' is not assigned and could be declared final 64
Variables that are final and static should be all capitals, 'logger' is not all capitals. 72
Local variable 'operations' could be declared final 82
Parameter 'object' is not assigned and could be declared final 87
Local variable 'methodNames' could be declared final 112
Local variable 'operations' could be declared final 113
Local variable 'operation' could be declared final 116
Found non-transient, non-static member. Please mark as transient or provide accessors. 194
Private field 'checkedTypes' could be made final; it is only initialized in the declaration or constructor. 200
Found non-transient, non-static member. Please mark as transient or provide accessors. 200
Parameter 'modelElement' is not assigned and could be declared final 262
Parameter 'types' is not assigned and could be declared final 262
Avoid really long methods. 262 - 366
The method loadTypes() has an NPath complexity of 516 262 - 366
The method 'loadTypes' has a Cyclomatic Complexity of 22. 262 - 366
Parameter 'nonArrayTypes' is not assigned and could be declared final 263
Deeply nested if..then statements are hard to read 283 - 286
Deeply nested if..then statements are hard to read 290 - 293
Deeply nested if..then statements are hard to read 295 - 356
These nested if statements could be combined 326 - 336
A catch statement should never catch throwable since it includes errors. 360
Found non-transient, non-static member. Please mark as transient or provide accessors. 371
Parameter 'pkgName' is not assigned and could be declared final 398
A method should have only one exit point, and that should be the last statement in the method 402
Local variable 'namespaceCount' could be declared final 416
Parameter 'types' is not assigned and could be declared final 431
The method setPkgAbbr() has an NPath complexity of 630 431 - 479
Local variable 'pkgAbbr' could be declared final 433
Avoid variables with short names like op 436
Local variable 'arg' could be declared final 440
Local variable 'pkg' could be declared final 441
Local variable 'pkg' could be declared final 450
Local variable 'pkg' could be declared final 459
Local variable 'type' could be declared final 469
Local variable 'pkg' could be declared final 470
Private field 'packageRefs' could be made final; it is only initialized in the declaration or constructor. 484
Found non-transient, non-static member. Please mark as transient or provide accessors. 484
Parameter 'follow' is not assigned and could be declared final 492
Parameter 'pkg' is not assigned and could be declared final 492
Parameter 'types' is not assigned and could be declared final 512
Parameter 'follow' is not assigned and could be declared final 512
Avoid really long methods. 512 - 648
Local variable 'element' could be declared final 520
Local variable 'type' could be declared final 523
Local variable 'pkg' could be declared final 524
Useless parentheses. 532
This statement may have some unnecessary parentheses 532
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 539
Local variable 'type' could be declared final 548
Local variable 'pkg' could be declared final 549
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 564
Avoid catching generic exceptions such as NullPointerException, RuntimeException, Exception in try-catch block 577
Avoid variables with short names like op 630
Local variable 'arg' could be declared final 634
Local variable 'pkg' could be declared final 643
Parameter 'pkg' is not assigned and could be declared final 650
Parameter 'type' is not assigned and could be declared final 650
Parameter 'pkgRef' is not assigned and could be declared final 650
Avoid if (x != y) ..; else ..; 653 - 663
Parameter 'object' is not assigned and could be declared final 700
Local variable 'end' could be declared final 720
These nested if statements could be combined 740 - 743
Parameter 'modelElement' is not assigned and could be declared final 755
Found non-transient, non-static member. Please mark as transient or provide accessors. 792
Parameter 'objectA' is not assigned and could be declared final 806
Parameter 'objectB' is not assigned and could be declared final 807
Avoid variables with short names like a 809
Avoid variables with short names like b 815
Parameter 'modelElement' is not assigned and could be declared final 834
A catch statement should never catch throwable since it includes errors. 861
Local variable 'errMsg' could be declared final 863
Use explicit scoping instead of the default package private level 872
Use explicit scoping instead of the default package private level 891
Use explicit scoping instead of the default package private level 910
Use explicit scoping instead of the default package private level 930
Unnecessary wrapper object creation 939
Local variable 'jndiName' could be declared final 948
Local variable 'jndiNamePrefix' could be declared final 949
Assigning an Object to null is a code smell. Consider refactoring. 968
Found non-transient, non-static member. Please mark as transient or provide accessors. 1043
Parameter 'objectA' is not assigned and could be declared final 1057
Parameter 'objectB' is not assigned and could be declared final 1058
Avoid variables with short names like a 1060
Local variable 'a' could be declared final 1060
Avoid variables with short names like b 1061
Local variable 'b' could be declared final 1061
Local variable 'property' could be declared final 1086
Avoid if (x != y) ..; else ..; 1087
Useless parentheses. 1087
Local variable 'roles' could be declared final 1096
Parameter 'object' is not assigned and could be declared final 1112
Avoid excessively long variable names like TEST_IMPLEMENTATION_NAME_PATTERN 1237
Local variable 'property' could be declared final 1267
A catch statement should never catch throwable since it includes errors. 1279
Local variable 'errMsg' could be declared final 1281
Parameter 'pkg' is not assigned and could be declared final 1332
Local variable 'contexts' could be declared final 1439
Local variable 'parsed' could be declared final 1448
Use asList instead of tight loops 1451
Prefer StringBuffer over += for concatenating strings 1494
Prefer StringBuffer over += for concatenating strings 1498
Local variable 'operations' could be declared final 1565
Local variable 'operation' could be declared final 1566
Local variable 'restProduces' could be declared final 1568
Local variable 'rest' could be declared final 1590
Local variable 'operation' could be declared final 1591
Local variable 'rest' could be declared final 1608
Local variable 'operation' could be declared final 1609
Local variable 'property' could be declared final 1628
Unnecessary wrapper object creation 1631
A method should have only one exit point, and that should be the last statement in the method 1631
Parameter 'validationMessages' is not assigned and could be declared final 1641
Local variable 'constraintValid' could be declared final 1648 - 1650
A catch statement should never catch throwable since it includes errors. 1660
Local variable 'cause' could be declared final 1662

org/andromda/cartridges/webservice/metafacades/WebServiceOperationLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 36
Parameter 'context' is not assigned and could be declared final 37
Variables that are final and static should be all capitals, 'logger' is not all capitals. 45
Line too long 48
Local variable 'visibility' could be declared final 54
Avoid excessively long variable names like TEST_IMPLEMENTATION_OPERATION_NAME_PREFIX 62
Local variable 'arguments' could be declared final 110
Local variable 'service' could be declared final 116
The String literal "WSCustomHeader" appears 4 times in this file; the first occurrence is on line 117 117
Local variable 'serviceElementName' could be declared final 119
Local variable 'serviceNamespace' could be declared final 120
Local variable 'serviceClassName' could be declared final 121
Local variable 'serviceParameterName' could be declared final 122
Prefer StringBuffer over += for concatenating strings 126
Prefer StringBuffer over += for concatenating strings 128
Prefer StringBuffer over += for concatenating strings 131
Prefer StringBuffer over += for concatenating strings 133
Local variable 'securityElementName' could be declared final 137
Local variable 'securityNamespace' could be declared final 138
Local variable 'securityClassName' could be declared final 139
Local variable 'securityParameterName' could be declared final 140
Prefer StringBuffer over += for concatenating strings 144
Prefer StringBuffer over += for concatenating strings 146
Prefer StringBuffer over += for concatenating strings 149
Prefer StringBuffer over += for concatenating strings 151
Avoid excessively long variable names like PROPERTY_DEFAULT_PARAMETER_STYLE 191
Local variable 'pathBuffer' could be declared final 271
Local variable 'parameters' could be declared final 276
Local variable 'param' could be declared final 279
Local variable 'paramName' could be declared final 282
Local variable 'pathBuffer' could be declared final 316
Local variable 'service' could be declared final 317
Local variable 'servicePath' could be declared final 318
Local variable 'wsutils' could be declared final 319
Local variable 'parameters' could be declared final 323
Local variable 'param' could be declared final 326
Line too long 327
Local variable 'parameters' could be declared final 349
Local variable 'param' could be declared final 352
Line too long 362
Prefer StringBuffer over += for concatenating strings 365
Use equals() to compare object references. 379
Use equals() to compare object references. 383
Parameter 'input' is not assigned and could be declared final 440
Avoid variables with short names like AT 469
Prefer StringBuffer over += for concatenating strings 483
Local variable 'suspend' could be declared final 494
A method should have only one exit point, and that should be the last statement in the method 497
Local variable 'service' could be declared final 554
Local variable 'rest' could be declared final 555
Local variable 'webserviceStack' could be declared final 590
Position literals first in String comparisons 591
Position literals first in String comparisons 591
Local variable 'exceptions' could be declared final 593
Local variable 'exception' could be declared final 594
Line too long 617
Parameter 'validationMessages' is not assigned and could be declared final 623
Local variable 'constraintValid' could be declared final 630 - 632
A catch statement should never catch throwable since it includes errors. 642
Local variable 'cause' could be declared final 644

org/andromda/cartridges/webservice/metafacades/WebServicePackageLogicImpl.java

Violation Line
Parameter 'context' is not assigned and could be declared final 37
Parameter 'metaObject' is not assigned and could be declared final 37
Variables that are final and static should be all capitals, 'logger' is not all capitals. 45
Use explicit scoping instead of the default package private level 90
Use explicit scoping instead of the default package private level 94
Unnecessary wrapper object creation 105
Local variable 'namespacePattern' could be declared final 109
Local variable 'addNamespaceBackslash' could be declared final 113
Prefer StringBuffer over += for concatenating strings 116
Local variable 'utils' could be declared final 128
Local variable 'utils' could be declared final 172
Line too long 191
Local variable 'utils' could be declared final 195
Parameter 'follow' is not assigned and could be declared final 205
Local variable 'utils' could be declared final 207
Parameter 'object' is not assigned and could be declared final 215
No need to check for null before an instanceof 217
A method should have only one exit point, and that should be the last statement in the method 219
Local variable 'operations' could be declared final 231
Local variable 'webserviceStack' could be declared final 233
Position literals first in String comparisons 234
Position literals first in String comparisons 234
Local variable 'operation' could be declared final 236
Local variable 'operationName' could be declared final 239
Local variable 'operationToCheck' could be declared final 240
Local variable 'webserviceStack' could be declared final 266
Local variable 'importedSchema' could be declared final 267
Position literals first in String comparisons 268
Position literals first in String comparisons 268
Position literals first in String comparisons 268
Local variable 'serviceCount' could be declared final 270
Local variable 'references' could be declared final 285
Local variable 'pkg' could be declared final 286
Line too long 305
Parameter 'validationMessages' is not assigned and could be declared final 311
Invoke equals() on the object you've already ensured is not null 318
Using equalsIgnoreCase() is cleaner than using toUpperCase/toLowerCase().equals(). 318
Local variable 'constraintValid' could be declared final 318
A catch statement should never catch throwable since it includes errors. 330
Local variable 'cause' could be declared final 332

org/andromda/cartridges/webservice/metafacades/WebServiceParameterLogicImpl.java

Violation Line
Parameter 'metaObject' is not assigned and could be declared final 29
Parameter 'context' is not assigned and could be declared final 29
Variables that are final and static should be all capitals, 'logger' is not all capitals. 37
Local variable 'service' could be declared final 58
Local variable 'webService' could be declared final 61
Deeply nested if..then statements are hard to read 70 - 73
Prefer StringBuffer over += for concatenating strings 166
Avoid variables with short names like AT 172
Prefer StringBuffer over += for concatenating strings 184
Line too long 217
Parameter 'validationMessages' is not assigned and could be declared final 223
A catch statement should never catch throwable since it includes errors. 239
Local variable 'cause' could be declared final 241